From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: David Edmondson Newsgroups: gmane.emacs.bugs Subject: bug#40280: gnus-cloud doesn't do anything useful Date: Wed, 17 Jun 2020 09:13:29 +0100 Message-ID: References: <87y2omq1q2.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99987"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 40280@debbugs.gnu.org, Ted Zlatanov To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 17 10:14:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlTD0-000Prl-1u for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jun 2020 10:14:10 +0200 Original-Received: from localhost ([::1]:55714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlTCz-0005TR-0T for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jun 2020 04:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlTCs-0005TF-O6 for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 04:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38753) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlTCs-0002Hi-FN for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 04:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlTCs-000426-6w; Wed, 17 Jun 2020 04:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 17 Jun 2020 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40280 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 40280-submit@debbugs.gnu.org id=B40280.159238162315465 (code B ref 40280); Wed, 17 Jun 2020 08:14:02 +0000 Original-Received: (at 40280) by debbugs.gnu.org; 17 Jun 2020 08:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:50298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlTCY-00041M-Jj for submit@debbugs.gnu.org; Wed, 17 Jun 2020 04:13:42 -0400 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:37425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlTCU-000413-K9 for 40280@debbugs.gnu.org; Wed, 17 Jun 2020 04:13:41 -0400 Original-Received: by mail-wr1-f53.google.com with SMTP id x13so1303414wrv.4 for <40280@debbugs.gnu.org>; Wed, 17 Jun 2020 01:13:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version:content-transfer-encoding; bh=SXS2lA+CIlXzabjN31CYaluaiCMXRNrwCpIcuSMjgMA=; b=sZSOGzl3Pno0NMWlSYFzaPChrw5Vx1fvLW3zA8uNmAPoD72jxMq98rrmfDZJewGI40 UtzddRtVZ+QrfT/eEjju/XL38AupPqP1Hk/Ax/pUno99SyVFE38bONl8WDqEs83JCkZq mjKv2GHUqUKq+OxXiDJwG1SZ3akO7tvD268CNuvd4IKqtmfss60d4eTMaQxtMgT57YDp XwhK8XoVAqBtk2DlSDHpFdzyeRbp73ByKiof1ZQSS/O2dLIVjLP08gjGr38KdQXt3Ye+ WSCMbM7JgquKt42/mv4O3cIohWZAmS1QR2QtBXLXBoxGQIC6+WhUJL3FsLxFbIu0GDWg /4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version:content-transfer-encoding; bh=SXS2lA+CIlXzabjN31CYaluaiCMXRNrwCpIcuSMjgMA=; b=G6rf2SZ7OUL2WTMiXQ/Y2bBQZtv6jhbCbMesVQwk6wiyE08XTNjOg9jHNSmJa/W3CC jdFswZdXPIa+a49fcSSs/geW/M2VgIlpxcICsLYL/UMnNxVjcE3eQLngiJ+QrM7SqQ1o hcRAjeK61rtRzxtdqb/uwbWEkZ9k6Wmj9qZP0aW8SNiCnmqX8NUWNfHxwhaFDzGgnsJt 9XsipNdC5vrxcPXDnQsWNMrSgePJicQ0J6zPdiIj+4U/ZQ6rtLcejCcwDP4eVfLVgEac P9RrVfCaYRukfFSU4xIr3KyhhrKzHWMVBX5i/vZPsRL5moYcgSRXW3kAR/Ri0y6gmrGE KfPg== X-Gm-Message-State: AOAM531VQUJjFuKDlFSvKtiEcNdzDFPlFRiAywmN4eYFpBKdzd/li972 8mCO4KRhAUwtXNglXLSc0zOBKpC/ssd/uA== X-Google-Smtp-Source: ABdhPJxqDqdv49rbHxwGproOZDz4hgLS5HvOellxofivgu2hss6ImbUBskJ+/H5Jedc+XWZ5wIabMQ== X-Received: by 2002:adf:df03:: with SMTP id y3mr6843530wrl.376.1592381612119; Wed, 17 Jun 2020 01:13:32 -0700 (PDT) Original-Received: from disaster-area.hh.sledj.net (8.a.e.d.0.0.0.0.0.0.0.0.4.6.0.0.0.4.1.7.1.7.b.b.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:bb71:7140:64::dea8]) by smtp.gmail.com with ESMTPSA id n1sm32105337wrp.10.2020.06.17.01.13.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 01:13:31 -0700 (PDT) Original-Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 6c750dfd; Wed, 17 Jun 2020 08:13:30 +0000 (UTC) In-Reply-To: <87y2omq1q2.fsf@tcd.ie> X-HGTTG: heart-of-gold X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182064 Archived-At: On Tuesday, 2020-06-16 at 19:56:05 +01, Basil L. Contovounesios wrote: >> From a3bdd2219855a72e2ee90de1b6f823c9678a470c Mon Sep 17 00:00:00 2001 >> From: David Edmondson >> Date: Sat, 28 Mar 2020 19:03:58 +0000 >> Subject: [PATCH] gnus-cloud: Improve cloud sync >> >> After replaying a set of actions downloaded by gnus-cloud, persist the >> highest sequence number seen as the local `gnus-cloud-sequence' >> number, in order that a future download will not unnecessarily replay >> previously seen actions and any future uploads from this emacs >> instance use a higher sequence number than that downloaded. >> >> Remove the test on whether individual newsrc entries are older than >> the current time, as that is always going to be the case. > > In the future please follow the formatting guidelines for change log > messages described in the file CONTRIBUTE. Understood. > [...] > >> --- a/lisp/gnus/gnus-cloud.el >> +++ b/lisp/gnus/gnus-cloud.el >> @@ -480,7 +478,9 @@ Otherwise, returns the Gnus Cloud data chunks." >> (push (gnus-cloud-parse-chunk) chunks) >> (forward-line 1)))) >> (if update >> - (mapcar #'gnus-cloud-update-all chunks) >> + (progn >> + (mapcar #'gnus-cloud-update-all chunks) >> + (setq gnus-cloud-sequence highest-sequence-seen)) >> chunks))) > > This change means the result of the mapcar is no longer used or > returned, giving rise to the following warning: > > In gnus-cloud-download-data: > gnus/gnus-cloud.el:482:12: Warning: =E2=80=98mapcar=E2=80=99 called for= effect; use =E2=80=98mapc=E2=80=99 or > =E2=80=98dolist=E2=80=99 instead > > It also makes highest-sequence-seen the return value of > gnus-cloud-download-data. Is this intended? No, it's not an intended change and is not desirable. Presumably replacing `progn' with `prog1' would properly restore the previous behaviour. Should I submit a further patch? dme. --=20 J'aurais toujours faim de toi.