From: Matt Armstrong <matt@rfc20.org>
To: Juri Linkov <juri@jurta.org>
Cc: 46396@debbugs.gnu.org
Subject: bug#46396: 27.1.90; Ediff's non-focused diff section, background too light in --reverse
Date: Wed, 10 Feb 2021 10:24:05 -0800 [thread overview]
Message-ID: <m2sg63hjcq.fsf@matts-mbp-2016.lan> (raw)
In-Reply-To: <87blcs2f9q.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Feb 2021 19:01:21 +0200")
Juri Linkov <juri@jurta.org> writes:
[...]
> After changing background colors to darker colors and adding
> :distant-foreground I tried different default foreground colors with
>
> M-x set-foreground-color RET dark grey RET
>
> and it seems everything looks readable.
>
> Do you see more problems with the following patch?
[...]
Juri, this is a definite improvement, thank you. Committing it as it is
seems reasonable since it makes unreadable text readable again.
I applied this patch and played around with applying various light and
dark themes.
Some comments:
In the "tango-dark" theme:
a) the non-current diff backgrounds are quite close to the theme's dark
background color, so they are not very noticeable.
b) the current diff (such as `ediff-current-diff-B`) is also quite close
to the theme's background color.
In the "tango-light" theme:
c) `ediff-current-diff-A' is quite dark (a darker blue/purple), and the
foreground color is hard to read over it. This is a little odd,
because `ediff-current-diff-B' is a fairly bright yellow background.
I saw similar issues in the various other standard themes (loading up
the mater branch with src/emacs -Q).
The issues I see with ediff-current-* faces are arguably a tangent to
this bug. Perhaps those faces could use :distant-foreground as well, for
similar reasons?
As for the background colors possibly being quite similar to the theme's
background, I'm not sure what to do about that.
next prev parent reply other threads:[~2021-02-10 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 9:19 bug#46396: 27.1.90; Ediff's non-focused diff section, background too light in --reverse bug-gnu-emacs_at_gnu.org
2021-02-10 6:46 ` Matt Armstrong
2021-02-10 7:24 ` Matt Armstrong
2021-02-10 17:01 ` Juri Linkov
2021-02-10 18:24 ` Matt Armstrong [this message]
2021-02-10 19:39 ` Juri Linkov
2021-02-10 20:28 ` Matt Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sg63hjcq.fsf@matts-mbp-2016.lan \
--to=matt@rfc20.org \
--cc=46396@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).