From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#46396: 27.1.90; Ediff's non-focused diff section, background too light in --reverse Date: Wed, 10 Feb 2021 10:24:05 -0800 Message-ID: References: <87blcs2f9q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29598"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: 46396@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 19:27:01 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9uCb-0007XE-9D for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 19:27:01 +0100 Original-Received: from localhost ([::1]:47502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9uCa-0007Yb-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 13:27:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9uAf-0006QB-V3 for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 13:25:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9uAf-0005Ie-NI for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 13:25:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9uAf-0003Hl-Iz for bug-gnu-emacs@gnu.org; Wed, 10 Feb 2021 13:25:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46396 X-GNU-PR-Package: emacs Original-Received: via spool by 46396-submit@debbugs.gnu.org id=B46396.161298146212582 (code B ref 46396); Wed, 10 Feb 2021 18:25:01 +0000 Original-Received: (at 46396) by debbugs.gnu.org; 10 Feb 2021 18:24:22 +0000 Original-Received: from localhost ([127.0.0.1]:57209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9uA2-0003Gs-2T for submit@debbugs.gnu.org; Wed, 10 Feb 2021 13:24:22 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:42295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9u9x-0003GY-Jn for 46396@debbugs.gnu.org; Wed, 10 Feb 2021 13:24:20 -0500 Original-Received: from matts-mbp-2016.lan (24-113-169-116.wavecable.com [24.113.169.116]) (Authenticated sender: matt@rfc20.org) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 9B0BB200008; Wed, 10 Feb 2021 18:24:08 +0000 (UTC) In-Reply-To: <87blcs2f9q.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Feb 2021 19:01:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199791 Archived-At: Juri Linkov writes: [...] > After changing background colors to darker colors and adding > :distant-foreground I tried different default foreground colors with > > M-x set-foreground-color RET dark grey RET > > and it seems everything looks readable. > > Do you see more problems with the following patch? [...] Juri, this is a definite improvement, thank you. Committing it as it is seems reasonable since it makes unreadable text readable again. I applied this patch and played around with applying various light and dark themes. Some comments: In the "tango-dark" theme: a) the non-current diff backgrounds are quite close to the theme's dark background color, so they are not very noticeable. b) the current diff (such as `ediff-current-diff-B`) is also quite close to the theme's background color. In the "tango-light" theme: c) `ediff-current-diff-A' is quite dark (a darker blue/purple), and the foreground color is hard to read over it. This is a little odd, because `ediff-current-diff-B' is a fairly bright yellow background. I saw similar issues in the various other standard themes (loading up the mater branch with src/emacs -Q). The issues I see with ediff-current-* faces are arguably a tangent to this bug. Perhaps those faces could use :distant-foreground as well, for similar reasons? As for the background colors possibly being quite similar to the theme's background, I'm not sure what to do about that.