bug#2478: 23.0.91; font antialiasing switch in nextstep broken

bug#2478: 23.0.91; font antialiasing switch in nextstep broken

[Nikolaj Schumacher]

Hello,

switching font antialiasing in nextstep doesn't work.  A fix is included.


regards,
Nikolaj Schumacher

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-02-26 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--without-x' 'CC=gcc-4.2' 'CFLAGS=-arch i386 -O2''


diff --git a/src/nsfont.m b/src/nsfont.m
index 386637d..e2e537f 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
 
     CGContextSetFont (gcontext, font->cgfont);
     CGContextSetFontSize (gcontext, font->size);
-    if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
+    if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
       CGContextSetShouldAntialias (gcontext, 0);
     else
       CGContextSetShouldAntialias (gcontext, 1);

bug#2478: 23.0.91; font antialiasing switch in nextstep broken

[Stefan Monnier]

> --- a/src/nsfont.m
> +++ b/src/nsfont.m
> @@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
 
>      CGContextSetFont (gcontext, font->cgfont);
>      CGContextSetFontSize (gcontext, font->size);
> -    if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
> +    if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
>        CGContextSetShouldAntialias (gcontext, 0);
>      else
>        CGContextSetShouldAntialias (gcontext, 1);

If someone could try and compile the Emacs.app port
with -DUSE_LISP_UNION_TYPE, this bug (and probably several others) would
get caught during compilation.


        Stefan

bug#2478: 23.0.91; font antialiasing switch in nextstep broken

[Adrian Robert]

Thanks, I've applied the patch, leaving bug report open as a reminder  
to try this UNION_TYPE as suggested.

-Adrian

bug#2478: 23.0.91; font antialiasing switch in nextstep broken

[Glenn Morris]

Nikolaj Schumacher wrote:

> A fix is included.

With this, you have seven "tiny changes". You should complete a
copyright assignment before contributing more.

bug#2478: 23.0.91; font antialiasing switch in nextstep broken

[Adrian Robert]

> If someone could try and compile the Emacs.app port
> with -DUSE_LISP_UNION_TYPE, this bug (and probably several others)  
> would
> get caught during compilation.

I just tried this and found errors in core files relating to  
specification of Lisp_Object arguments as "register" variables.  I'm  
not sure the compiler complaint is specific to the version of gcc on  
OS X (4.0.1)?

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/Users/arobert/src/EmacsApp/ 
emacs/src -I/usr/X11R6/include -Dtemacs    -g -O2 -Wno-pointer-sign - 
DUSE_LISP_UNION_TYPE frame.c
frame.c: In function 'delete_frame':
frame.c:1505: error: address of register variable 'force' requested
make: *** [frame.o] Error 1
make: *** Waiting for unfinished jobs....

Then I got an error in nsterm that I can't make sense of:

nsterm.m: In function 'ns_term_init':
nsterm.m:3897: error: incompatible types in assignment

This line is a simple call to a DEFUN taking one arg:

Lisp_Object color_file, color_map, color;
...
color_map = Fx_load_color_file (color_file);

bug#2478: marked as done (23.0.91; font antialiasing switch in nextstep broken)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]


Your message dated Sun, 31 May 2009 12:49:28 +0700
with message-id <8EB23D91-883D-4FEF-9740-26C18FF8DAFD@gmail.com>
and subject line 
has caused the Emacs bug report #2478,
regarding 23.0.91; font antialiasing switch in nextstep broken
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2478: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2478
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3130 bytes --]

From: Nikolaj Schumacher <me@nschum.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; font antialiasing switch in nextstep broken
Date: Thu, 26 Feb 2009 09:29:06 +0100
Message-ID: <m2r61l1u0d.fsf@nschum.de>

Hello,

switching font antialiasing in nextstep doesn't work.  A fix is included.


regards,
Nikolaj Schumacher

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-02-26 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--without-x' 'CC=gcc-4.2' 'CFLAGS=-arch i386 -O2''


diff --git a/src/nsfont.m b/src/nsfont.m
index 386637d..e2e537f 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
 
     CGContextSetFont (gcontext, font->cgfont);
     CGContextSetFontSize (gcontext, font->size);
-    if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
+    if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
       CGContextSetShouldAntialias (gcontext, 0);
     else
       CGContextSetShouldAntialias (gcontext, 1);



[-- Attachment #3: Type: message/rfc822, Size: 2465 bytes --]

From: Adrian Robert <adrian.b.robert@gmail.com>
To: 2478-done@emacsbugs.donarmstrong.com
Subject: 
Date: Sun, 31 May 2009 12:49:28 +0700
Message-ID: <8EB23D91-883D-4FEF-9740-26C18FF8DAFD@gmail.com>