From: Filipp Gunbin <fgunbin@fastmail.fm>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62208@debbugs.gnu.org
Subject: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file
Date: Thu, 16 Mar 2023 17:48:07 +0300 [thread overview]
Message-ID: <m2o7os7nx4.fsf@fastmail.fm> (raw)
In-Reply-To: <83o7otqnxy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 07:12:41 +0200")
On 16/03/2023 07:12 +0200, Eli Zaretskii wrote:
>> From: Filipp Gunbin <fgunbin@fastmail.fm>
>> Date: Wed, 15 Mar 2023 20:42:31 +0300
>>
>>
>> - emacs -Q
>> - Define an abbrev using C-x a g
>> - C-x s, answer "yes"
>> - Repeat C-x s, it again asks to save abbrevs
>>
>> This is a regression since 28.1.
>
> Thanks, but do you happen to know which change introduced this
> regression? If so, can you point to that change?
It was in 1cfb89dc79b76923c1c93cb44e3e4836b6a8c2bf, here's the previous code:
- (and save-abbrevs abbrevs-changed
- (progn
- (if (or arg
- (eq save-abbrevs 'silently)
- (y-or-n-p (format "Save abbrevs in %s? "
- abbrev-file-name)))
- (write-abbrev-file nil))
- ;; Don't keep bothering user if he says no.
- (setq abbrevs-changed nil)
- (setq abbrevs-done t)))
Note (setq abbrevs-changed nil) is outside of if.
> Also, would it be possible to add a test for this issue?
Yeah, I'll try to.
Thanks.
next prev parent reply other threads:[~2023-03-16 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 17:42 bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file Filipp Gunbin
2023-03-15 18:12 ` Filipp Gunbin
2023-03-16 5:12 ` Eli Zaretskii
2023-03-16 14:48 ` Filipp Gunbin [this message]
2023-03-16 19:14 ` Filipp Gunbin
2023-03-16 20:10 ` Eli Zaretskii
2023-03-17 14:18 ` Filipp Gunbin
2023-09-06 1:55 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2o7os7nx4.fsf@fastmail.fm \
--to=fgunbin@fastmail.fm \
--cc=62208@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).