From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Filipp Gunbin Newsgroups: gmane.emacs.bugs Subject: bug#62208: 30.0.50; [PATCH] save-some-buffers repeatedly asks for saving abbrev file Date: Thu, 16 Mar 2023 17:48:07 +0300 Message-ID: References: <83o7otqnxy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3807"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62208@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 16 15:49:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcouk-0000oc-18 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Mar 2023 15:49:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcoud-0002es-IU; Thu, 16 Mar 2023 10:49:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcouc-0002ef-I7 for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 10:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcouc-0001Bo-9A for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 10:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcoub-0002BN-QW for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 10:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Filipp Gunbin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2023 14:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62208 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16789780998259 (code B ref -1); Thu, 16 Mar 2023 14:49:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 16 Mar 2023 14:48:19 +0000 Original-Received: from localhost ([127.0.0.1]:42716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcotu-000297-At for submit@debbugs.gnu.org; Thu, 16 Mar 2023 10:48:18 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:36334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcots-00028n-3m for submit@debbugs.gnu.org; Thu, 16 Mar 2023 10:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcotr-0002OU-MC for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 10:48:15 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcotp-00011h-Tr; Thu, 16 Mar 2023 10:48:15 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A25F55C0114; Thu, 16 Mar 2023 10:48:11 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 16 Mar 2023 10:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678978091; x=1679064491; bh=/b rXulQmM6cdvtgXzMvD+MWIvIMZrPMA136c2iarEn8=; b=saRlg73dT61DQSM0BB FXZpAccXxT0DE5KzjegRCYx0X63F/O3g3ffS+rZtDqGAf9eiEyIFzjmAJVEkphcU LWHjr+IIwYpQhVEQk1s7ULRwhHAnhFQiE/iaubYBVofaWsZCoQWKp3RYXiq9RVdb AfZdolLDzkrKn60et03D5OFBr/JUKsQDgFjowQ4DaZisfFq+Yj2u4Fs4rx6YdvtR gmh5l6YkrVJzXUrEd8i7PAt0yakkYr54Lxr6KeNKqA+z6RHSsys2MEL3cGlINAf3 psrTz0TDSoKcWJS+PK2xOLRe8KkyCmy8vyq5YdybPCzl/jJAgmCUftfCWaRA63D6 9vGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678978091; x=1679064491; bh=/brXulQmM6cdv tgXzMvD+MWIvIMZrPMA136c2iarEn8=; b=iKIIs3cDjiivUe0+OzK7FdgorkKy1 DIzExjCRnuRhvv1KrAGpvERq46upzj7b0ZM0noh61qVqewFfZc/vLeBG+pvw13fP X9CfoUZeyyfqF6Hc1X8d/wJv2vX1BpwdnqSbmTPVHPVFKi+RXE4M+ZWF9zSseMDw IgMomMXE5bCTA93xfIdbx/d7Pcfd01J7YLihxWthNKacKnC0xPAVAjk7Gb3S25Mo 76iuNdjKszVu0c2jMWTzwdEmdFfrGMaa/rLwN/JanFae2bRvL0UmbkwEWhRExzlF 7QWCRW22lebgc9v2yck1NGmLEC51jWcs/YcnbLGX39z9VenZ5dP8eLTQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesthdtredttdertdenucfhrhhomhephfhilhhi phhpucfiuhhnsghinhcuoehfghhunhgsihhnsehfrghsthhmrghilhdrfhhmqeenucggtf frrghtthgvrhhnpeffhfejveeiieeiudetgfehffelieevfeeffedtkeelheeludefueeu udehveeiffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehfghhunhgsihhnsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: id48c41f1:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 10:48:10 -0400 (EDT) In-Reply-To: <83o7otqnxy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Mar 2023 07:12:41 +0200") Mail-Followup-To: Eli Zaretskii , bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=66.111.4.29; envelope-from=fgunbin@fastmail.fm; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258019 Archived-At: On 16/03/2023 07:12 +0200, Eli Zaretskii wrote: >> From: Filipp Gunbin >> Date: Wed, 15 Mar 2023 20:42:31 +0300 >> >> >> - emacs -Q >> - Define an abbrev using C-x a g >> - C-x s, answer "yes" >> - Repeat C-x s, it again asks to save abbrevs >> >> This is a regression since 28.1. > > Thanks, but do you happen to know which change introduced this > regression? If so, can you point to that change? It was in 1cfb89dc79b76923c1c93cb44e3e4836b6a8c2bf, here's the previous code: - (and save-abbrevs abbrevs-changed - (progn - (if (or arg - (eq save-abbrevs 'silently) - (y-or-n-p (format "Save abbrevs in %s? " - abbrev-file-name))) - (write-abbrev-file nil)) - ;; Don't keep bothering user if he says no. - (setq abbrevs-changed nil) - (setq abbrevs-done t))) Note (setq abbrevs-changed nil) is outside of if. > Also, would it be possible to add a test for this issue? Yeah, I'll try to. Thanks.