bug#2278: 23.0.60; Tooltips truncated on OS X

bug#2278: 23.0.60; Tooltips truncated on OS X

[Nick Roberts]

On OSX all multi-line tooltips display just the first line.  I don't know if
this is a bug with OSX or Emacs: generally applications only seem to use one
line for tooltips as did Emacs until recently.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

bug#2747: [PATCH] 23.0.91; multi-line tooltips don't work on nextstep

[Nikolaj Schumacher]

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-03-22 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--with-x''


Only the first line multi-line tooltips like

  (tooltip-show "foo\nbar")

appear on nextstep.


The following patch seems to be a simple (perhaps too simple?) solution:


diff --git a/src/nsmenu.m b/src/nsmenu.m
index 9a97492..97d29e9 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -1398,10 +1398,7 @@ update_frame_tool_bar (FRAME_PTR f)
   NSColor *col = [NSColor colorWithCalibratedRed: 1.0 green: 1.0
                                             blue: 0.792 alpha: 0.95];
   NSFont *font = [NSFont toolTipsFontOfSize: 0];
-  NSFont *sfont = [font screenFont];
-  int height = [sfont ascender] - [sfont descender];
-/*[font boundingRectForFont].size.height; */
-  NSRect r = NSMakeRect (0, 0, 100, height+6);
+  NSRect r = NSMakeRect (0, 0, 100, 100);
 
   textField = [[NSTextField alloc] initWithFrame: r];
   [textField setFont: font];
@@ -1438,10 +1435,8 @@ update_frame_tool_bar (FRAME_PTR f)
 - (void) setText: (char *)text
 {
   NSString *str = [NSString stringWithUTF8String: text];
-  NSRect r = [textField frame];
-  r.size.width = [[[textField font] screenFont] widthOfString: str] + 8;
-  [textField setFrame: r];
   [textField setStringValue: str];
+  [textField sizeToFit];
 }
 
 - (void) showAtX: (int)x Y: (int)y for: (int)seconds

bug#2747: [PATCH] 23.0.91; multi-line tooltips don't work on nextstep

[YAMAMOTO Mitsuharu]

>>>>> On Sun, 22 Mar 2009 18:46:51 +0100, Nikolaj Schumacher <me@nschum.de> said:

> In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS
> apple-appkit-949.43) of 2009-03-22 on thursday Windowing system
> distributor `Apple', version 10.3.949 configured using `configure
> '--with-ns' '--with-x''


> Only the first line multi-line tooltips like

>   (tooltip-show "foo\nbar")

> appear on nextstep.


> The following patch seems to be a simple (perhaps too simple?)
> solution:

It might solve this particular problem, but I think the whole tooltip
code should be rewritten so as to use an Emacs frame like in the other
platforms.
(cf. http://lists.gnu.org/archive/html/emacs-devel/2009-03/msg00123.html)

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#2747: marked as done ([PATCH] 23.0.91; multi-line tooltips don't work on nextstep)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

Your message dated Mon, 4 Jan 2010 07:25:24 +0100
with message-id <A51A6A3E-37F9-4417-A5E9-E7AF2135D1BA@gmail.com>
and subject line done
has caused the Emacs bug report #2278,
regarding [PATCH] 23.0.91; multi-line tooltips don't work on nextstep
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)


-- 
2278: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2278
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 3359 bytes --]

From: Nikolaj Schumacher <me@nschum.de>
To: emacs-pretest-bug@gnu.org
Subject: [PATCH] 23.0.91; multi-line tooltips don't work on nextstep
Date: Sun, 22 Mar 2009 18:46:51 +0100
Message-ID: <m2mybdpi0k.fsf@nschum.de>

In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-03-22 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns' '--with-x''


Only the first line multi-line tooltips like

  (tooltip-show "foo\nbar")

appear on nextstep.


The following patch seems to be a simple (perhaps too simple?) solution:


diff --git a/src/nsmenu.m b/src/nsmenu.m
index 9a97492..97d29e9 100644
--- a/src/nsmenu.m
+++ b/src/nsmenu.m
@@ -1398,10 +1398,7 @@ update_frame_tool_bar (FRAME_PTR f)
   NSColor *col = [NSColor colorWithCalibratedRed: 1.0 green: 1.0
                                             blue: 0.792 alpha: 0.95];
   NSFont *font = [NSFont toolTipsFontOfSize: 0];
-  NSFont *sfont = [font screenFont];
-  int height = [sfont ascender] - [sfont descender];
-/*[font boundingRectForFont].size.height; */
-  NSRect r = NSMakeRect (0, 0, 100, height+6);
+  NSRect r = NSMakeRect (0, 0, 100, 100);
 
   textField = [[NSTextField alloc] initWithFrame: r];
   [textField setFont: font];
@@ -1438,10 +1435,8 @@ update_frame_tool_bar (FRAME_PTR f)
 - (void) setText: (char *)text
 {
   NSString *str = [NSString stringWithUTF8String: text];
-  NSRect r = [textField frame];
-  r.size.width = [[[textField font] screenFont] widthOfString: str] + 8;
-  [textField setFrame: r];
   [textField setStringValue: str];
+  [textField sizeToFit];
 }
 
 - (void) showAtX: (int)x Y: (int)y for: (int)seconds



[-- Attachment #3: Type: message/rfc822, Size: 2937 bytes --]

From: David Reitter <david.reitter@gmail.com>
To: 2278-done@debbugs.gnu.org
Subject: done
Date: Mon, 4 Jan 2010 07:25:24 +0100
Message-ID: <A51A6A3E-37F9-4417-A5E9-E7AF2135D1BA@gmail.com>

patch was checked in 2009-06-14.

bug#2278: marked as done (23.0.60; Tooltips truncated on OS X)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

Your message dated Mon, 4 Jan 2010 07:25:24 +0100
with message-id <A51A6A3E-37F9-4417-A5E9-E7AF2135D1BA@gmail.com>
and subject line done
has caused the Emacs bug report #2278,
regarding 23.0.60; Tooltips truncated on OS X
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)


-- 
2278: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2278
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 2348 bytes --]

From: Nick Roberts <nickrob@snap.net.nz>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; Tooltips truncated on OS X
Date: Wed, 11 Feb 2009 23:06:41 +1300
Message-ID: <18834.41777.850731.923577@kahikatea.snap.net.nz>


On OSX all multi-line tooltips display just the first line.  I don't know if
this is a bug with OSX or Emacs: generally applications only seem to use one
line for tooltips as did Emacs until recently.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



[-- Attachment #3: Type: message/rfc822, Size: 2937 bytes --]

From: David Reitter <david.reitter@gmail.com>
To: 2278-done@debbugs.gnu.org
Subject: done
Date: Mon, 4 Jan 2010 07:25:24 +0100
Message-ID: <A51A6A3E-37F9-4417-A5E9-E7AF2135D1BA@gmail.com>

patch was checked in 2009-06-14.