From: Alex Bochannek <alex@bochannek.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
61549@debbugs.gnu.org
Subject: bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions
Date: Sat, 18 Feb 2023 17:59:15 -0800 [thread overview]
Message-ID: <m2lekuo1os.fsf@bochannek.com> (raw)
In-Reply-To: <83sff41zgm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Feb 2023 10:13:45 +0200")
Eli,
Thanks for all the doc string comments, I was not sure about them and I
don't think I knew about checkdoc. I should spend some more time with
Appendix D of the Elisp manual.
Eli Zaretskii <eliz@gnu.org> writes:
>> + (let ((arg
>> + (cond ((or (consp arg) (null arg)) 0)
>> + ((eq '- arg) -1)
>> + (t arg))))
>
> This seems to imply that ARG has meaning beyond what the above text
> says.
I was struggling a bit with this one. On the one hand, I wanted the raw
prefix because I didn't want `C-u' to turn into 4, on the other hand, I
still wanted to let `C-u -' be interpreted as -1. Is there a better way
to do this?
I am updating the doc strings and submit a new version in the next few
days.
Thanks for the review!
--
Alex.
next prev parent reply other threads:[~2023-02-19 1:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 8:17 bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions Alex Bochannek
2023-02-17 8:13 ` Eli Zaretskii
2023-02-19 1:59 ` Alex Bochannek [this message]
2023-02-19 6:54 ` Eli Zaretskii
2023-03-06 3:37 ` Alex Bochannek
2023-03-11 8:49 ` Eli Zaretskii
2023-03-12 0:19 ` Michael Heerdegen
2024-05-22 23:57 ` Alex Bochannek
2024-05-23 5:36 ` Eli Zaretskii
2024-06-01 0:19 ` Alex Bochannek
2024-06-02 6:01 ` Eli Zaretskii
2024-06-02 23:33 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 11:33 ` Eli Zaretskii
2024-06-04 0:56 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 1:40 ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 2:01 ` Alex Bochannek
2024-06-05 13:52 ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 14:37 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lekuo1os.fsf@bochannek.com \
--to=alex@bochannek.com \
--cc=61549@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).