From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Alex Bochannek Newsgroups: gmane.emacs.bugs Subject: bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions Date: Sat, 18 Feb 2023 17:59:15 -0800 Message-ID: References: <83sff41zgm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33783"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , Stefan Monnier , 61549@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 19 03:00:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTZ0G-0008gJ-GN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Feb 2023 03:00:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTYzz-0006DT-18; Sat, 18 Feb 2023 21:00:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTYzj-0006By-RG for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 21:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTYzi-00009d-De for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 21:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTYzi-0001qQ-3s for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 21:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alex Bochannek Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Feb 2023 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61549 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61549-submit@debbugs.gnu.org id=B61549.16767719617010 (code B ref 61549); Sun, 19 Feb 2023 02:00:02 +0000 Original-Received: (at 61549) by debbugs.gnu.org; 19 Feb 2023 01:59:21 +0000 Original-Received: from localhost ([127.0.0.1]:45275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTYz3-0001oy-EM for submit@debbugs.gnu.org; Sat, 18 Feb 2023 20:59:21 -0500 Original-Received: from ns.lapseofthought.com ([50.0.39.240]:60085 helo=mail.lapseofthought.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTYz1-0001op-97 for 61549@debbugs.gnu.org; Sat, 18 Feb 2023 20:59:20 -0500 Original-Received: from awb-mbp.local (c-73-92-249-246.hsd1.ca.comcast.net [73.92.249.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lapseofthought.com (Postfix) with ESMTPSA id 4PK7yX0sK5z3pdxK; Sat, 18 Feb 2023 17:59:16 -0800 (PST) Authentication-Results: ORIGINATING; auth=pass smtp.auth=alex smtp.mailfrom=alex@bochannek.com In-Reply-To: <83sff41zgm.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Feb 2023 10:13:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256014 Archived-At: Eli, Thanks for all the doc string comments, I was not sure about them and I don't think I knew about checkdoc. I should spend some more time with Appendix D of the Elisp manual. Eli Zaretskii writes: >> + (let ((arg >> + (cond ((or (consp arg) (null arg)) 0) >> + ((eq '- arg) -1) >> + (t arg)))) > > This seems to imply that ARG has meaning beyond what the above text > says. I was struggling a bit with this one. On the one hand, I wanted the raw prefix because I didn't want `C-u' to turn into 4, on the other hand, I still wanted to let `C-u -' be interpreted as -1. Is there a better way to do this? I am updating the doc strings and submit a new version in the next few days. Thanks for the review! -- Alex.