bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil.

[Keith David Bershatsky <esq@lawlist.com>]

With the modification that I made in startup.el -- building with the default gtk3 toolkit -- the fancy image takes up a substantial portion of the welcome screen such that the last partially visible line is:  "Auto-save file lists were found.  If an Emacs session crashed recently,"

I had assumed based on the comments in the function that I modified that the concern was a potential second window displaying an error message.  If the error message is displayed in that second window, then suppress the image in the welcome screen.  That is why I suggested the idea of a `one-window-p` test to determine whether an error window might be displayed.

Your idea of having all text visible in the welcome screen makes good sense.  I haven't familiarized myself with everything that goes into determining the initial default frame size or default size of subsequently created frames.  So, I have no opinion regarding what the default should be.  I also have no opinion regarding the text that makes up the contents of the welcome screen.

My primary concern when building Emacs was that perhaps I did not have proper image support because the Emacs logo was not appearing.  But, that concern has now been resolved by tracking it down to use-fancy-splash-screens-p.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

At Tue, 22 Mar 2016 18:07:18 +0200,
Eli Zaretskii wrote:
> 
> * * *
> 
> Then, with the code you modified in startup.el, you do succeed to get
> the fancy splash image, but the text below it is only partially
> visible, right?  IOW, one or two (maybe even 3) last lines are not
> visible?  This is exactly what the test was trying to avoid.  So if we
> go with your proposal, it is not clear why we should insist on some
> minimal frame height at all.
> 
> (Or maybe you don't have auto-save file lists in your home directory,
> in which case your startup screen shows 2 lines less than it does on
> my system, and you are not aware of the problem for that reason.)
> 
> I think the correct solution will be to increase the default frame
> size by 1 or maybe even 2 lines.  Because on my system, the last line
> is only partially visible, so the calculation in
> use-fancy-splash-screens-p is slightly inaccurate (because it is
> off-by-one -- we need to subtract 2 from the frame height, not 1).