From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Keith David Bershatsky Newsgroups: gmane.emacs.bugs Subject: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Tue, 22 Mar 2016 19:04:06 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (generated by - "") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1458698724 13756 80.91.229.3 (23 Mar 2016 02:05:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Mar 2016 02:05:24 +0000 (UTC) Cc: 23074@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 23 03:05:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aiYAa-0006vS-Kg for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Mar 2016 03:05:12 +0100 Original-Received: from localhost ([::1]:40494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiYAZ-0002h9-SD for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Mar 2016 22:05:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiYAV-0002ec-Tm for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 22:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiYAQ-0006yF-QP for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 22:05:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiYAQ-0006xw-Ln for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 22:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aiYAQ-0006Gb-DL for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 22:05:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Keith David Bershatsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Mar 2016 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23074-submit@debbugs.gnu.org id=B23074.145869865524033 (code B ref 23074); Wed, 23 Mar 2016 02:05:02 +0000 Original-Received: (at 23074) by debbugs.gnu.org; 23 Mar 2016 02:04:15 +0000 Original-Received: from localhost ([127.0.0.1]:60621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiY9e-0006FZ-QE for submit@debbugs.gnu.org; Tue, 22 Mar 2016 22:04:14 -0400 Original-Received: from cobb.liquidweb.com ([50.28.13.150]:56385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiY9d-0006FL-GC for 23074@debbugs.gnu.org; Tue, 22 Mar 2016 22:04:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com; s=default; h=Content-Type:MIME-Version:Subject:Cc:To:From:Message-ID:Date; bh=o+d4tCK/nCJi1DmYxpd7NkTKsJGgoGMYhqbnfMDJ+fo=; b=vV+Fm1gEusNhfHTINceRlVlM4dS/QlBtG9in2+wBEppK75jMweNDBIpI77ySVwvBGS0Mm8dHLEGD9dj0FsDGzFs418gOjDA72fABxLec1FlsWauu34DMH/gR94CtBKvi; Original-Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:50997 helo=server.local.localhost) by cobb.liquidweb.com with esmtp (Exim 4.82) (envelope-from ) id 1aiY9U-0001Fl-AU; Tue, 22 Mar 2016 22:04:04 -0400 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cobb.liquidweb.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-Get-Message-Sender-Via: cobb.liquidweb.com: acl_c_relayhosts_text_entry: lawlist|lawlist.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115377 Archived-At: With the modification that I made in startup.el -- building with the default gtk3 toolkit -- the fancy image takes up a substantial portion of the welcome screen such that the last partially visible line is: "Auto-save file lists were found. If an Emacs session crashed recently," I had assumed based on the comments in the function that I modified that the concern was a potential second window displaying an error message. If the error message is displayed in that second window, then suppress the image in the welcome screen. That is why I suggested the idea of a `one-window-p` test to determine whether an error window might be displayed. Your idea of having all text visible in the welcome screen makes good sense. I haven't familiarized myself with everything that goes into determining the initial default frame size or default size of subsequently created frames. So, I have no opinion regarding what the default should be. I also have no opinion regarding the text that makes up the contents of the welcome screen. My primary concern when building Emacs was that perhaps I did not have proper image support because the Emacs logo was not appearing. But, that concern has now been resolved by tracking it down to use-fancy-splash-screens-p. Keith ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; At Tue, 22 Mar 2016 18:07:18 +0200, Eli Zaretskii wrote: > > * * * > > Then, with the code you modified in startup.el, you do succeed to get > the fancy splash image, but the text below it is only partially > visible, right? IOW, one or two (maybe even 3) last lines are not > visible? This is exactly what the test was trying to avoid. So if we > go with your proposal, it is not clear why we should insist on some > minimal frame height at all. > > (Or maybe you don't have auto-save file lists in your home directory, > in which case your startup screen shows 2 lines less than it does on > my system, and you are not aware of the problem for that reason.) > > I think the correct solution will be to increase the default frame > size by 1 or maybe even 2 lines. Because on my system, the last line > is only partially visible, so the calculation in > use-fancy-splash-screens-p is slightly inaccurate (because it is > off-by-one -- we need to subtract 2 from the frame height, not 1).