From: Robert Pluim <rpluim@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>,
Juri Linkov <juri@linkov.net>
Subject: bug#36644: Git log search
Date: Wed, 24 Jul 2019 17:46:46 +0200 [thread overview]
Message-ID: <m2imrrmo49.fsf@gmail.com> (raw)
In-Reply-To: <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> (Dmitry Gutov's message of "Wed, 24 Jul 2019 18:10:35 +0300")
>>>>> On Wed, 24 Jul 2019 18:10:35 +0300, Dmitry Gutov <dgutov@yandex.ru> said:
Dmitry> On 19.07.2019 1:32, Juri Linkov wrote:
>>> We can't really use this approach. VC is a high level abstraction,
>>> so we try to define the semantics well.
>>
>> I tend to agree with Robert. A string have to be passed to the backend as is.
>> It seems such situations when these strings should be compatible between
>> different backends (such as running the same command on one backend,
>> and then repeating the same search on another backend by retrieving
>> a previous argument from the history via M-p) are very rare.
Dmitry> I might agree with you from the practical standpoint, but
Dmitry> vc-log-search needs a docstring that actually describes what the
Dmitry> function is going to do. Including info on how PATTERN is going to be
Dmitry> interpreted.
If it were implemented as 'backend show me all the logs and then emacs
will search through them' then that would be required, but itʼs not,
itʼs implemented as 'backend show me the logs which match STRING'
Dmitry> E.g. whether "foo.txt" will only match literally, or whether "." can
Dmitry> be substituted by any character.
That will depend on the backend
Dmitry> And if PATTERN is a regexp, what kind of regexp it's going to be
Dmitry> interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably
Dmitry> not the last one anyway).
As will this
Dmitry> I suppose we can choose one of these and say e.g. that pattern is
Dmitry> interpreted as an extended regular expression, except for some
Dmitry> backends that don't support that. I wonder how we're going to convey
Dmitry> the latter to the user.
Itʼs not a pattern. Itʼs a string that is passed as-is to the backend,
which is free to interpret it as it wishes. From my viewpoint, we can
just say
"Search for STRING, which is passed unsullied to the backend's log
search command. Consult the documentation for your backend to
understand the matching method it uses to search for STRING."
or similar.
Robert
next prev parent reply other threads:[~2019-07-24 15:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 22:27 bug#36644: Git log search Juri Linkov
2019-07-15 15:05 ` Dmitry Gutov
2019-07-15 22:27 ` Juri Linkov
2019-07-16 14:25 ` Dmitry Gutov
2019-07-16 14:44 ` Andreas Schwab
2019-07-16 15:08 ` Robert Pluim
2019-07-16 20:20 ` Juri Linkov
2019-07-16 22:31 ` Noam Postavsky
2019-07-18 22:35 ` Juri Linkov
2019-07-24 14:57 ` Dmitry Gutov
2019-07-16 20:15 ` Juri Linkov
2019-07-18 15:01 ` Dmitry Gutov
2019-07-18 15:12 ` Robert Pluim
2019-07-18 18:02 ` Dmitry Gutov
2019-07-18 18:11 ` Robert Pluim
2019-07-18 22:32 ` Juri Linkov
2019-07-24 15:10 ` Dmitry Gutov
2019-07-24 15:46 ` Robert Pluim [this message]
2019-07-24 15:53 ` Dmitry Gutov
2019-07-24 16:13 ` Eli Zaretskii
2019-07-25 12:36 ` Dmitry Gutov
2019-07-25 13:08 ` Eli Zaretskii
2019-07-25 13:20 ` Dmitry Gutov
2019-07-25 13:37 ` Robert Pluim
2019-07-25 19:00 ` Juri Linkov
2019-07-25 18:55 ` Juri Linkov
2019-07-25 21:26 ` Dmitry Gutov
2019-07-25 21:38 ` Juri Linkov
2019-07-24 16:13 ` Robert Pluim
2019-07-24 17:04 ` Eli Zaretskii
2019-07-24 23:22 ` Juri Linkov
2019-07-25 12:44 ` Dmitry Gutov
2019-07-25 18:50 ` Juri Linkov
2019-07-25 19:19 ` Dmitry Gutov
2019-07-29 22:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2imrrmo49.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=36644@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).