From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#36644: Git log search Date: Wed, 24 Jul 2019 17:46:46 +0200 Message-ID: References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177361"; mail-complaints-to="usenet@blaine.gmane.org" Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 24 17:47:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqJTx-000k0l-Kz for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 17:47:09 +0200 Original-Received: from localhost ([::1]:52680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqJTv-0005aO-Vl for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Jul 2019 11:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51267) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqJTs-0005a5-ON for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:47:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqJTq-0002bC-4q for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:47:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57308) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqJTp-0002aw-Mu for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqJTp-0000w3-JG for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2019 11:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2019 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs Original-Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.15639832173584 (code B ref 36644); Wed, 24 Jul 2019 15:47:01 +0000 Original-Received: (at 36644) by debbugs.gnu.org; 24 Jul 2019 15:46:57 +0000 Original-Received: from localhost ([127.0.0.1]:37896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJTl-0000vk-4c for submit@debbugs.gnu.org; Wed, 24 Jul 2019 11:46:57 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:44587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqJTi-0000vV-SD for 36644@debbugs.gnu.org; Wed, 24 Jul 2019 11:46:55 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id p17so47500961wrf.11 for <36644@debbugs.gnu.org>; Wed, 24 Jul 2019 08:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=8Jzg03w3yyOSsy8IHQRVTYqykKlkTOXCxRPGTne5THY=; b=CCG3wGONwHvZnMJA5EkhV9O9RWTVWRqzaYm5HersYxzofsBhaFIwI+0UwQhDy0OXjD KQ77//3bdOM7UjRkEwcx6/lcF7ZrSRF9fme11IUflDfxytS5oxXFDbw6CFCobcSWMNOJ 0nHup1Jik3I+DZ1/+KTfHD5GV8t7733qXwK/hwetrz7OhzuA8UQD81ycCy8p456jzeXE WSkAed19k477E0ncCZ8oKNWKcMkG3HK00tXn5m9oW1T+R245z0V3O1hww3YbFfcR9VWi 6UCHFzu/yuBbuKDwnOsUd2SbzaI9peUBWSwqfphzQtHFJabb/zXBSo6V0mD7COyNY0S0 JIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=8Jzg03w3yyOSsy8IHQRVTYqykKlkTOXCxRPGTne5THY=; b=NwzoMB50CgIjHi0p9nuEpDyRZ8TVTh7mb+VYcvItZBcGUxrUMvFMU7rHqsecd03V8o 8auEHxZbNx3foMGpCydKieCl7m39MemoIzzJcmZgfP1OXRzPryk10s8Z7bPkyHNYo9n0 mh1J1S5TtkmLvEhI2QNHRjUiebUKzK5VAN47xCFoTAVZA8ZxrlosMzAlsvg+ZMFmk5gg fpQU60dYWr349KhPGCmxSU/l/pbPG+Va418mEwTZZiICbapkcox8hLBGlU7hyb1mr7M5 a3PWkmM2+yqNvgE4eXvFGA7/+/Lr+C+PmXsMm3WhWIiOBY3OZeIZEBBNzWPeQJzx5xgg ztcQ== X-Gm-Message-State: APjAAAVkqguyJh+2v8edC1xvG0R2QCKV0UTWq8UYf47PjRarPgD9XoOD QTsScj2JI7UTBhCBTMKGV8TLajoK X-Google-Smtp-Source: APXvYqyTgoYtGRiOB3GHQkaTmACGiIqqSDdUiy1/gnNToqhYo00IdbHo1GMAoEBzqJXtMULmc4sNhA== X-Received: by 2002:adf:f3cc:: with SMTP id g12mr51567406wrp.149.1563983208375; Wed, 24 Jul 2019 08:46:48 -0700 (PDT) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id v15sm45607763wrt.25.2019.07.24.08.46.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Jul 2019 08:46:46 -0700 (PDT) In-Reply-To: <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> (Dmitry Gutov's message of "Wed, 24 Jul 2019 18:10:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163669 Archived-At: >>>>> On Wed, 24 Jul 2019 18:10:35 +0300, Dmitry Gutov s= aid: Dmitry> On 19.07.2019 1:32, Juri Linkov wrote: >>> We can't really use this approach. VC is a high level abstraction, >>> so we try to define the semantics well. >>=20 >> I tend to agree with Robert. A string have to be passed to the back= end as is. >> It seems such situations when these strings should be compatible bet= ween >> different backends (such as running the same command on one backend, >> and then repeating the same search on another backend by retrieving >> a previous argument from the history via M-p) are very rare. Dmitry> I might agree with you from the practical standpoint, but Dmitry> vc-log-search needs a docstring that actually describes what the Dmitry> function is going to do. Including info on how PATTERN is going= to be Dmitry> interpreted. If it were implemented as 'backend show me all the logs and then emacs will search through them' then that would be required, but it=CA=BCs not, it=CA=BCs implemented as 'backend show me the logs which match STRING' Dmitry> E.g. whether "foo.txt" will only match literally, or whether ".= " can Dmitry> be substituted by any character. That will depend on the backend Dmitry> And if PATTERN is a regexp, what kind of regexp it's going to be Dmitry> interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (p= robably Dmitry> not the last one anyway). As will this Dmitry> I suppose we can choose one of these and say e.g. that pattern = is Dmitry> interpreted as an extended regular expression, except for some Dmitry> backends that don't support that. I wonder how we're going to c= onvey Dmitry> the latter to the user. It=CA=BCs not a pattern. It=CA=BCs a string that is passed as-is to the bac= kend, which is free to interpret it as it wishes. From my viewpoint, we can just say "Search for STRING, which is passed unsullied to the backend's log search command. Consult the documentation for your backend to understand the matching method it uses to search for STRING." or similar. Robert