bug#17743: 24.3; auth-source.el option "auth-source-do-cache" ignored

bug#17743: 24.3; auth-source.el option "auth-source-do-cache" ignored

[Justin Dove]

The documentation gives the impression that setting auth-source-do-cache
to nil should prevent auth-source from caching credentials. I have
experimentally tested this and found it to be false. As far as I can
tell, auth-source-do-cache is only checked in the function
auth-source-search. It seems to me that it should also be checked in
auth-source-remember and perhaps other associated functions.

Justin

In GNU Emacs 24.3.1 (x86_64-apple-darwin, NS apple-appkit-1038.36)
 of 2013-03-10 on bob.porkrind.org
Windowing system distributor `Apple', version 10.3.1187
Configured using:
 `configure '--host=x86_64-apple-darwin' '--build=i686-apple-darwin'
 '--with-ns' 'build_alias=i686-apple-darwin'
 'host_alias=x86_64-apple-darwin' 'CC=gcc -mmacosx-version-min=10.5 ''

bug#17743: 24.3; auth-source.el option "auth-source-do-cache" ignored

[Lars Ingebrigtsen]

Justin Dove <dove@MIT.EDU> writes:

> The documentation gives the impression that setting auth-source-do-cache
> to nil should prevent auth-source from caching credentials. I have
> experimentally tested this and found it to be false. As far as I can
> tell, auth-source-do-cache is only checked in the function
> auth-source-search. It seems to me that it should also be checked in
> auth-source-remember and perhaps other associated functions.

Reading the code, auth-source does this on master now, at least:

      ;; note we remember the lack of result too, if it's applicable
      (when auth-source-do-cache
        (auth-source-remember spec found)))

And that's the only call to auth-source-remember, so I guess this has
been fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no