bug#29643: 27.0.50; Deprecation warnings on macOS High Sierra

bug#29643: 27.0.50; Deprecation warnings on macOS High Sierra

[Philipp]

When building Emacs on macOS High Sierra, I get the following
deprecation warnings:

nsterm.m:6019:18: warning: 'setOnMouseEntered:' is deprecated: first deprecated in macOS 10.13 - setOnMouseEntered is unused and should not be called
      [-Wdeprecated-declarations]
  [currentCursor setOnMouseEntered: YES];
                 ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSCursor.h:77:1: note: 
      'setOnMouseEntered:' has been explicitly marked deprecated here
- (void)setOnMouseEntered:(BOOL)flag NS_DEPRECATED_MAC(10_0, 10_13, "setOnMouseEntered is unused and should not be called");
^
nsterm.m:8749:27: warning: 'setOnMouseEntered:' is deprecated: first deprecated in macOS 10.13 - setOnMouseEntered is unused and should not be called
      [-Wdeprecated-declarations]
  [[NSCursor arrowCursor] setOnMouseEntered: YES];
                          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSCursor.h:77:1: note: 
      'setOnMouseEntered:' has been explicitly marked deprecated here
- (void)setOnMouseEntered:(BOOL)flag NS_DEPRECATED_MAC(10_0, 10_13, "setOnMouseEntered is unused and should not be called");
^
2 warnings generated.
  CC       nsfns.o
nsfns.m:1899:10: warning: 'NSBackingStoreRetained' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
    case NSBackingStoreRetained:
         ^~~~~~~~~~~~~~~~~~~~~~
         NSBackingStoreBuffered
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:96:5: note: 
      'NSBackingStoreRetained' has been explicitly marked deprecated here
    NSBackingStoreRetained NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSBackingStoreBuffered", 10.0, 10.13) = 0,
    ^
nsfns.m:1901:10: warning: 'NSBackingStoreNonretained' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
    case NSBackingStoreNonretained:
         ^~~~~~~~~~~~~~~~~~~~~~~~~
         NSBackingStoreBuffered
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:97:5: note: 
      'NSBackingStoreNonretained' has been explicitly marked deprecated here
    NSBackingStoreNonretained NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSBackingStoreBuffered", 10.0, 10.13) = 1,
    ^
nsfns.m:1956:10: warning: 'NSBackingStoreRetained' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
    case NSBackingStoreRetained:
         ^~~~~~~~~~~~~~~~~~~~~~
         NSBackingStoreBuffered
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:96:5: note: 
      'NSBackingStoreRetained' has been explicitly marked deprecated here
    NSBackingStoreRetained NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSBackingStoreBuffered", 10.0, 10.13) = 0,
    ^
nsfns.m:1957:10: warning: 'NSBackingStoreNonretained' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
    case NSBackingStoreNonretained:
         ^~~~~~~~~~~~~~~~~~~~~~~~~
         NSBackingStoreBuffered
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSGraphics.h:97:5: note: 
      'NSBackingStoreNonretained' has been explicitly marked deprecated here
    NSBackingStoreNonretained NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSBackingStoreBuffered", 10.0, 10.13) = 1,
    ^
4 warnings generated.
  CC       nsmenu.o
  CC       nsselect.o
nsselect.m:57:38: warning: 'NSGeneralPboard' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
  if (EQ (sym, QCLIPBOARD))   return NSGeneralPboard;
                                     ^~~~~~~~~~~~~~~
                                     NSPasteboardNameGeneral
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:343:32: note: 
      'NSGeneralPboard' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardName NSGeneralPboard NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSPasteboardNameGeneral", 10.0, 10.13);
                               ^
nsselect.m:73:27: warning: 'NSGeneralPboard' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
  if ([t isEqualToString: NSGeneralPboard])
                          ^~~~~~~~~~~~~~~
                          NSPasteboardNameGeneral
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:343:32: note: 
      'NSGeneralPboard' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardName NSGeneralPboard NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSPasteboardNameGeneral", 10.0, 10.13);
                               ^
nsselect.m:472:36: warning: 'NSGeneralPboard' is deprecated: first deprecated in macOS 10.13 [-Wdeprecated-declarations]
             [NSNumber numberWithLong:0], NSGeneralPboard,
                                          ^~~~~~~~~~~~~~~
                                          NSPasteboardNameGeneral
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:343:32: note: 
      'NSGeneralPboard' has been explicitly marked deprecated here
APPKIT_EXTERN NSPasteboardName NSGeneralPboard NS_DEPRECATED_WITH_REPLACEMENT_MAC("NSPasteboardNameGeneral", 10.0, 10.13);



In GNU Emacs 27.0.50 (build 20, x86_64-apple-darwin17.2.0, NS appkit-1561.10 Version 10.13.1 (Build 17B1003))
 of 2017-12-10 built on p
Repository revision: ab203e36d5f84a99b6d4b04f1a22ba028be750e3
Windowing system distributor 'Apple', version 10.3.1561
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-checking --enable-check-lisp-object-type
 --enable-gtk-deprecation-warnings --with-modules --without-xml2
 --without-pop --with-mailutils --enable-gcc-warnings=warn-only
 MAKEINFO=/usr/local/opt/texinfo/bin/makeinfo 'CFLAGS=-O0 -ggdb3'
 LDFLAGS=-O0'

Configured features:
NOTIFY ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS MODULES JSON

Important settings:
  value of $LANG: de_DE.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core term/tty-colors frame cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote kqueue cocoa ns
multi-tty make-network-process emacs)

Memory information:
((conses 16 204682 7183)
 (symbols 48 20164 1)
 (miscs 40 57 176)
 (strings 32 28803 1608)
 (string-bytes 1 764939)
 (vectors 16 35163)
 (vector-slots 8 719992 9580)
 (floats 8 52 64)
 (intervals 56 214 0)
 (buffers 992 11))

bug#29643: [PATCH] Silence macOS 10.13 deprecation notices (Bug#29643)

[Alan Third]

* src/nsfns.m (Fx_display_backing_store):
(Fx_display_save_under): Don't use NSBackingStoreRetained or
NSBackingStoreNonretained on macOS 10.13+.
* src/nsselect.m (symbol_to_nsstring):
(ns_string_to_symbol):
(nxatoms_of_nsselect): Replace NSGeneralPboard with
NSPasteboardNameGeneral.
* src/nsterm.h: #define NSPasteboardNameGeneral to NSGeneralPboard on
GNUstep and macOS < 10.13.
* src/nsterm.m (EmacsView::resetCursorRects):
(EmacsScroller::resetCursorRects): Don't use setOnMouseEntered on
macOS 10.13+.
---
 src/nsfns.m    |  4 ++++
 src/nsselect.m |  8 ++++----
 src/nsterm.h   |  5 +++++
 src/nsterm.m   | 17 +++++++++++++++--
 4 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/src/nsfns.m b/src/nsfns.m
index 8172268167..064b476fb4 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -1896,10 +1896,12 @@ and GNUstep implementations ("distributor-specific release
     {
     case NSBackingStoreBuffered:
       return intern ("buffered");
+#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
     case NSBackingStoreRetained:
       return intern ("retained");
     case NSBackingStoreNonretained:
       return intern ("non-retained");
+#endif
     default:
       error ("Strange value for backingType parameter of frame");
     }
@@ -1953,9 +1955,11 @@ and GNUstep implementations ("distributor-specific release
     case NSBackingStoreBuffered:
       return Qt;
 
+#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
     case NSBackingStoreRetained:
     case NSBackingStoreNonretained:
       return Qnil;
+#endif
 
     default:
       error ("Strange value for backingType parameter of frame");
diff --git a/src/nsselect.m b/src/nsselect.m
index 067c7788e8..d1ce9437a7 100644
--- a/src/nsselect.m
+++ b/src/nsselect.m
@@ -36,7 +36,7 @@ Updated by Christian Limpach (chris@nice.ch)
 
 static Lisp_Object Vselection_alist;
 
-/* NSGeneralPboard is pretty much analogous to X11 CLIPBOARD */
+/* NSPasteboardNameGeneral is pretty much analogous to X11 CLIPBOARD */
 static NSString *NXPrimaryPboard;
 static NSString *NXSecondaryPboard;
 
@@ -54,7 +54,7 @@ Updated by Christian Limpach (chris@nice.ch)
 symbol_to_nsstring (Lisp_Object sym)
 {
   CHECK_SYMBOL (sym);
-  if (EQ (sym, QCLIPBOARD))   return NSGeneralPboard;
+  if (EQ (sym, QCLIPBOARD))   return NSPasteboardNameGeneral;
   if (EQ (sym, QPRIMARY))     return NXPrimaryPboard;
   if (EQ (sym, QSECONDARY))   return NXSecondaryPboard;
   if (EQ (sym, QTEXT))        return NSStringPboardType;
@@ -70,7 +70,7 @@ Updated by Christian Limpach (chris@nice.ch)
 static Lisp_Object
 ns_string_to_symbol (NSString *t)
 {
-  if ([t isEqualToString: NSGeneralPboard])
+  if ([t isEqualToString: NSPasteboardNameGeneral])
     return QCLIPBOARD;
   if ([t isEqualToString: NXPrimaryPboard])
     return QPRIMARY;
@@ -469,7 +469,7 @@ Updated by Christian Limpach (chris@nice.ch)
   pasteboard_changecount
     = [[NSMutableDictionary
 	 dictionaryWithObjectsAndKeys:
-	     [NSNumber numberWithLong:0], NSGeneralPboard,
+	     [NSNumber numberWithLong:0], NSPasteboardNameGeneral,
 	     [NSNumber numberWithLong:0], NXPrimaryPboard,
 	     [NSNumber numberWithLong:0], NXSecondaryPboard,
 	     [NSNumber numberWithLong:0], NSStringPboardType,
diff --git a/src/nsterm.h b/src/nsterm.h
index c81bf5fb63..e669c95931 100644
--- a/src/nsterm.h
+++ b/src/nsterm.h
@@ -1322,5 +1322,10 @@ enum NSWindowTabbingMode
     NSWindowTabbingModePreferred,
     NSWindowTabbingModeDisallowed
   };
+#endif /* !defined (NS_IMPL_COCOA) || !defined (MAC_OS_X_VERSION_10_12)  */
+
+#if !defined (NS_IMPL_COCOA) || !defined (MAC_OS_X_VERSION_10_13)
+/* Deprecated in macOS 10.13.  */
+#define NSPasteboardNameGeneral NSGeneralPboard
 #endif
 #endif	/* HAVE_NS */
diff --git a/src/nsterm.m b/src/nsterm.m
index 50e06c94d4..07ac8f978f 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -6016,7 +6016,13 @@ - (void)resetCursorRects
 
   if (!NSIsEmptyRect (visible))
     [self addCursorRect: visible cursor: currentCursor];
-  [currentCursor setOnMouseEntered: YES];
+
+#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
+#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101300
+  if ([currentCursor respondsToSelector: @selector(setOnMouseEntered)])
+#endif
+    [currentCursor setOnMouseEntered: YES];
+#endif
 }
 
 
@@ -8746,7 +8752,14 @@ - (void)resetCursorRects
 
   if (!NSIsEmptyRect (visible))
     [self addCursorRect: visible cursor: [NSCursor arrowCursor]];
-  [[NSCursor arrowCursor] setOnMouseEntered: YES];
+
+#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
+#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101300
+  if ([[NSCursor arrowCursor] respondsToSelector:
+                                @selector(setOnMouseEntered)])
+#endif
+    [[NSCursor arrowCursor] setOnMouseEntered: YES];
+#endif
 }
 
 
-- 

Hi Philipp, can you please check whether this patch silences the
deprecation notices?

I’m still on 10.12, so I can’t check myself.

-- 
Alan Third

bug#29643: [PATCH] Silence macOS 10.13 deprecation notices (Bug#29643)

[Philipp Stephani]

[-- Attachment #1: Type: text/plain, Size: 5554 bytes --]

Thanks, the patch works fine.

Alan Third <alan@idiocy.org> schrieb am So., 10. Dez. 2017 um 21:27 Uhr:

> * src/nsfns.m (Fx_display_backing_store):
> (Fx_display_save_under): Don't use NSBackingStoreRetained or
> NSBackingStoreNonretained on macOS 10.13+.
> * src/nsselect.m (symbol_to_nsstring):
> (ns_string_to_symbol):
> (nxatoms_of_nsselect): Replace NSGeneralPboard with
> NSPasteboardNameGeneral.
> * src/nsterm.h: #define NSPasteboardNameGeneral to NSGeneralPboard on
> GNUstep and macOS < 10.13.
> * src/nsterm.m (EmacsView::resetCursorRects):
> (EmacsScroller::resetCursorRects): Don't use setOnMouseEntered on
> macOS 10.13+.
> ---
>  src/nsfns.m    |  4 ++++
>  src/nsselect.m |  8 ++++----
>  src/nsterm.h   |  5 +++++
>  src/nsterm.m   | 17 +++++++++++++++--
>  4 files changed, 28 insertions(+), 6 deletions(-)
>
> diff --git a/src/nsfns.m b/src/nsfns.m
> index 8172268167..064b476fb4 100644
> --- a/src/nsfns.m
> +++ b/src/nsfns.m
> @@ -1896,10 +1896,12 @@ and GNUstep implementations ("distributor-specific
> release
>      {
>      case NSBackingStoreBuffered:
>        return intern ("buffered");
> +#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
>      case NSBackingStoreRetained:
>        return intern ("retained");
>      case NSBackingStoreNonretained:
>        return intern ("non-retained");
> +#endif
>      default:
>        error ("Strange value for backingType parameter of frame");
>      }
> @@ -1953,9 +1955,11 @@ and GNUstep implementations ("distributor-specific
> release
>      case NSBackingStoreBuffered:
>        return Qt;
>
> +#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
>      case NSBackingStoreRetained:
>      case NSBackingStoreNonretained:
>        return Qnil;
> +#endif
>
>      default:
>        error ("Strange value for backingType parameter of frame");
> diff --git a/src/nsselect.m b/src/nsselect.m
> index 067c7788e8..d1ce9437a7 100644
> --- a/src/nsselect.m
> +++ b/src/nsselect.m
> @@ -36,7 +36,7 @@ Updated by Christian Limpach (chris@nice.ch)
>
>  static Lisp_Object Vselection_alist;
>
> -/* NSGeneralPboard is pretty much analogous to X11 CLIPBOARD */
> +/* NSPasteboardNameGeneral is pretty much analogous to X11 CLIPBOARD */
>  static NSString *NXPrimaryPboard;
>  static NSString *NXSecondaryPboard;
>
> @@ -54,7 +54,7 @@ Updated by Christian Limpach (chris@nice.ch)
>  symbol_to_nsstring (Lisp_Object sym)
>  {
>    CHECK_SYMBOL (sym);
> -  if (EQ (sym, QCLIPBOARD))   return NSGeneralPboard;
> +  if (EQ (sym, QCLIPBOARD))   return NSPasteboardNameGeneral;
>    if (EQ (sym, QPRIMARY))     return NXPrimaryPboard;
>    if (EQ (sym, QSECONDARY))   return NXSecondaryPboard;
>    if (EQ (sym, QTEXT))        return NSStringPboardType;
> @@ -70,7 +70,7 @@ Updated by Christian Limpach (chris@nice.ch)
>  static Lisp_Object
>  ns_string_to_symbol (NSString *t)
>  {
> -  if ([t isEqualToString: NSGeneralPboard])
> +  if ([t isEqualToString: NSPasteboardNameGeneral])
>      return QCLIPBOARD;
>    if ([t isEqualToString: NXPrimaryPboard])
>      return QPRIMARY;
> @@ -469,7 +469,7 @@ Updated by Christian Limpach (chris@nice.ch)
>    pasteboard_changecount
>      = [[NSMutableDictionary
>          dictionaryWithObjectsAndKeys:
> -            [NSNumber numberWithLong:0], NSGeneralPboard,
> +            [NSNumber numberWithLong:0], NSPasteboardNameGeneral,
>              [NSNumber numberWithLong:0], NXPrimaryPboard,
>              [NSNumber numberWithLong:0], NXSecondaryPboard,
>              [NSNumber numberWithLong:0], NSStringPboardType,
> diff --git a/src/nsterm.h b/src/nsterm.h
> index c81bf5fb63..e669c95931 100644
> --- a/src/nsterm.h
> +++ b/src/nsterm.h
> @@ -1322,5 +1322,10 @@ enum NSWindowTabbingMode
>      NSWindowTabbingModePreferred,
>      NSWindowTabbingModeDisallowed
>    };
> +#endif /* !defined (NS_IMPL_COCOA) || !defined (MAC_OS_X_VERSION_10_12)
> */
> +
> +#if !defined (NS_IMPL_COCOA) || !defined (MAC_OS_X_VERSION_10_13)
> +/* Deprecated in macOS 10.13.  */
> +#define NSPasteboardNameGeneral NSGeneralPboard
>  #endif
>  #endif /* HAVE_NS */
> diff --git a/src/nsterm.m b/src/nsterm.m
> index 50e06c94d4..07ac8f978f 100644
> --- a/src/nsterm.m
> +++ b/src/nsterm.m
> @@ -6016,7 +6016,13 @@ - (void)resetCursorRects
>
>    if (!NSIsEmptyRect (visible))
>      [self addCursorRect: visible cursor: currentCursor];
> -  [currentCursor setOnMouseEntered: YES];
> +
> +#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
> +#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101300
> +  if ([currentCursor respondsToSelector: @selector(setOnMouseEntered)])
> +#endif
> +    [currentCursor setOnMouseEntered: YES];
> +#endif
>  }
>
>
> @@ -8746,7 +8752,14 @@ - (void)resetCursorRects
>
>    if (!NSIsEmptyRect (visible))
>      [self addCursorRect: visible cursor: [NSCursor arrowCursor]];
> -  [[NSCursor arrowCursor] setOnMouseEntered: YES];
> +
> +#if defined (NS_IMPL_GNUSTEP) || MAC_OS_X_VERSION_MIN_REQUIRED < 101300
> +#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101300
> +  if ([[NSCursor arrowCursor] respondsToSelector:
> +                                @selector(setOnMouseEntered)])
> +#endif
> +    [[NSCursor arrowCursor] setOnMouseEntered: YES];
> +#endif
>  }
>
>
> --
>
> Hi Philipp, can you please check whether this patch silences the
> deprecation notices?
>
> I’m still on 10.12, so I can’t check myself.
>
> --
> Alan Third
>

[-- Attachment #2: Type: text/html, Size: 6583 bytes --]

bug#29643: [PATCH] Silence macOS 10.13 deprecation notices (Bug#29643)

[Alan Third]

On Sat, Dec 16, 2017 at 06:13:19PM +0000, Philipp Stephani wrote:
> Thanks, the patch works fine.

Thanks! Pushed to master.
-- 
Alan Third