unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, stepnem@gmail.com, 40118@debbugs.gnu.org
Subject: bug#40118: 27.0.90; Signing emails with gpg
Date: Tue, 05 May 2020 17:23:44 +0200	[thread overview]
Message-ID: <m25zdah0cf.fsf@gmail.com> (raw)
In-Reply-To: <837dxqmneo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 May 2020 18:06:39 +0300")

>>>>> On Tue, 05 May 2020 18:06:39 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> We can do that as well, and put the querying code in master. Eli?

    Eli> Can you show me the changes for emacs-27, please?

    Eli> Thanks.

* lisp/gnus/mml-sec.el (mml-secure-epg-sign): Partially revert
"Make mml-secure-epg-sign bug out if we can't find an identity".
It causes signing to fail for people who have not set up
mml-secure-{smime,openpgp}-sign-with-sender, which is a regression
from Emacs-26 (Bug#40118).

Do not merge to master.
        
diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el
index 740e1d2b72..8d77916e99 100644
--- a/lisp/gnus/mml-sec.el
+++ b/lisp/gnus/mml-sec.el
@@ -944,16 +944,6 @@ mml-secure-epg-sign
 	 (signer-names (mml-secure-signer-names protocol sender))
 	 (signers (mml-secure-signers context signer-names))
 	 signature micalg)
-    (unless signers
-      (let ((maybe-msg
-             (if mml-secure-smime-sign-with-sender
-                 "."
-               "; try setting `mml-secure-smime-sign-with-sender'.")))
-        ;; If `mml-secure-smime-sign-with-sender' is already non-nil
-        ;; then there's no point advising the user to examine it.  If
-        ;; there are any other variables worth examining, please
-        ;; improve this error message by having it mention them.
-        (error "Couldn't find any signer names%s" maybe-msg)))
     (when (eq 'OpenPGP protocol)
       (setf (epg-context-armor context) t)
       (setf (epg-context-textmode context) t)





  reply	other threads:[~2020-05-05 15:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 14:51 bug#40118: 27.0.90; Signing emails with gpg Sharon Kimble
2020-04-14 11:10 ` Štěpán Němec
2020-04-15 16:37   ` Robert Pluim
2020-04-15 16:45     ` Eli Zaretskii
2020-04-16  9:44       ` Robert Pluim
2020-04-16 10:15         ` Eli Zaretskii
2020-04-16 10:38           ` Robert Pluim
2020-04-17 15:11             ` Robert Pluim
2020-04-20 10:52               ` Robert Pluim
2020-04-20 16:24                 ` Eli Zaretskii
2020-04-20 16:58                   ` Robert Pluim
2020-04-30  4:33             ` Lars Ingebrigtsen
2020-04-30  7:37               ` Robert Pluim
2020-04-30 22:03                 ` Lars Ingebrigtsen
2020-05-05 12:46                   ` Robert Pluim
2020-05-05 15:06                     ` Eli Zaretskii
2020-05-05 15:23                       ` Robert Pluim [this message]
2020-05-05 16:07                         ` Eli Zaretskii
2020-09-30 14:57                         ` Lars Ingebrigtsen
2020-09-30 16:44                           ` Robert Pluim
2020-10-01  0:16                             ` Lars Ingebrigtsen
2020-10-01 17:41                               ` Robert Pluim
2020-10-01 17:43                                 ` Lars Ingebrigtsen
2020-10-02  8:49                                   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m25zdah0cf.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=40118@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).