From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#40118: 27.0.90; Signing emails with gpg Date: Tue, 05 May 2020 17:23:44 +0200 Message-ID: References: <87tv2lhg2p.fsf@skimble.plus.com> <87d08a9vb9.fsf@gmail.com> <83mu7cg0k8.fsf@gnu.org> <83pnc7enyx.fsf@gnu.org> <87r1w5384c.fsf@gnus.org> <87sggkzl60.fsf@gnus.org> <837dxqmneo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83935"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, stepnem@gmail.com, 40118@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 05 17:24:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVzQa-000LYt-Ik for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 17:24:12 +0200 Original-Received: from localhost ([::1]:32888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVzQZ-0006ZP-KN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 11:24:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVzQQ-0006Xo-Sz for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 11:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVzQQ-0002kY-5w for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVzQQ-0001Yc-18 for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 11:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 May 2020 15:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40118 X-GNU-PR-Package: emacs Original-Received: via spool by 40118-submit@debbugs.gnu.org id=B40118.15886922355971 (code B ref 40118); Tue, 05 May 2020 15:24:01 +0000 Original-Received: (at 40118) by debbugs.gnu.org; 5 May 2020 15:23:55 +0000 Original-Received: from localhost ([127.0.0.1]:37099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVzQI-0001YF-PQ for submit@debbugs.gnu.org; Tue, 05 May 2020 11:23:54 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:53443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVzQH-0001Y3-69 for 40118@debbugs.gnu.org; Tue, 05 May 2020 11:23:53 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id k12so2748635wmj.3 for <40118@debbugs.gnu.org>; Tue, 05 May 2020 08:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=5apAum7BKR2UKN+ey0bD7Stp7gIwE+0uQEjDhub/DSc=; b=L9pyIo1fz9g6bxuWKrNE0VQsuUxrjlJaNG8DR/QGA9uXRTZv51KnFedvLmjiszKtQu zhR/ZtjqyI+dSqSsLdc1Skh3rPNyBHhA7/gBAwCRo6SonvqSugmTldPHb9/IMqNSl2uv hMeDNxja6rIUHoCv5m4Rq6U9/Jdqj5zrHWG2LoCzKjDjTZ9GjMXFh3uE7fLVIZo7G7oJ RgUOb8/379h9E78U5lFatoKtoW8orrB6jqHAp79zuYcQgOEmoeovJZdjH+9FDdUJXqd8 uJNPl415SGzuw1m+pf7BWN4OFY7HSIrmNQHVGpzwHR5cqeJwWcD5GupkygGqwW+vNTFo BZJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=5apAum7BKR2UKN+ey0bD7Stp7gIwE+0uQEjDhub/DSc=; b=DBheH9mJH82JQNFuO4ShVmdskmR4bHlqyI5RmnyPXnmsd/+iDBhzf/O1dcGQC8WKYI kZuzif0wrSpeb5JjVgExQlo+Bbbx26Qe9+uoL6bGWworoYRP889Gtb7n1WKL+Nyf57z3 563xH67eN5WVRfrem9eiQgf74KkkqOrytzExLoaI8oKaPzqcUvh4p+RBCGMCibzU62GT yRc8EJvEYbWG+Xl5Bm/Fdb0iERrfz/oAqIB5JIcoThSqW6ieMLZtD92EjAGQfvVMfF1X 7WDgtJ2S+NFaC/V9yw4WZb1CUjr5o3HPYGTwYswKwhQX53h/hff6yCAqc0dN0MH5+gAj yOWA== X-Gm-Message-State: AGi0PuYLx9NTfbfLQvnEM/lvI6BTMiQJnhIxrs6o6VzEsU3oLMGuqc0j lRE4xokYN9BEKysUlYYyi6OzQKX3/98= X-Google-Smtp-Source: APiQypJFib/rTxEdeN6rPqdFC7gVC7+D4m/4SGnWiewV4+ApqoOfp5sfcs7alE9qpvyIiL3z2o/lvQ== X-Received: by 2002:a1c:4b16:: with SMTP id y22mr3882861wma.170.1588692226914; Tue, 05 May 2020 08:23:46 -0700 (PDT) Original-Received: from rpluim-mac ([2a01:e34:ecfc:a860:f4ba:2133:643e:235e]) by smtp.gmail.com with ESMTPSA id s12sm3956890wmc.7.2020.05.05.08.23.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 08:23:46 -0700 (PDT) In-Reply-To: <837dxqmneo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 05 May 2020 18:06:39 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179737 Archived-At: >>>>> On Tue, 05 May 2020 18:06:39 +0300, Eli Zaretskii said: >> We can do that as well, and put the querying code in master. Eli? Eli> Can you show me the changes for emacs-27, please? Eli> Thanks. * lisp/gnus/mml-sec.el (mml-secure-epg-sign): Partially revert "Make mml-secure-epg-sign bug out if we can't find an identity". It causes signing to fail for people who have not set up mml-secure-{smime,openpgp}-sign-with-sender, which is a regression from Emacs-26 (Bug#40118). Do not merge to master. diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index 740e1d2b72..8d77916e99 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -944,16 +944,6 @@ mml-secure-epg-sign (signer-names (mml-secure-signer-names protocol sender)) (signers (mml-secure-signers context signer-names)) signature micalg) - (unless signers - (let ((maybe-msg - (if mml-secure-smime-sign-with-sender - "." - "; try setting `mml-secure-smime-sign-with-sender'."))) - ;; If `mml-secure-smime-sign-with-sender' is already non-nil - ;; then there's no point advising the user to examine it. If - ;; there are any other variables worth examining, please - ;; improve this error message by having it mention them. - (error "Couldn't find any signer names%s" maybe-msg))) (when (eq 'OpenPGP protocol) (setf (epg-context-armor context) t) (setf (epg-context-textmode context) t)