unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Filipp Gunbin <fgunbin@fastmail.fm>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 18109@debbugs.gnu.org
Subject: bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven
Date: Mon, 07 Dec 2020 13:41:09 +0300	[thread overview]
Message-ID: <m25z5dj3ui.fsf@fastmail.fm> (raw)
In-Reply-To: <A538FA23-A0A9-4239-B66D-B11C345A9848@acm.org> ("Mattias Engdegård"'s message of "Sun, 6 Dec 2020 16:05:20 +0100")

On 06/12/2020 16:05 +0100, Mattias Engdegård wrote:

> Thus it looks like we can expect exactly one space each after the first and second colon and after the comma, instead of zero-or-more spaces (the '??' comments above). As a Gradle user, can you confirm this?
>
> The way the pattern is written makes it prone to matching other messages entirely or partly, with potential negative consequences for correctness, performance or both.

It was me who put there those quantifiers, and I don't object to making
the regexps stricter.

But, we just need to be aware that Java tools usually don't expect the
output to be parsed.  Like, an IDE uses Gradle's API to run it, and
Gradle uses compiler API to compile - this way none of them have to
parse anything.  So they output something that can be parsed, yes, but
the format could change at any time.  That is why I'm more inclined to
making regexps more _lax_, not the other way around (and fix the
problems with them once they appear).

Filipp





  parent reply	other threads:[~2020-12-07 10:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 17:33 bug#18109: 24.4.50; `compilation-error-regexp-alist-alist': wrong regexp for Maven Filipp Gunbin
2014-07-26  7:22 ` Glenn Morris
2014-07-28 12:30   ` Filipp Gunbin
2014-08-03 15:12     ` Daniel Colascione
2020-09-09 11:16     ` Lars Ingebrigtsen
2020-12-03 14:59       ` Lars Ingebrigtsen
2020-12-04 18:11         ` Filipp Gunbin
2020-12-04 19:22 ` Mattias Engdegård
2020-12-05 22:21   ` Filipp Gunbin
2020-12-06  9:32     ` Mattias Engdegård
2020-12-06 14:22       ` Filipp Gunbin
2020-12-06 15:05         ` Mattias Engdegård
2020-12-06 15:25           ` Mattias Engdegård
2020-12-07 10:41           ` Filipp Gunbin [this message]
2020-12-07 13:49             ` Mattias Engdegård
2020-12-07 20:07               ` Filipp Gunbin
2020-12-09 18:41                 ` Mattias Engdegård
2020-12-10 13:12                   ` Filipp Gunbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m25z5dj3ui.fsf@fastmail.fm \
    --to=fgunbin@fastmail.fm \
    --cc=18109@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).