* bug#20873: 24.5; shell command completion faulty
@ 2015-06-22 13:24 Leo Liu
2015-06-22 22:13 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Leo Liu @ 2015-06-22 13:24 UTC (permalink / raw)
To: 20873
1. M-x shell
2. Put a few spaces before entering `c' followed by TAB
No completion.
I wonder if the following is the right fix?
diff --git a/lisp/shell.el b/lisp/shell.el
index 6d69ca63..788b8169 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -1134,7 +1134,9 @@ (defun shell-command-completion ()
(if (and filename
(save-match-data (not (string-match "[~/]" filename)))
(eq (match-beginning 0)
- (save-excursion (shell-backward-command 1) (point))))
+ (save-excursion (shell-backward-command 1)
+ (skip-syntax-forward " ")
+ (point))))
(shell--command-completion-data))))
(defun shell--command-completion-data ()
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#20873: 24.5; shell command completion faulty
2015-06-22 13:24 bug#20873: 24.5; shell command completion faulty Leo Liu
@ 2015-06-22 22:13 ` Stefan Monnier
2015-06-23 1:26 ` Leo Liu
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-06-22 22:13 UTC (permalink / raw)
To: Leo Liu; +Cc: 20873
> I wonder if the following is the right fix?
[...]
> - (save-excursion (shell-backward-command 1) (point))))
> + (save-excursion (shell-backward-command 1)
> + (skip-syntax-forward " ")
> + (point))))
Could be. I don't have time to dig into it right now, but another
option might be to change shell-backward-command instead.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#20873: 24.5; shell command completion faulty
2015-06-22 22:13 ` Stefan Monnier
@ 2015-06-23 1:26 ` Leo Liu
0 siblings, 0 replies; 3+ messages in thread
From: Leo Liu @ 2015-06-23 1:26 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 20873-done
version: 25.1
On 2015-06-23 06:13 +0800, Stefan Monnier wrote:
> Could be. I don't have time to dig into it right now, but another
> option might be to change shell-backward-command instead.
OK. I put in a fix there. Thanks.
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-23 1:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-22 13:24 bug#20873: 24.5; shell command completion faulty Leo Liu
2015-06-22 22:13 ` Stefan Monnier
2015-06-23 1:26 ` Leo Liu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).