From: Stefan Kangas <stefan@marxist.se>
To: Noam Postavsky <npostavs@gmail.com>
Cc: "Stéphane Maniaci" <stephane.maniaci@gmail.com>, 39953@debbugs.gnu.org
Subject: bug#39953: 27.0.50; [PATCH] explicitly fail if Emacs was configured with but cannot compile native JSON support
Date: Sat, 25 Apr 2020 16:07:45 +0200 [thread overview]
Message-ID: <m2368ry7ym.fsf@stefankangas.se> (raw)
In-Reply-To: <87blny3zih.fsf@gmail.com> (Noam Postavsky's message of "Sat, 11 Apr 2020 09:47:34 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
>> This seems a bit too extreme to me, but I think giving an error on
>> missing Jansson headers only if --with-json is explicitly passed would
>> be okay.
>
> I was reminded about this from some reddit posts:
>
> https://old.reddit.com/r/emacs/comments/fwgpkd/weekly_tipstricketc_thread/fmo9d5v/
>
> Here's a proposed patch implementing my suggestion above.
My knowledge about the build system is rudimentary at best, so I can't
comment on your implementation. The behaviour you suggest sounds
reasonable though.
Best regards,
Stefan Kangas
next prev parent reply other threads:[~2020-04-25 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 12:13 bug#39953: 27.0.50; [PATCH] explicitly fail if Emacs was configured with but cannot compile native JSON support Stéphane Maniaci
2020-03-06 15:49 ` Eli Zaretskii
2020-03-10 2:14 ` Noam Postavsky
2020-04-11 13:47 ` Noam Postavsky
2020-04-25 14:07 ` Stefan Kangas [this message]
2020-08-08 13:54 ` Lars Ingebrigtsen
2020-08-14 17:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2368ry7ym.fsf@stefankangas.se \
--to=stefan@marxist.se \
--cc=39953@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=stephane.maniaci@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).