From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#39953: 27.0.50; [PATCH] explicitly fail if Emacs was configured with but cannot compile native JSON support Date: Sat, 25 Apr 2020 16:07:45 +0200 Message-ID: References: <83sgilpjpl.fsf@gnu.org> <87v9nd6jo4.fsf@gmail.com> <87blny3zih.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="61216"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) Cc: =?UTF-8?Q?St=C3=A9phane?= Maniaci , 39953@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 25 16:08:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jSLTX-000Foh-Df for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 16:08:11 +0200 Original-Received: from localhost ([::1]:37814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSLTW-000296-2F for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Apr 2020 10:08:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37570) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSLTP-00028n-AP for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 10:08:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSLTO-0004OC-Rc for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 10:08:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jSLTO-0004O7-Fl for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 10:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jSLTO-0001Sk-B9 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2020 10:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2020 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39953 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39953-submit@debbugs.gnu.org id=B39953.15878236765610 (code B ref 39953); Sat, 25 Apr 2020 14:08:02 +0000 Original-Received: (at 39953) by debbugs.gnu.org; 25 Apr 2020 14:07:56 +0000 Original-Received: from localhost ([127.0.0.1]:60110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSLTI-0001SP-5j for submit@debbugs.gnu.org; Sat, 25 Apr 2020 10:07:56 -0400 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:40220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSLTF-0001SD-VI for 39953@debbugs.gnu.org; Sat, 25 Apr 2020 10:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=e71eObVrslOHiRgIQXjDazITljFDtgx+kdTj2wmSRTE=; b=Ritooty0oUBo4QWko737V81gSG rxYHygquZSrC4jEeFkiZTcGBP4C3cOeBy6/bSzsUJrtQwqbuvbEUnEyb9QlOhT0TeMSDjlQfslfP9 nQ9e9frvTkcG91O7UsieuPV3CZHEesF9K/ENkX5lWFx7KviFXUjegiBruJVl15XWh/QBkER1pM+ph WW4+qzI6NsUJqzZYV9mXxP040Z4QTCJy7bvUnQLSHxFbA/Fam/sQe4zDnPtOAmsZWY9WWv9zOUZjZ BVxPxaeV3CVfe9phIw408InTUFsbbZ0FREVMOoOFkid73Q7csMoNEhRIn6uQHLyiOcv3AFALfiSWS 7HldmybA==; Original-Received: from h-4-70-69.a785.priv.bahnhof.se ([155.4.70.69]:64662 helo=Stefans-MacBook-Pro.local) by ted.gofardesign.uk with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jSLTA-000xEX-BF; Sat, 25 Apr 2020 10:07:48 -0400 In-Reply-To: <87blny3zih.fsf@gmail.com> (Noam Postavsky's message of "Sat, 11 Apr 2020 09:47:34 -0400") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178996 Archived-At: Noam Postavsky writes: >> This seems a bit too extreme to me, but I think giving an error on >> missing Jansson headers only if --with-json is explicitly passed would >> be okay. > > I was reminded about this from some reddit posts: > > https://old.reddit.com/r/emacs/comments/fwgpkd/weekly_tipstricketc_thread/fmo9d5v/ > > Here's a proposed patch implementing my suggestion above. My knowledge about the build system is rudimentary at best, so I can't comment on your implementation. The behaviour you suggest sounds reasonable though. Best regards, Stefan Kangas