unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
@ 2016-05-02  7:15 Juliusz Chroboczek
  2016-05-02 14:26 ` Robert Pluim
  2019-09-15  1:39 ` Stefan Kangas
  0 siblings, 2 replies; 10+ messages in thread
From: Juliusz Chroboczek @ 2016-05-02  7:15 UTC (permalink / raw)
  To: 23420

The French characters œ and Œ do not appear to be on the C-x 8 map.
Please add them (for example to « C-x 8 o e » and « C-x 8 O E »).

Thanks.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02  7:15 bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map Juliusz Chroboczek
@ 2016-05-02 14:26 ` Robert Pluim
  2016-05-02 15:23   ` Eli Zaretskii
  2019-09-15  1:39 ` Stefan Kangas
  1 sibling, 1 reply; 10+ messages in thread
From: Robert Pluim @ 2016-05-02 14:26 UTC (permalink / raw)
  To: 23420

Juliusz Chroboczek <jch@pps.univ-paris-diderot.fr> writes:

> The French characters œ and Œ do not appear to be on the C-x 8 map.
> Please add them (for example to « C-x 8 o e » and « C-x 8 O E »).
>

Currently:
C-x 8 o => °

so at least the first mapping is not possible. There is the
alternative

C-x 8 *o => °

though, so perhaps we should remove the first one. Else something like
the following assigns them off C-x 8 O[eE]

diff --git a/lisp/international/iso-transl.el b/lisp/international/iso-transl.el
index 1436cf8..c150842 100644
--- a/lisp/international/iso-transl.el
+++ b/lisp/international/iso-transl.el
@@ -177,6 +177,8 @@ iso-transl-char-map
     ("c"    . [?¢])
     ("*o"   . [?°])
     ("o"    . [?°])
+    ("Oe"   . [?œ])
+    ("OE"   . [?Œ])
     ("*u"   . [?µ])
     ("u"    . [?µ])
     ("*m"   . [?µ])






^ permalink raw reply related	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02 14:26 ` Robert Pluim
@ 2016-05-02 15:23   ` Eli Zaretskii
  2016-05-02 15:40     ` Robert Pluim
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-05-02 15:23 UTC (permalink / raw)
  To: 23420

> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 02 May 2016 16:26:00 +0200
> 
> Currently:
> C-x 8 o => °
> 
> so at least the first mapping is not possible. There is the
> alternative
> 
> C-x 8 *o => °
> 
> though, so perhaps we should remove the first one.

Sorry, no: the "C-x 8 o" binding is very old, since Emacs 21 at least,
so removing it now runs the risk of breaking someone's muscle memory.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02 15:23   ` Eli Zaretskii
@ 2016-05-02 15:40     ` Robert Pluim
  2016-05-02 15:57       ` Eli Zaretskii
  0 siblings, 1 reply; 10+ messages in thread
From: Robert Pluim @ 2016-05-02 15:40 UTC (permalink / raw)
  To: 23420

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 02 May 2016 16:26:00 +0200
>> 
>> Currently:
>> C-x 8 o => °
>> 
>> so at least the first mapping is not possible. There is the
>> alternative
>> 
>> C-x 8 *o => °
>> 
>> though, so perhaps we should remove the first one.
>
> Sorry, no: the "C-x 8 o" binding is very old, since Emacs 21 at least,
> so removing it now runs the risk of breaking someone's muscle memory.

Indeed, I went back and stopped when I'd gone 17 years...

(I've forgotten what the magic header is for "it's a small change, no
paperwork required, I don't have commit rights")

2016-05-02  Robert Pluim  <rpluim@gmail.com>

	* lisp/international/iso-transl.el (iso-transl-char-map): Add
	bindings for small and capital ligature oe.

diff --git a/lisp/international/iso-transl.el b/lisp/international/iso-transl.el
index 1436cf8..c150842 100644
--- a/lisp/international/iso-transl.el
+++ b/lisp/international/iso-transl.el
@@ -177,6 +177,8 @@ iso-transl-char-map
     ("c"    . [?¢])
     ("*o"   . [?°])
     ("o"    . [?°])
+    ("Oe"   . [?œ])
+    ("OE"   . [?Œ])
     ("*u"   . [?µ])
     ("u"    . [?µ])
     ("*m"   . [?µ])






^ permalink raw reply related	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02 15:40     ` Robert Pluim
@ 2016-05-02 15:57       ` Eli Zaretskii
  2016-05-02 16:01         ` Robert Pluim
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-05-02 15:57 UTC (permalink / raw)
  To: 23420

> From: Robert Pluim <rpluim@gmail.com>
> Date: Mon, 02 May 2016 17:40:57 +0200
> 
> (I've forgotten what the magic header is for "it's a small change, no
> paperwork required, I don't have commit rights")

See CONTRIBUTE.

Thanks.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02 15:57       ` Eli Zaretskii
@ 2016-05-02 16:01         ` Robert Pluim
  0 siblings, 0 replies; 10+ messages in thread
From: Robert Pluim @ 2016-05-02 16:01 UTC (permalink / raw)
  To: 23420

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Mon, 02 May 2016 17:40:57 +0200
>> 
>> (I've forgotten what the magic header is for "it's a small change, no
>> paperwork required, I don't have commit rights")
>
> See CONTRIBUTE.

Thanks. Filed away for next time.






^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2016-05-02  7:15 bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map Juliusz Chroboczek
  2016-05-02 14:26 ` Robert Pluim
@ 2019-09-15  1:39 ` Stefan Kangas
  2019-09-15 15:34   ` Eli Zaretskii
  1 sibling, 1 reply; 10+ messages in thread
From: Stefan Kangas @ 2019-09-15  1:39 UTC (permalink / raw)
  To: Robert Pluim; +Cc: 23420

Robert Pluim <rpluim@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> From: Robert Pluim <rpluim@gmail.com>
>>> Date: Mon, 02 May 2016 16:26:00 +0200
>>>
>>> Currently:
>>> C-x 8 o => °
>>>
>>> so at least the first mapping is not possible. There is the
>>> alternative
>>>
>>> C-x 8 *o => °
>>>
>>> though, so perhaps we should remove the first one.
>>
>> Sorry, no: the "C-x 8 o" binding is very old, since Emacs 21 at least,
>> so removing it now runs the risk of breaking someone's muscle memory.
>
> Indeed, I went back and stopped when I'd gone 17 years...
>
> (I've forgotten what the magic header is for "it's a small change, no
> paperwork required, I don't have commit rights")
>
> 2016-05-02  Robert Pluim  <rpluim@gmail.com>
>
>     * lisp/international/iso-transl.el (iso-transl-char-map): Add
>     bindings for small and capital ligature oe.
>
> diff --git a/lisp/international/iso-transl.el b/lisp/international/iso-transl.el
> index 1436cf8..c150842 100644
> --- a/lisp/international/iso-transl.el
> +++ b/lisp/international/iso-transl.el
> @@ -177,6 +177,8 @@ iso-transl-char-map
>      ("c"    . [?¢])
>      ("*o"   . [?°])
>      ("o"    . [?°])
> +    ("Oe"   . [?œ])
> +    ("OE"   . [?Œ])
>      ("*u"   . [?µ])
>      ("u"    . [?µ])
>      ("*m"   . [?µ])

This is a good addition, but it was never committed at the time.
Perhaps we could revisit it and consider installing it on the master
branch?

Best regards,
Stefan Kangas





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2019-09-15  1:39 ` Stefan Kangas
@ 2019-09-15 15:34   ` Eli Zaretskii
  2019-09-15 15:44     ` Stefan Kangas
  0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2019-09-15 15:34 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: rpluim, 23420

> From: Stefan Kangas <stefan@marxist.se>
> Date: Sun, 15 Sep 2019 03:39:53 +0200
> Cc: 23420@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> 
> > 2016-05-02  Robert Pluim  <rpluim@gmail.com>
> >
> >     * lisp/international/iso-transl.el (iso-transl-char-map): Add
> >     bindings for small and capital ligature oe.
> >
> > diff --git a/lisp/international/iso-transl.el b/lisp/international/iso-transl.el
> > index 1436cf8..c150842 100644
> > --- a/lisp/international/iso-transl.el
> > +++ b/lisp/international/iso-transl.el
> > @@ -177,6 +177,8 @@ iso-transl-char-map
> >      ("c"    . [?¢])
> >      ("*o"   . [?°])
> >      ("o"    . [?°])
> > +    ("Oe"   . [?œ])
> > +    ("OE"   . [?Œ])
> >      ("*u"   . [?µ])
> >      ("u"    . [?µ])
> >      ("*m"   . [?µ])
> 
> This is a good addition, but it was never committed at the time.
> Perhaps we could revisit it and consider installing it on the master
> branch?

I think it should go in, yes.  I don't know why it stalled.





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2019-09-15 15:34   ` Eli Zaretskii
@ 2019-09-15 15:44     ` Stefan Kangas
  2019-09-16  8:27       ` Robert Pluim
  0 siblings, 1 reply; 10+ messages in thread
From: Stefan Kangas @ 2019-09-15 15:44 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Robert Pluim, 23420

Eli Zaretskii <eliz@gnu.org> writes:

> I think it should go in, yes.  I don't know why it stalled.

Thanks.  Robert, could you please commit this to master?

Best regards,
Stefan Kangas





^ permalink raw reply	[flat|nested] 10+ messages in thread

* bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map
  2019-09-15 15:44     ` Stefan Kangas
@ 2019-09-16  8:27       ` Robert Pluim
  0 siblings, 0 replies; 10+ messages in thread
From: Robert Pluim @ 2019-09-16  8:27 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 23420

tags 23420 fixed
close 23420 27.1
quit

>>>>> On Sun, 15 Sep 2019 17:44:56 +0200, Stefan Kangas <stefan@marxist.se> said:

    Stefan> Eli Zaretskii <eliz@gnu.org> writes:
    >> I think it should go in, yes.  I don't know why it stalled.

Because I dropped the ball.

    Stefan> Thanks.  Robert, could you please commit this to master?

Closing.
Committed as 3a18c82b8e





^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-09-16  8:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02  7:15 bug#23420: 25.0.93; Please add French oe and OE to C-x 8 map Juliusz Chroboczek
2016-05-02 14:26 ` Robert Pluim
2016-05-02 15:23   ` Eli Zaretskii
2016-05-02 15:40     ` Robert Pluim
2016-05-02 15:57       ` Eli Zaretskii
2016-05-02 16:01         ` Robert Pluim
2019-09-15  1:39 ` Stefan Kangas
2019-09-15 15:34   ` Eli Zaretskii
2019-09-15 15:44     ` Stefan Kangas
2019-09-16  8:27       ` Robert Pluim

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).