* bug#14096: 24.3; fit-window-to-buffer regression
@ 2013-03-30 17:18 Leo Liu
2013-03-30 19:29 ` martin rudalics
2014-01-13 17:51 ` martin rudalics
0 siblings, 2 replies; 10+ messages in thread
From: Leo Liu @ 2013-03-30 17:18 UTC (permalink / raw)
To: 14096
I just noticed this regression.
On 24.3, fit-window-to-buffer no longer respects window-min-height.
1. Make two window on a frame with one stacked on top of another
2. Make a new buffer in one of the window, type any word
3. M-x fit-window-to-buffer
You should see the new buffer shrunk to 1 line while window-min-height
is 4.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-03-30 17:18 bug#14096: 24.3; fit-window-to-buffer regression Leo Liu
@ 2013-03-30 19:29 ` martin rudalics
2013-03-31 3:42 ` Leo Liu
2014-01-13 17:51 ` martin rudalics
1 sibling, 1 reply; 10+ messages in thread
From: martin rudalics @ 2013-03-30 19:29 UTC (permalink / raw)
To: Leo Liu; +Cc: 14096
> On 24.3, fit-window-to-buffer no longer respects window-min-height.
>
> 1. Make two window on a frame with one stacked on top of another
> 2. Make a new buffer in one of the window, type any word
> 3. M-x fit-window-to-buffer
>
> You should see the new buffer shrunk to 1 line while window-min-height
> is 4.
Unfortunately, I also messed up the manual entry. Anyway, I'm changing
this currently to make the window fit the size of the buffer as it is
displayed and also counting the real size of the mode and the headerline
and a couple of other things. If you want to fix this yourself, call
(window-min-size) instead of (window-min-size nil nil t).
Thanks for the report, martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-03-30 19:29 ` martin rudalics
@ 2013-03-31 3:42 ` Leo Liu
2013-03-31 8:18 ` martin rudalics
0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-03-31 3:42 UTC (permalink / raw)
To: martin rudalics; +Cc: 14096
On 2013-03-31 03:29 +0800, martin rudalics wrote:
> Unfortunately, I also messed up the manual entry. Anyway, I'm changing
> this currently to make the window fit the size of the buffer as it is
> displayed and also counting the real size of the mode and the headerline
> and a couple of other things. If you want to fix this yourself, call
> (window-min-size) instead of (window-min-size nil nil t).
Thanks. I'll leave this to the expert ;)
Regards,
Leo
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-03-31 3:42 ` Leo Liu
@ 2013-03-31 8:18 ` martin rudalics
2013-11-19 9:59 ` Leo Liu
0 siblings, 1 reply; 10+ messages in thread
From: martin rudalics @ 2013-03-31 8:18 UTC (permalink / raw)
To: Leo Liu; +Cc: 14096
> Thanks. I'll leave this to the expert ;)
Don't hold your breath, though ;-) I won't synchronize with the trunk
for quite some time.
martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-03-31 8:18 ` martin rudalics
@ 2013-11-19 9:59 ` Leo Liu
2013-11-20 7:33 ` martin rudalics
0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2013-11-19 9:59 UTC (permalink / raw)
To: martin rudalics; +Cc: 14096
On 2013-03-31 16:18 +0800, martin rudalics wrote:
> Don't hold your breath, though ;-) I won't synchronize with the trunk
> for quite some time.
>
> martin
I think this bug should be fixed for 24.4.
Leo
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-11-19 9:59 ` Leo Liu
@ 2013-11-20 7:33 ` martin rudalics
0 siblings, 0 replies; 10+ messages in thread
From: martin rudalics @ 2013-11-20 7:33 UTC (permalink / raw)
To: Leo Liu; +Cc: 14096
> I think this bug should be fixed for 24.4.
I'll do that.
martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2013-03-30 17:18 bug#14096: 24.3; fit-window-to-buffer regression Leo Liu
2013-03-30 19:29 ` martin rudalics
@ 2014-01-13 17:51 ` martin rudalics
2014-01-14 0:15 ` Leo Liu
1 sibling, 1 reply; 10+ messages in thread
From: martin rudalics @ 2014-01-13 17:51 UTC (permalink / raw)
To: Leo Liu; +Cc: 14096
> On 24.3, fit-window-to-buffer no longer respects window-min-height.
>
> 1. Make two window on a frame with one stacked on top of another
> 2. Make a new buffer in one of the window, type any word
> 3. M-x fit-window-to-buffer
>
> You should see the new buffer shrunk to 1 line while window-min-height
> is 4.
Should be fixed now. Please have a look.
Thanks, martin
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2014-01-13 17:51 ` martin rudalics
@ 2014-01-14 0:15 ` Leo Liu
2014-01-14 0:50 ` Glenn Morris
0 siblings, 1 reply; 10+ messages in thread
From: Leo Liu @ 2014-01-14 0:15 UTC (permalink / raw)
To: martin rudalics; +Cc: 14096-done
Fixed in 24.4
On 2014-01-14 01:51 +0800, martin rudalics wrote:
> Should be fixed now. Please have a look.
>
> Thanks, martin
It seems it has been fixed. Thanks, Martin.
Leo
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2014-01-14 0:15 ` Leo Liu
@ 2014-01-14 0:50 ` Glenn Morris
2014-01-14 4:43 ` Leo Liu
0 siblings, 1 reply; 10+ messages in thread
From: Glenn Morris @ 2014-01-14 0:50 UTC (permalink / raw)
To: 14096; +Cc: sdl.web
Leo Liu wrote:
> Fixed in 24.4
FYI, if you use "Version: 24.4", the bug tracker will understand what
you mean, which has some utility.
^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#14096: 24.3; fit-window-to-buffer regression
2014-01-14 0:50 ` Glenn Morris
@ 2014-01-14 4:43 ` Leo Liu
0 siblings, 0 replies; 10+ messages in thread
From: Leo Liu @ 2014-01-14 4:43 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14096
On 2014-01-14 08:50 +0800, Glenn Morris wrote:
> FYI, if you use "Version: 24.4", the bug tracker will understand what
> you mean, which has some utility.
Thanks. Didn't know that.
Leo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-01-14 4:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-30 17:18 bug#14096: 24.3; fit-window-to-buffer regression Leo Liu
2013-03-30 19:29 ` martin rudalics
2013-03-31 3:42 ` Leo Liu
2013-03-31 8:18 ` martin rudalics
2013-11-19 9:59 ` Leo Liu
2013-11-20 7:33 ` martin rudalics
2014-01-13 17:51 ` martin rudalics
2014-01-14 0:15 ` Leo Liu
2014-01-14 0:50 ` Glenn Morris
2014-01-14 4:43 ` Leo Liu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).