From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: "Philip Kaludercic" <philipk@posteo.net>,
"Dmitry Gutov" <dmitry@gutov.dev>,
"João Távora" <joaotavora@gmail.com>,
66948@debbugs.gnu.org, "Eli Zaretskii" <eliz@gnu.org>,
"Stefan Kangas" <stefankangas@gmail.com>
Subject: bug#66948: [PATCH] Add Completion Preview mode
Date: Fri, 10 Nov 2023 08:09:40 +0100 [thread overview]
Message-ID: <m1jzqqythn.fsf@dazzs-mbp.home> (raw)
In-Reply-To: <86y1f7cs8l.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 09 Nov 2023 09:25:22 +0200")
Juri Linkov <juri@linkov.net> writes:
>>>> While testing more, I noticed one strange thing,
>>>> I don't know if it's intended to work this way.
>> [...]
>>> This appears to be a general problem with `completion-in-region-mode`,
>>> that it keeps TAB bound to `completion-at-point` after a partial
>>> completion, so I don't think we should attempt to handle it in
>>> `completion-preview` specifically.
>>
>> Let me know if you think otherwise, that `completion-preview` should
>> handle this case specifically, although I'm pretty convinced that it's
>> the behavior of `completion-in-region-mode` that's not quite right here.
>
> This looks like a problem of `completion-in-region-mode` indeed.
And now that's been taken care of in Bug#67001 :)
>> Either way, I'm attaching an new patch (v3) that includes
>> `backward-delete-char-untabify` in `completion-preview-commands` to
>> provide a nicer OOTB experience for Elisp (as you suggested), along with
>> a couple of minor optimizations and documentation improvements.
>
> Let's see what Eli decides to do with your new package.
Sure. Eli, Stefan, any further comments about this addition?
Thanks,
Eshel
next prev parent reply other threads:[~2023-11-10 7:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 10:26 bug#66948: [PATCH] Add Completion Preview mode Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-05 18:26 ` Philip Kaludercic
2023-11-05 19:42 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 7:22 ` Juri Linkov
2023-11-06 15:30 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-06 18:05 ` Juri Linkov
2023-11-06 19:47 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-07 7:08 ` Juri Linkov
2023-11-08 7:30 ` Juri Linkov
2023-11-08 9:14 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-08 15:44 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-09 7:25 ` Juri Linkov
2023-11-10 7:09 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-11-10 7:43 ` Eli Zaretskii
2023-11-10 7:58 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 7:59 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 13:05 ` Eli Zaretskii
2023-11-10 16:23 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-11 8:53 ` Eli Zaretskii
2023-11-11 12:01 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 13:27 ` Eli Zaretskii
2023-11-15 14:22 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 17:17 ` Eli Zaretskii
2023-11-15 19:02 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-10 8:00 ` Philip Kaludercic
2023-11-06 7:36 ` Philip Kaludercic
2023-11-06 15:37 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-15 10:28 ` Sean Whitton
2023-11-15 10:57 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1jzqqythn.fsf@dazzs-mbp.home \
--to=bug-gnu-emacs@gnu.org \
--cc=66948@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=joaotavora@gmail.com \
--cc=juri@linkov.net \
--cc=me@eshelyaron.com \
--cc=philipk@posteo.net \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).