From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Fri, 10 Nov 2023 08:09:40 +0100 Message-ID: References: <87lebcqcof.fsf@posteo.net> <86a5rrcqd3.fsf@mail.linkov.net> <86zfzqeoix.fsf@mail.linkov.net> <86msvobtjm.fsf@mail.linkov.net> <86y1f7cs8l.fsf@mail.linkov.net> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7096"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , Dmitry Gutov , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66948@debbugs.gnu.org, Eli Zaretskii , Stefan Kangas To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 10 08:10:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1Lf4-0001e7-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Nov 2023 08:10:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1Leq-00050E-9f; Fri, 10 Nov 2023 02:10:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Leo-0004zu-RH for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 02:10:22 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1Leo-0002rI-JA for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 02:10:22 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1LfR-0007a8-Qv for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 02:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2023 07:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-submit@debbugs.gnu.org id=B66948.169960022829091 (code B ref 66948); Fri, 10 Nov 2023 07:11:01 +0000 Original-Received: (at 66948) by debbugs.gnu.org; 10 Nov 2023 07:10:28 +0000 Original-Received: from localhost ([127.0.0.1]:49390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Leu-0007Z9-5Z for submit@debbugs.gnu.org; Fri, 10 Nov 2023 02:10:28 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:33250 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1Lep-0007Yx-V9 for 66948@debbugs.gnu.org; Fri, 10 Nov 2023 02:10:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1699600183; bh=m+kEeygWZ1J4ielRM5aw3pBZV5+l9wUT5IDAG5ovHEE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DlSf3V5LdDpmRahvZvHuPRVkWsL6r5U+CQb5r68VJkOY5ITmErc3dJSZHEjN+ME2j jrcXbVxzLNBNv2k+rx82L15fH9eAeeuKZ4fIvsWXG8neDkox30aTD2JbmF0RBSs5ja IpFJ5qP36GBnZBzCLPTBrmbnzZxYOXUBcedX9pQAo5viq23Owgx0qeeTBMO2vv76dU 3G1Y3CujfESkKGR1a/WAHzSF5U4vpy/HwCfLhxpPaCFj5TpSfTLgchD4cm2057n+fE beyW/xKS/bdvbb2E0OYi8NmFFp3xnL/fuFspdFvLoO+9Az5hjIjISSFqOQ/6GW2qmj Ti8xiZ8Eew13A== In-Reply-To: <86y1f7cs8l.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 09 Nov 2023 09:25:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274087 Archived-At: Juri Linkov writes: >>>> While testing more, I noticed one strange thing, >>>> I don't know if it's intended to work this way. >> [...] >>> This appears to be a general problem with `completion-in-region-mode`, >>> that it keeps TAB bound to `completion-at-point` after a partial >>> completion, so I don't think we should attempt to handle it in >>> `completion-preview` specifically. >> >> Let me know if you think otherwise, that `completion-preview` should >> handle this case specifically, although I'm pretty convinced that it's >> the behavior of `completion-in-region-mode` that's not quite right here. > > This looks like a problem of `completion-in-region-mode` indeed. And now that's been taken care of in Bug#67001 :) >> Either way, I'm attaching an new patch (v3) that includes >> `backward-delete-char-untabify` in `completion-preview-commands` to >> provide a nicer OOTB experience for Elisp (as you suggested), along with >> a couple of minor optimizations and documentation improvements. > > Let's see what Eli decides to do with your new package. Sure. Eli, Stefan, any further comments about this addition? Thanks, Eshel