From: Leo <sdl.web@gmail.com>
To: 9118@debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>
Subject: bug#9118: 23.3.50; Don't seed the RNG in message-unique-id
Date: Tue, 19 Jul 2011 00:42:10 +0800 [thread overview]
Message-ID: <m1fwm3r15p.fsf@gmail.com> (raw)
Function message-unique-id seeds the RNG every time it runs and relies
on its undocumented return value. Should something like this be applied?
--- a/message.el
+++ b/message.el
@@ -5484,7 +5484,8 @@
;; Don't use microseconds from (current-time), they may be unsupported.
;; Instead we use this randomly inited counter.
(setq message-unique-id-char
- (% (1+ (or message-unique-id-char (logand (random t) (1- (lsh 1 20)))))
+ (% (1+ (or message-unique-id-char
+ (logand (random most-positive-fixnum) (1- (lsh 1 20)))))
;; (current-time) returns 16-bit ints,
;; and 2^16*25 just fits into 4 digits i base 36.
(* 25 25)))
Diff finished. Tue Jul 19 00:34:45 2011
Leo
next reply other threads:[~2011-07-18 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 16:42 Leo [this message]
2011-07-19 14:57 ` bug#9118: 23.3.50; Don't seed the RNG in message-unique-id Lars Magne Ingebrigtsen
2011-07-19 15:14 ` Leo
2011-07-19 15:24 ` Lars Magne Ingebrigtsen
2011-07-19 15:44 ` Leo
2011-07-19 15:49 ` Lars Magne Ingebrigtsen
2011-07-20 2:12 ` Leo
2011-07-20 20:28 ` Lars Magne Ingebrigtsen
2011-07-21 4:45 ` Leo
2011-07-21 11:57 ` Juanma Barranquero
2011-07-21 15:58 ` Leo
2011-07-31 15:39 ` Lars Magne Ingebrigtsen
2011-07-31 16:02 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fwm3r15p.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=9118@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).