From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#9118: 23.3.50; Don't seed the RNG in message-unique-id Date: Tue, 19 Jul 2011 00:42:10 +0800 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1311010135 3722 80.91.229.12 (18 Jul 2011 17:28:55 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Jul 2011 17:28:55 +0000 (UTC) Cc: Lars Magne Ingebrigtsen To: 9118@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 18 19:28:49 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qircd-0006By-Ub for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2011 19:28:48 +0200 Original-Received: from localhost ([::1]:59402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qircc-00073B-I0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2011 13:28:46 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:55795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiquR-0002nA-4D for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:43:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QiquP-0001bJ-PD for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:43:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QiquP-0001bD-Iu for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:43:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QiquM-0007jf-Kz; Mon, 18 Jul 2011 12:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2011 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9118 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Magne Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.131100736029704 (code B ref -1); Mon, 18 Jul 2011 16:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jul 2011 16:42:40 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qiqtz-0007j2-Gd for submit@debbugs.gnu.org; Mon, 18 Jul 2011 12:42:40 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qiqtv-0007ip-5o for submit@debbugs.gnu.org; Mon, 18 Jul 2011 12:42:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qiqtn-0001VU-KM for submit@debbugs.gnu.org; Mon, 18 Jul 2011 12:42:29 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:46842) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qiqtn-0001VP-4t for submit@debbugs.gnu.org; Mon, 18 Jul 2011 12:42:27 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:55586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qiqtl-0002bO-9k for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:42:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qiqth-0001Un-Ng for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:42:24 -0400 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:62043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qiqth-0001UZ-AF for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2011 12:42:21 -0400 Original-Received: by iyb14 with SMTP id 14so2284295iyb.0 for ; Mon, 18 Jul 2011 09:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=B1Qq0KUfWeK+KG3FvMrfCVd7wevEWcKXvLp9mKbgXps=; b=wgQnoWvi4vLGiSdXGyC47wC+aW+O97rwpeEsFfwbz3ohFc0WP/4w/55RpnkekkQ84g pt11ZmCZb33a1hyLhEseg+012qEMAFG5bXZ4vk9AKt6ZNEjqBvR9a4TfCd0K5rcN8E7O 3/MqnWoGD0/Fg5+jYMyhS4CZZmxwfjZMyJQJE= Original-Received: by 10.42.133.69 with SMTP id g5mr6503114ict.289.1311007339898; Mon, 18 Jul 2011 09:42:19 -0700 (PDT) Original-Received: from localhost ([114.247.10.74]) by mx.google.com with ESMTPS id q13sm3021676ibi.43.2011.07.18.09.42.16 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Jul 2011 09:42:19 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 18 Jul 2011 12:43:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:49410 Archived-At: Function message-unique-id seeds the RNG every time it runs and relies on its undocumented return value. Should something like this be applied? --- a/message.el +++ b/message.el @@ -5484,7 +5484,8 @@ ;; Don't use microseconds from (current-time), they may be unsupported. ;; Instead we use this randomly inited counter. (setq message-unique-id-char - (% (1+ (or message-unique-id-char (logand (random t) (1- (lsh 1 20))))) + (% (1+ (or message-unique-id-char + (logand (random most-positive-fixnum) (1- (lsh 1 20))))) ;; (current-time) returns 16-bit ints, ;; and 2^16*25 just fits into 4 digits i base 36. (* 25 25))) Diff finished. Tue Jul 19 00:34:45 2011 Leo