From: Leo Liu <sdl.web@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Naïm Favier" <n.emacs@monade.li>, 37344@debbugs.gnu.org
Subject: bug#37344: rcirc: nil gets interpreted as a nickname
Date: Sat, 21 Sep 2019 13:21:04 +0800 [thread overview]
Message-ID: <m1ftkqp6m7.fsf@gmail.com> (raw)
In-Reply-To: <87impm95sh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 20 Sep 2019 20:33:18 +0200")
On 2019-09-20 20:33 +0200, Lars Ingebrigtsen wrote:
>> Thanks. Does the following patch fix the issue?
>
> It was confirmed that it does, so I guess you should just apply the
> patch, but:
Will do.
>> -(defun rcirc-cmd-me (args &optional process target)
>> - (rcirc-send-ctcp process target "ACTION" args))
>> +(defun rcirc-cmd-me (args process target)
>> + (when target (rcirc-send-ctcp process target "ACTION" args)))
>
> Perhaps you should keep the &optional there to avoid changing the call
> signature? Somebody else may have code that calls the function with
> that calling convention.
The signature is wrong from the start. Directly call them without
providing these optional (mandatory-in-disguise) arguments throws an
error, unlike commands defined by defun-rcirc-command which correctly
handle &optional arguments. I'll commit the patch as is if no
objections. Thanks for raising the issue.
Leo
next prev parent reply other threads:[~2019-09-21 5:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 18:58 bug#37344: rcirc: nil gets interpreted as a nickname Naïm Favier
2019-09-09 1:24 ` Leo Liu
2019-09-09 9:56 ` Naïm Favier
2019-09-20 18:33 ` Lars Ingebrigtsen
2019-09-21 5:21 ` Leo Liu [this message]
2019-10-07 4:55 ` Lars Ingebrigtsen
2019-10-07 11:01 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ftkqp6m7.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=37344@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=n.emacs@monade.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).