From: "Naïm Favier" <n.emacs@monade.li>
To: 37344@debbugs.gnu.org
Subject: bug#37344: rcirc: nil gets interpreted as a nickname
Date: Sun, 8 Sep 2019 20:58:59 +0200 [thread overview]
Message-ID: <CAHEx5uvOD5WHzSE8JXf1-Lf_XDEwfY6uF-X3a90Qv3ASqPX4cw@mail.gmail.com> (raw)
Severity: normal
Ever since I changed my nickname to "nil" on Freenode, I've been
getting occasional private messages from unknown users consisting of a
single empty CTCP ACTION. After a bit of investigating, it turned out
they all used rcirc. The situation was clear at that point: somewhere
in rcirc's source code, a nil value is being implicitly converted to a
string and used as the target of a PRIVMSG command.
The bug seems to be reproducible by issuing "/me" (without arguments)
inside a server buffer: the "nil" user on that server gets sent an
empty ACTION.
Suggested fix: in rcirc-send-privmsg, fail if target is nil. It might
be useful to check other places where the "%s" format is used, to
discover similar bugs.
next reply other threads:[~2019-09-08 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 18:58 Naïm Favier [this message]
2019-09-09 1:24 ` bug#37344: rcirc: nil gets interpreted as a nickname Leo Liu
2019-09-09 9:56 ` Naïm Favier
2019-09-20 18:33 ` Lars Ingebrigtsen
2019-09-21 5:21 ` Leo Liu
2019-10-07 4:55 ` Lars Ingebrigtsen
2019-10-07 11:01 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHEx5uvOD5WHzSE8JXf1-Lf_XDEwfY6uF-X3a90Qv3ASqPX4cw@mail.gmail.com \
--to=n.emacs@monade.li \
--cc=37344@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).