unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
@ 2010-12-07 10:26 Leo
  2010-12-13 16:58 ` Stefan Monnier
  2010-12-16  2:28 ` Chong Yidong
  0 siblings, 2 replies; 3+ messages in thread
From: Leo @ 2010-12-07 10:26 UTC (permalink / raw)
  To: 7578

It seems better for emacs not to litter the user's HOME.

commit 3a9f8163e6eeefd00fc6fe5a531049c22c7acf79 (HEAD, refs/heads/leo-main)
Date:   Tue Dec 7 10:21:18 2010 +0000

    Tweak eshell-directory-name

	Modified lisp/eshell/eshell.el
diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
index 74f65d2..f8cf9dc 100644
--- a/lisp/eshell/eshell.el
+++ b/lisp/eshell/eshell.el
@@ -285,7 +285,8 @@ shells such as bash, zsh, rc, 4dos."
   "`eshell-buffer-name' is a member of `same-window-buffer-names'"
   (member eshell-buffer-name same-window-buffer-names))
 
-(defcustom eshell-directory-name (convert-standard-filename "~/.eshell/")
+(defcustom eshell-directory-name
+  (locate-user-emacs-file "eshell/" ".eshell/")
   "The directory where Eshell control files should be kept."
   :type 'directory
   :group 'eshell)






^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
  2010-12-07 10:26 bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d Leo
@ 2010-12-13 16:58 ` Stefan Monnier
  2010-12-16  2:28 ` Chong Yidong
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2010-12-13 16:58 UTC (permalink / raw)
  To: Leo; +Cc: 7578

> 	Modified lisp/eshell/eshell.el
> diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
> index 74f65d2..f8cf9dc 100644
> --- a/lisp/eshell/eshell.el
> +++ b/lisp/eshell/eshell.el
> @@ -285,7 +285,8 @@ shells such as bash, zsh, rc, 4dos."
>    "`eshell-buffer-name' is a member of `same-window-buffer-names'"
>    (member eshell-buffer-name same-window-buffer-names))
 
> -(defcustom eshell-directory-name (convert-standard-filename "~/.eshell/")
> +(defcustom eshell-directory-name
> +  (locate-user-emacs-file "eshell/" ".eshell/")
>    "The directory where Eshell control files should be kept."
>    :type 'directory
>    :group 'eshell)

That's a good change, yes.  Feel free to install it.


        Stefan





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d
  2010-12-07 10:26 bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d Leo
  2010-12-13 16:58 ` Stefan Monnier
@ 2010-12-16  2:28 ` Chong Yidong
  1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2010-12-16  2:28 UTC (permalink / raw)
  To: Leo; +Cc: 7578

Leo <sdl.web@gmail.com> writes:

> It seems better for emacs not to litter the user's HOME.

Thanks, committed to the trunk.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-16  2:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-07 10:26 bug#7578: 23.2.90; [PATCH] Move ESHELL directory inside .emacs.d Leo
2010-12-13 16:58 ` Stefan Monnier
2010-12-16  2:28 ` Chong Yidong

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).