* bug#9317: [PATCH] Don't install .dir-locals.el
@ 2011-08-18 3:47 Leo
2011-08-19 3:04 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Leo @ 2011-08-18 3:47 UTC (permalink / raw)
To: 9317; +Cc: Chong Yidong, Lars Magne Ingebrigtsen
This is a minor bug but since the main .dir-locals.el in the toplevel of
the repo isn't installed, neither should lisp/gnus/.dir-locals.el and
maybe others.
=== modified file 'Makefile.in'
--- Makefile.in 2011-07-09 00:18:49 +0000
+++ Makefile.in 2011-08-18 03:45:26 +0000
@@ -535,6 +535,7 @@
rm -f $${subdir}/.gitignore ; \
rm -f $${subdir}/.arch-inventory ; \
rm -f $${subdir}/.DS_Store ; \
+ rm -f $${subdir}/.dir-locals.el ; \
rm -f $${subdir}/\#* ; \
rm -f $${subdir}/.\#* ; \
rm -f $${subdir}/*~ ; \
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#9317: [PATCH] Don't install .dir-locals.el
2011-08-18 3:47 bug#9317: [PATCH] Don't install .dir-locals.el Leo
@ 2011-08-19 3:04 ` Stefan Monnier
2011-08-19 5:43 ` Leo
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-08-19 3:04 UTC (permalink / raw)
To: Leo; +Cc: Chong Yidong, Lars Magne Ingebrigtsen, 9317
> This is a minor bug but since the main .dir-locals.el in the toplevel of
> the repo isn't installed, neither should lisp/gnus/.dir-locals.el and
> maybe others.
I'm not sure it's something that needs fixing: the toplevel .dir-locals
has no clear destination (since the various subdirectories get installed
into different parts of the file system), where the
lisp/gnus/.dir-locals.el has a very clear destination, so I think it's
actually good to install it there.
Stefan
> === modified file 'Makefile.in'
> --- Makefile.in 2011-07-09 00:18:49 +0000
> +++ Makefile.in 2011-08-18 03:45:26 +0000
> @@ -535,6 +535,7 @@
> rm -f $${subdir}/.gitignore ; \
> rm -f $${subdir}/.arch-inventory ; \
> rm -f $${subdir}/.DS_Store ; \
> + rm -f $${subdir}/.dir-locals.el ; \
> rm -f $${subdir}/\#* ; \
> rm -f $${subdir}/.\#* ; \
> rm -f $${subdir}/*~ ; \
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#9317: [PATCH] Don't install .dir-locals.el
2011-08-19 3:04 ` Stefan Monnier
@ 2011-08-19 5:43 ` Leo
0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2011-08-19 5:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Chong Yidong, Lars Magne Ingebrigtsen, 9317
On 2011-08-19 11:04 +0800, Stefan Monnier wrote:
> I'm not sure it's something that needs fixing: the toplevel .dir-locals
> has no clear destination (since the various subdirectories get installed
> into different parts of the file system), where the
> lisp/gnus/.dir-locals.el has a very clear destination, so I think it's
> actually good to install it there.
subdir .dir-locals.el often just complement the toplevel one. So it is
not self-contained.
Leo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-19 5:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-18 3:47 bug#9317: [PATCH] Don't install .dir-locals.el Leo
2011-08-19 3:04 ` Stefan Monnier
2011-08-19 5:43 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).