bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Jari Aalto]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]


Change against Emacs CVS tree as of 2009-08-29 11:5 UTC

2009-08-29  Jari Aalto  <jari.aalto@cante.net>

        * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
        version control directories.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-ido.el-ido-ignore-files-add-more-version-contro.patch --]
[-- Type: text/x-diff, Size: 1213 bytes --]

From 510e3bbded329dd9ce03f3eb94e8ffc2d6d5b9be Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto@cante.net>
Date: Sat, 29 Aug 2009 11:51:32 +0300
Subject: [PATCH] lisp/ido.el: (ido-ignore-files): add more version control directories


Signed-off-by: Jari Aalto <jari.aalto@cante.net>
---
 lisp/ido.el |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/lisp/ido.el b/lisp/ido.el
index 2336fea..6316bdf 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -391,7 +391,21 @@ example functions that filter buffer names."
   :group 'ido)
 
 (defcustom ido-ignore-files
-  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
+  '(;; Version control system directories (VCS)
+    "\\`CVS/"
+    "\\`RCS/"
+    "\\`\\.svn/"
+    ;;  Distributed version control system directories (DVCS)
+    "\\`\\.darcs/"
+    "\\`\\.hg/"
+    "\\`\\.git/"
+    "\\`\\.mtn/"
+    ;; Backup files
+    "\\`#"
+    "\\`.#"
+    ;; Directory components
+    "\\`\\.\\./"
+    "\\`\\./")
   "List of regexps or functions matching file names to ignore.
 For example, traditional behavior is not to list files whose names begin
 with a #, for which the regexp is `\\`#'.  See the source file for
-- 
1.6.3.3

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Juri Linkov]

>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>         version control directories.

Better to initialize its default value from either
`vc-directory-exclusion-list' or `completion-ignored-extensions'.
The former is a subset of the latter.

> diff --git a/lisp/ido.el b/lisp/ido.el
> index 2336fea..6316bdf 100644
> --- a/lisp/ido.el
> +++ b/lisp/ido.el
> @@ -391,7 +391,21 @@ example functions that filter buffer names."
>    :group 'ido)
>
>  (defcustom ido-ignore-files
> -  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
> +  '(;; Version control system directories (VCS)
> +    "\\`CVS/"
> +    "\\`RCS/"
> +    "\\`\\.svn/"
> +    ;;  Distributed version control system directories (DVCS)
> +    "\\`\\.darcs/"
> +    "\\`\\.hg/"
> +    "\\`\\.git/"
> +    "\\`\\.mtn/"
> +    ;; Backup files
> +    "\\`#"
> +    "\\`.#"
> +    ;; Directory components
> +    "\\`\\.\\./"
> +    "\\`\\./")
>    "List of regexps or functions matching file names to ignore.
>  For example, traditional behavior is not to list files whose names begin
>  with a #, for which the regexp is `\\`#'.  See the source file for

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Lars Magne Ingebrigtsen]

Jari Aalto <jari.aalto@cante.net> writes:

>  (defcustom ido-ignore-files
> -  '("\\`CVS/" "\\`#" "\\`.#" "\\`\\.\\./" "\\`\\./")
> +  '(;; Version control system directories (VCS)
> +    "\\`CVS/"
> +    "\\`RCS/"
> +    "\\`\\.svn/"
> +    ;;  Distributed version control system directories (DVCS)
> +    "\\`\\.darcs/"
> +    "\\`\\.hg/"

(etc.)

I think this makes perfect sense.  It already ignores "CVS" and ".#", so
why not .svn and friends, too?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Leo]

On 2012-04-11 21:35 +0800, Lars Magne Ingebrigtsen wrote:
> I think this makes perfect sense.  It already ignores "CVS" and ".#", so
> why not .svn and friends, too?

,----[ C-h v ido-ignore-extensions RET ]
| ido-ignore-extensions is a variable defined in `ido.el'.
| Its value is t
| 
| Documentation:
| Non-nil means ignore files in `completion-ignored-extensions' list.
| 
| You can customize this variable.
| 
| [back]
`----

Leo

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Lars Magne Ingebrigtsen]

Leo <sdl.web@gmail.com> writes:

> On 2012-04-11 21:35 +0800, Lars Magne Ingebrigtsen wrote:
>> I think this makes perfect sense.  It already ignores "CVS" and ".#", so
>> why not .svn and friends, too?
>
> ,----[ C-h v ido-ignore-extensions RET ]
> | ido-ignore-extensions is a variable defined in `ido.el'.
> | Its value is t
> | 
> | Documentation:
> | Non-nil means ignore files in `completion-ignored-extensions' list.

That explains why it already ignored .bzr.  :-)

I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Chong Yidong]

> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>
> 2009-08-29  Jari Aalto  <jari.aalto@cante.net>
>
>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>         version control directories.

This change makes sense only if we never want to change these
directories.  In practice, if you are trying to complete a dotfile, you
are already planning to do something funky, so Emacs probably shouldn't
try to do any second-guessing.

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Jari Aalto]

Chong Yidong <cyd@stupidchicken.com> writes:

>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>
>> 2009-08-29  Jari Aalto  <jari.aalto@cante.net>
>>
>>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>         version control directories.
>
> This change makes sense only if we never want to change these
> directories.  In practice, if you are trying to complete a dotfile, you
> are already planning to do something funky, so Emacs probably shouldn't
> try to do any second-guessing.

Dot-file is not the same as version controlled control directory.

Jari

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Chong Yidong]

Jari Aalto <jari.aalto@cante.net> writes:

> Chong Yidong <cyd@stupidchicken.com> writes:
>
>>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>>
>>> 2009-08-29  Jari Aalto  <jari.aalto@cante.net>
>>>
>>>         * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>>         version control directories.
>>
>> This change makes sense only if we never want to change these
>> directories.  In practice, if you are trying to complete a dotfile, you
>> are already planning to do something funky, so Emacs probably shouldn't
>> try to do any second-guessing.
>
> Dot-file is not the same as version controlled control directory.

By version control directories, you mean .svn, .bzr, etc., right?  If I
understand your proposal correctly, it's to prevent ido from offering
these directories if the user tries types "." in the minibuffer.  But in
that case, as I said, the intention is clearly to edit a dotfile, so
something funky is already intended.  Correct me if I misunderstand.

bug#4286: CVS: lisp/ido.el -- improve ido-ignore-files

[Jari Aalto]

Chong Yidong <cyd@stupidchicken.com> writes:

>>>> Change against Emacs CVS tree as of 2009-08-29 11:5 UTC
>>>>
>>>> 2009-08-29 Jari Aalto <jari.aalto@cante.net>
>>>>
>>>> * ido.el (ido-ignore-files): Add RCS, svn, darcs, sh, git, mtn
>>>> version control directories.
>>>
>>> This change makes sense only if we never want to change these
>>> directories. In practice, if you are trying to complete a dotfile, you
>>> are already planning to do something funky, so Emacs probably shouldn't
>>> try to do any second-guessing.
>> Dot-file is not the same as version controlled control directory.
>
> By version control directories, you mean .svn, .bzr, etc., right? If I
> understand your proposal correctly, it's to prevent ido from offering
> these directories if the user tries types "." in the minibuffer. But
> in that case, as I said, the intention is clearly to edit a dotfile,
> so something funky is already intended. Correct me if I misunderstand.

Correct.

It's very rare for user to try to edit content of Version Control
directories. These are nor considered "dot-files" in a sense, that they
would be user editable by default. The content of Version Control
directories is managed by external programs.

Examples (Emacs CVS and directory lisp/) where Version Control
directories are ignored:

    loaddefs.el
    bindings.el
    find-cmd.el
    vc-hooks.el

Jari