From: Leo Liu <sdl.web@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 14434-done@debbugs.gnu.org
Subject: bug#14434: 24.3; lisp mode's comment start seems bad
Date: Fri, 07 Jun 2013 20:04:28 +0800 [thread overview]
Message-ID: <m18v2mp1o3.fsf@gmail.com> (raw)
In-Reply-To: <jwvwqqqhfo0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 22 May 2013 17:32:14 -0400")
On 2013-05-23 05:32 +0800, Stefan Monnier wrote:
> That's one way to see it. Another is that it's a regression introduced
> by the fix to bug#14303. It probably affects more than
> emacs-lisp-mode. So it'd be better to fix it by improving your fix to
> bug#14303. E.g. after the new while loop which finds the comment start, do
> a looking-at to make sure the match-data extends as far as possible.
>
> Tho maybe, we should take a new look at bug#14303 to see why it failed,
> since after all the old comment-search-backward did already pay
> attention to comment-use-global-state (via comment-search-forward), so
> maybe bug#14303 was really due to a bug in comment-search-forward.
Thanks, Stefan, for the hints.
The fix for bug#14303 seems bad so I have reverted it and instead set
comment-use-global-state to t in octave-mode.
Leo
next prev parent reply other threads:[~2013-06-07 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 4:26 bug#14434: 24.3; lisp mode's comment start seems bad Leo Liu
2013-05-22 6:15 ` Andreas Röhler
2013-05-22 21:32 ` Stefan Monnier
2013-06-07 12:04 ` Leo Liu [this message]
2013-06-07 16:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18v2mp1o3.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=14434-done@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).