From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#14434: 24.3; lisp mode's comment start seems bad Date: Fri, 07 Jun 2013 20:04:28 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1370606837 736 80.91.229.3 (7 Jun 2013 12:07:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Jun 2013 12:07:17 +0000 (UTC) Cc: 14434-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 07 14:07:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UkvRo-0002DQ-0w for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2013 14:07:12 +0200 Original-Received: from localhost ([::1]:55911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvRn-0003N9-7a for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2013 08:07:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvPp-000175-Un for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2013 08:05:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkvPj-0006QL-EP for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2013 08:05:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvPj-0006P3-8W for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2013 08:05:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UkvPj-0000wj-0a for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2013 08:05:03 -0400 Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2013 12:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14434 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14434@debbugs.gnu.org, sdl.web@gmail.com, sdl.web@gmail.com Original-Received: via spool by 14434-done@debbugs.gnu.org id=D14434.13706066873581 (code D ref 14434); Fri, 07 Jun 2013 12:05:02 +0000 Original-Received: (at 14434-done) by debbugs.gnu.org; 7 Jun 2013 12:04:47 +0000 Original-Received: from localhost ([127.0.0.1]:56137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UkvPS-0000va-40 for submit@debbugs.gnu.org; Fri, 07 Jun 2013 08:04:47 -0400 Original-Received: from mail-pd0-f173.google.com ([209.85.192.173]:41883) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UkvPP-0000vG-6s for 14434-done@debbugs.gnu.org; Fri, 07 Jun 2013 08:04:44 -0400 Original-Received: by mail-pd0-f173.google.com with SMTP id v14so842921pde.4 for <14434-done@debbugs.gnu.org>; Fri, 07 Jun 2013 05:04:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=ioUDWB0/x2o9KMG3fHBsqc7ootZKmXA/aOP5XPkUSms=; b=dhm14gP515+u9eU4Hts13iCWQj/Cigklq/cCHjxgJbImm65thfTa8W5VfngGuQ2t/L 143c/I4vwIuAvamEfRxhcmqjcQoFEj8bgQZvcMWk52QUvPw0WWt9i7bntELxnjWnjph8 0jUDcMYoO3eizcJmre53h/M26kg7yUrRxZmqaKpbyOYpWZBE4eBOWnClMXBcTsTfMfBK +cJ8qJmNttbL9sDv2/h2xJ1vBgUhD+USduHDMdIiVUK86EYhm40nPnk/MGKpmwSONGlj scoyR33qlHikX6g31s84O8aFwSjQfmqHVFqJ1OR/DxHkDXKf8hM41MIw6t1pPgxYg+M8 L6WQ== X-Received: by 10.68.233.98 with SMTP id tv2mr42770316pbc.146.1370606677214; Fri, 07 Jun 2013 05:04:37 -0700 (PDT) Original-Received: from Zeuss-MacBook.local ([119.161.133.157]) by mx.google.com with ESMTPSA id do4sm77356312pbc.8.2013.06.07.05.04.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 07 Jun 2013 05:04:36 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= In-Reply-To: (Stefan Monnier's message of "Wed, 22 May 2013 17:32:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74865 Archived-At: On 2013-05-23 05:32 +0800, Stefan Monnier wrote: > That's one way to see it. Another is that it's a regression introduced > by the fix to bug#14303. It probably affects more than > emacs-lisp-mode. So it'd be better to fix it by improving your fix to > bug#14303. E.g. after the new while loop which finds the comment start, do > a looking-at to make sure the match-data extends as far as possible. > > Tho maybe, we should take a new look at bug#14303 to see why it failed, > since after all the old comment-search-backward did already pay > attention to comment-use-global-state (via comment-search-forward), so > maybe bug#14303 was really due to a bug in comment-search-forward. Thanks, Stefan, for the hints. The fix for bug#14303 seems bad so I have reverted it and instead set comment-use-global-state to t in octave-mode. Leo