* bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
@ 2012-11-24 9:19 Leo
2012-11-24 15:24 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Leo @ 2012-11-24 9:19 UTC (permalink / raw)
To: 12979
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
Try inserting tag, such as `form' in html mode using M-x sgml-tag and
you will see the closing tag incorrectly indented as shown here:
[-- Attachment #2: sgml-tag-bug.png --]
[-- Type: image/png, Size: 9830 bytes --]
[-- Attachment #3: Type: text/plain, Size: 1129 bytes --]
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index b417df62..eb549017 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2012-11-24 Leo Liu <sdl.web@gmail.com>
+
+ * textmodes/sgml-mode.el (sgml-tag): Fix indentation for closing tag.
+
2012-10-05 Glenn Morris <rgm@gnu.org>
* net/newst-treeview.el (newsticker-group-move-feed): Doc fix.
diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el
index 09f6b6b7..d3b779d2 100644
--- a/lisp/textmodes/sgml-mode.el
+++ b/lisp/textmodes/sgml-mode.el
@@ -672,13 +672,13 @@ (define-skeleton sgml-tag
(if (eq v2 t) (setq v2 nil))
;; We use `identity' to prevent skeleton from passing
;; `str' through `skeleton-transformation-function' a second time.
- '(("") v2 _ v2 "</" (identity ',str) ?>))
+ '(("") v2 _ v2 "</" (identity ',str) ?> >))
((eq (car v2) t)
(cons '("") (cdr v2)))
(t
(append '(("") (car v2))
(cdr v2)
- '(resume: (car v2) _ "</" (identity ',str) ?>))))))
+ '(resume: (car v2) _ "</" (identity ',str) ?> >))))))
(autoload 'skeleton-read "skeleton")
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
2012-11-24 9:19 bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag Leo
@ 2012-11-24 15:24 ` Stefan Monnier
2012-11-25 16:11 ` Leo
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2012-11-24 15:24 UTC (permalink / raw)
To: Leo; +Cc: 12979
> Try inserting tag, such as `form' in html mode using M-x sgml-tag and
> you will see the closing tag incorrectly indented as shown here:
Looks good, feel free to install it on the trunk, thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag
2012-11-24 15:24 ` Stefan Monnier
@ 2012-11-25 16:11 ` Leo
0 siblings, 0 replies; 3+ messages in thread
From: Leo @ 2012-11-25 16:11 UTC (permalink / raw)
To: 12979-done
Fixed in trunk.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-25 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-24 9:19 bug#12979: 24.2; [PATCH] fix indentation for closing tag in sgml-tag Leo
2012-11-24 15:24 ` Stefan Monnier
2012-11-25 16:11 ` Leo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).