* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
[not found] <m135zlzj0l.fsf.ref@yahoo.es>
@ 2020-12-31 22:51 ` Unknown
2021-01-01 22:43 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: Unknown @ 2020-12-31 22:51 UTC (permalink / raw)
To: 45581
Steps to reproduce the problem:
1. emacs -Q
2. Open any file with source code (for example, xdisp.c).
3. Place the point in any symbol (for example, redisplay_internal).
4. Press M-? (`xref-find-references').
5. In the *xref* buffer, press n (`xref-next-line').
6. Press C-h m (`describe-mode').
7. Press C-M-v to scroll the help window.
Expected results:
The mode description window scrolls as usual.
Actual results:
The buffer with the file that contains the selected xref item replaces
the *Help* buffer and is scrolled instead.
I can't reproduce the same behavior in *grep* buffers.
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
2020-12-31 22:51 ` bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling Unknown
@ 2021-01-01 22:43 ` Dmitry Gutov
2021-01-02 8:25 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-01-01 22:43 UTC (permalink / raw)
To: Daniel Martín, 45581
Hi!
On 01.01.2021 00:51, Daniel Martín via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
>
> Steps to reproduce the problem:
>
> 1. emacs -Q
> 2. Open any file with source code (for example, xdisp.c).
> 3. Place the point in any symbol (for example, redisplay_internal).
> 4. Press M-? (`xref-find-references').
> 5. In the *xref* buffer, press n (`xref-next-line').
> 6. Press C-h m (`describe-mode').
> 7. Press C-M-v to scroll the help window.
>
> Expected results:
>
> The mode description window scrolls as usual.
>
> Actual results:
>
> The buffer with the file that contains the selected xref item replaces
> the *Help* buffer and is scrolled instead.
>
> I can't reproduce the same behavior in *grep* buffers.
Thanks for the report.
Xref buffers have been doing this since bug#19466, as requested by
Martin (see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19466#56).
Perhaps Martin or others will chime in, but otherwise you seem to be
making a good case for not doing this anymore.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
2021-01-01 22:43 ` Dmitry Gutov
@ 2021-01-02 8:25 ` martin rudalics
2021-01-02 18:58 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2021-01-02 8:25 UTC (permalink / raw)
To: Dmitry Gutov, Daniel Martín, 45581
> Xref buffers have been doing this since bug#19466, as requested by
> Martin (see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19466#56).
>
> Perhaps Martin or others will chime in, but otherwise you seem to be
> making a good case for not doing this anymore.
Probably. 'cvs-temp-buffer' has a similar note:
;; FIXME: this doesn't do the right thing if the user later on
;; does a `find-file-other-window' and `scroll-other-window'
(setq-local other-window-scroll-buffer buf))
I don't use C-M-v so I can't tell whether 'other-window-scroll-buffer'
was ever useful in the first place for *xref*.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
2021-01-02 8:25 ` martin rudalics
@ 2021-01-02 18:58 ` Dmitry Gutov
2021-01-03 8:40 ` martin rudalics
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Gutov @ 2021-01-02 18:58 UTC (permalink / raw)
To: martin rudalics, Daniel Martín, 45581-done
Version: 28.1
On 02.01.2021 10:25, martin rudalics wrote:
> Probably. 'cvs-temp-buffer' has a similar note:
>
> ;; FIXME: this doesn't do the right thing if the user later on
> ;; does a `find-file-other-window' and `scroll-other-window'
> (setq-local other-window-scroll-buffer buf))
>
> I don't use C-M-v so I can't tell whether 'other-window-scroll-buffer'
> was ever useful in the first place for *xref*.
Great, so we can remove it (pushed as 6b10ce867f).
As a result, C-M-v doesn't always scroll the "target location" window
anymore (at least, not when there are at least 3 windows on the frame).
I wonder if we can/should do something about it. Other standard commands
don't seem to worry about that, though.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
2021-01-02 18:58 ` Dmitry Gutov
@ 2021-01-03 8:40 ` martin rudalics
2021-01-04 0:22 ` Dmitry Gutov
0 siblings, 1 reply; 6+ messages in thread
From: martin rudalics @ 2021-01-03 8:40 UTC (permalink / raw)
To: Dmitry Gutov, Daniel Martín, 45581-done
> As a result, C-M-v doesn't always scroll the "target location" window anymore (at least, not when there are at least 3 windows on the frame).
>
> I wonder if we can/should do something about it. Other standard commands don't seem to worry about that, though.
I doubt that anybody cares. My suggestion back then was just bad.
'other-window-scroll-buffer' is an ill-advised concept which can fly
only if the buffer where it is set locally is small (so a user will not
wonder about what that buffer has been conceived for and, for example,
ask questions about its modes or keymaps) is displayed for a short time
only and the visibility of the buffer it refers to is absolutely crucial
for the current workflow. Neither of these conditions is given in the
present context and I doubt that they are given in any of the other
occurrences of that variable.
martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling
2021-01-03 8:40 ` martin rudalics
@ 2021-01-04 0:22 ` Dmitry Gutov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Gutov @ 2021-01-04 0:22 UTC (permalink / raw)
To: martin rudalics, Daniel Martín, 45581-done
On 03.01.2021 10:40, martin rudalics wrote:
> I doubt that anybody cares. My suggestion back then was just bad.
> 'other-window-scroll-buffer' is an ill-advised concept which can fly
> only if the buffer where it is set locally is small (so a user will not
> wonder about what that buffer has been conceived for and, for example,
> ask questions about its modes or keymaps) is displayed for a short time
> only and the visibility of the buffer it refers to is absolutely crucial
> for the current workflow. Neither of these conditions is given in the
> present context and I doubt that they are given in any of the other
> occurrences of that variable.
Thanks. So we'll keep it the way it is now.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-04 0:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <m135zlzj0l.fsf.ref@yahoo.es>
2020-12-31 22:51 ` bug#45581: 28.0.50; C-M-v in xref buffers shows a different buffer when scrolling Unknown
2021-01-01 22:43 ` Dmitry Gutov
2021-01-02 8:25 ` martin rudalics
2021-01-02 18:58 ` Dmitry Gutov
2021-01-03 8:40 ` martin rudalics
2021-01-04 0:22 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).