From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 63785@debbugs.gnu.org
Subject: bug#63785: 29.0.91; Clearing package list filters also clears flags
Date: Tue, 30 May 2023 11:43:51 +0300 [thread overview]
Message-ID: <m1353emcoo.fsf@eshelyaron.com> (raw)
In-Reply-To: <87o7m3ax2c.fsf@gmail.com> (Robert Pluim's message of "Mon, 29 May 2023 19:04:27 +0200")
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Mon, 29 May 2023 19:48:45 +0300, Eshel Yaron <me@eshelyaron.com> said:
>
> Eshel> Robert Pluim <rpluim@gmail.com> writes:
> >> M-x list-packages
> >> / n ack ;; navigate to the line for 'ack'
> >> i ;; 'ack' has the 'I' flag
> >> / / ;; 'ack' no longer has the I flag
> >>
> >> This makes it harder to do 'search for foo, mark,
> >> search for bar, mark, install', you have to remember to execute the
> >> action after each mark command.
> >>
>
> Eshel> That's an interesting issue, it can be a bit tricky because while
> Eshel> filtering for "bar", "foo" is no longer anywhere to be found in the
> Eshel> buffer. So AFAIU to solve this Emacs needs to maintain something like a
> Eshel> buffer-local association between list entry (package) ids and the tags
> Eshel> they were given.
>
> Eshel> This sounds like something that applies more broadly to other
> Eshel> `tabulated-list-mode` derivatives as well. The attached patch adds a
> Eshel> `tabulated-list-maintain-tags` variable and enables it in
> Eshel> `package-menu-mode`. With it I can search and mark foo, then search and
> Eshel> mark bar, and then install both, as you say. WDYT?
>
> Itʼs close. The following is still suprising
>
> / n helm
> i
> / /
> / n ack
> i
> x
>
> That only offer to installs ack, even though Iʼve marked helm. If I
> clear the filters then 'x' offers to install both. Although I could
> argue that Iʼm in a filtered state, so offering to install only
> visible packages is normal :-)
Yes, that's what I thought. Only installing visible packages when the
menu is filtered seems sensible to me. Although I guess
`package-menu-execute` could be extended with some option that says what
to do in these cases, maybe by default it could suggest clearing the
filter first?
next prev parent reply other threads:[~2023-05-30 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 14:44 bug#63785: 29.0.91; Clearing package list filters also clears flags Robert Pluim
2023-05-29 16:48 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 17:04 ` Robert Pluim
2023-05-30 8:43 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-30 9:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1353emcoo.fsf@eshelyaron.com \
--to=bug-gnu-emacs@gnu.org \
--cc=63785@debbugs.gnu.org \
--cc=me@eshelyaron.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).