From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63785: 29.0.91; Clearing package list filters also clears flags Date: Tue, 30 May 2023 11:43:51 +0300 Message-ID: References: <87y1l7b3iy.fsf@gmail.com> <87o7m3ax2c.fsf@gmail.com> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30635"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 63785@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 30 10:44:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q3uxj-0007mw-Ko for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 May 2023 10:44:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3uxY-0003lU-Mu; Tue, 30 May 2023 04:44:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3uxW-0003lB-Es for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 04:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3uxW-0004FF-6l for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 04:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3uxV-00051R-LC for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 04:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2023 08:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63785 X-GNU-PR-Package: emacs Original-Received: via spool by 63785-submit@debbugs.gnu.org id=B63785.168543623619287 (code B ref 63785); Tue, 30 May 2023 08:44:01 +0000 Original-Received: (at 63785) by debbugs.gnu.org; 30 May 2023 08:43:56 +0000 Original-Received: from localhost ([127.0.0.1]:60029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3uxQ-000511-Eb for submit@debbugs.gnu.org; Tue, 30 May 2023 04:43:56 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:37648 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3uxO-00050t-M1 for 63785@debbugs.gnu.org; Tue, 30 May 2023 04:43:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1685436234; bh=cEvQlmW2QQJmRafEt98yXgAyzj/m9L/cfaWHu6Tw824=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pmrWE3qjz2M7nsBJapQK5YczcRzEft7HI+OH15+cj7nmGwISMik8IqhMDQz2LuM2P 3L1i/kOTyCiSNnow18bfH7xApOQdtqZHlApLAONgRlpwHTcZy4ygBBECD3+f1WL0mN M0pCC4CkA++XUsbaU1ypOXOIdejfiNsetaE1fl+0nuDZNxSlnakNvf6zaJ3iwuE2rG kiV6uZ/2VNYnH7Hk7hC3Jd6J+HacNRedwgUW+zBCRh7v8rBwKhLd0ubSIT5gLQBWAG 54r6E8miE5uWyGLQIulzyEM/9+fCKqyuhZnLmKECrXS1Hq73YxDVh1UnIJ4S6m+1dZ ncFlRcTJHmdQg== In-Reply-To: <87o7m3ax2c.fsf@gmail.com> (Robert Pluim's message of "Mon, 29 May 2023 19:04:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262624 Archived-At: Robert Pluim writes: >>>>>> On Mon, 29 May 2023 19:48:45 +0300, Eshel Yaron = said: > > Eshel> Robert Pluim writes: > >> M-x list-packages > >> / n ack ;; navigate to the line for 'ack' > >> i ;; 'ack' has the 'I' flag > >> / / ;; 'ack' no longer has the I flag > >>=20 > >> This makes it harder to do 'search for foo, mark, > >> search for bar, mark, install', you have to remember to execute the > >> action after each mark command. > >>=20 > > Eshel> That's an interesting issue, it can be a bit tricky because wh= ile > Eshel> filtering for "bar", "foo" is no longer anywhere to be found i= n the > Eshel> buffer. So AFAIU to solve this Emacs needs to maintain someth= ing like a > Eshel> buffer-local association between list entry (package) ids and = the tags > Eshel> they were given. > > Eshel> This sounds like something that applies more broadly to other > Eshel> `tabulated-list-mode` derivatives as well. The attached patch= adds a > Eshel> `tabulated-list-maintain-tags` variable and enables it in > Eshel> `package-menu-mode`. With it I can search and mark foo, then = search and > Eshel> mark bar, and then install both, as you say. WDYT? > > It=CA=BCs close. The following is still suprising > > / n helm > i > / / > / n ack > i > x > > That only offer to installs ack, even though I=CA=BCve marked helm. If I > clear the filters then 'x' offers to install both. Although I could > argue that I=CA=BCm in a filtered state, so offering to install only > visible packages is normal :-) Yes, that's what I thought. Only installing visible packages when the menu is filtered seems sensible to me. Although I guess `package-menu-execute` could be extended with some option that says what to do in these cases, maybe by default it could suggest clearing the filter first?