* bug#9205: 24.0.50; colored mark in vc mode-line
@ 2011-07-29 11:13 Peter Münster
2012-04-10 23:56 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Peter Münster @ 2011-07-29 11:13 UTC (permalink / raw)
To: 9205
Hello,
Here a little feature request for vc:
--8<---------------cut here---------------start------------->8---
;; Make it immediately obvious, if file is modified or not, by a red or
;; a green point in the modeline.
;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
(defvar vc-state-mark-modeline t)
(defun vc-mark-modeline-dot (color)
(propertize " "
'display
`(image :type xpm
:data ,(format "/* XPM */
static char * data[] = {
\"18 13 3 1\",
\" c None\",
\"+ c #000000\",
\". c %s\",
\" \",
\" +++++ \",
\" +.....+ \",
\" +.......+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.........+ \",
\" +.......+ \",
\" +.....+ \",
\" +++++ \",
\" \"};"
color)
:ascent center)))
(defsubst vc-state->color (stat)
"Interpret vc-state symbol to mode line color"
(case stat
('edited "tomato" )
('up-to-date "GreenYellow" )
;; what is missing here??
;; ('unknown "gray" )
;; ('added "blue" )
;; ('deleted "red" )
;; ('unmerged "purple" )
(t "red")))
(defun vc-install-state-mark-modeline (color)
(push `(vc-state-mark-modeline ,(vc-mark-modeline-dot color))
mode-line-format))
(defun vc-uninstall-state-mark-modeline ()
(setq mode-line-format
(remove-if #'(lambda (mode) (eq (car-safe mode)
'vc-state-mark-modeline))
mode-line-format)))
(defadvice vc-default-mode-line-string
(before my-before-vc-mode-line-string activate)
(let* ((backend-name (symbol-name backend))
(state (vc-state file backend))
(color (vc-state->color state)))
(vc-uninstall-state-mark-modeline)
(vc-install-state-mark-modeline color)))
--8<---------------cut here---------------end--------------->8---
Cheers,
--
Peter
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2011-07-29 11:13 bug#9205: 24.0.50; colored mark in vc mode-line Peter Münster
@ 2012-04-10 23:56 ` Lars Magne Ingebrigtsen
2012-04-11 6:43 ` Chong Yidong
0 siblings, 1 reply; 20+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-04-10 23:56 UTC (permalink / raw)
To: Peter Münster; +Cc: 9205
pmlists@free.fr (Peter Münster) writes:
> Here a little feature request for vc:
> ;; Make it immediately obvious, if file is modified or not, by a red or
> ;; a green point in the modeline.
> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
I think that looks really nice. The code needs some massaging before
possible inclusion, but, Stefan (the other one), what do you think?
Does Stefan Reichoer have FSF copyright assignment papers on file,
though?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-10 23:56 ` Lars Magne Ingebrigtsen
@ 2012-04-11 6:43 ` Chong Yidong
2012-04-11 7:39 ` Stefan Reichör
0 siblings, 1 reply; 20+ messages in thread
From: Chong Yidong @ 2012-04-11 6:43 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen; +Cc: 9205, Peter Münster
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> pmlists@free.fr (Peter Münster) writes:
>
>> Here a little feature request for vc:
>> ;; Make it immediately obvious, if file is modified or not, by a red or
>> ;; a green point in the modeline.
>> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
>
> I think that looks really nice. The code needs some massaging before
> possible inclusion, but, Stefan (the other one), what do you think?
>
> Does Stefan Reichoer have FSF copyright assignment papers on file,
> though?
Yes. But I don't know think psvn.el is currently covered under his
copyright assignment. If he wants it to be covered, the procedure is
simple: he just has to send an email to fsf-records@gnu.org saying that
psvn.el should be covered under his existing assignment.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-11 6:43 ` Chong Yidong
@ 2012-04-11 7:39 ` Stefan Reichör
2012-04-12 13:39 ` Lars Magne Ingebrigtsen
2012-04-12 14:36 ` Stefan Monnier
0 siblings, 2 replies; 20+ messages in thread
From: Stefan Reichör @ 2012-04-11 7:39 UTC (permalink / raw)
To: Chong Yidong; +Cc: Lars Magne Ingebrigtsen, Peter Münster, 9205
Chong Yidong <cyd@gnu.org> writes:
> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> pmlists@free.fr (Peter Münster) writes:
>>
>>> Here a little feature request for vc:
>>> ;; Make it immediately obvious, if file is modified or not, by a red or
>>> ;; a green point in the modeline.
>>> ;; Code is from psvn.el by Stefan Reichoer (GNU GPL)
>>
>> I think that looks really nice. The code needs some massaging before
>> possible inclusion, but, Stefan (the other one), what do you think?
>>
>> Does Stefan Reichoer have FSF copyright assignment papers on file,
>> though?
>
> Yes. But I don't know think psvn.el is currently covered under his
> copyright assignment. If he wants it to be covered, the procedure is
> simple: he just has to send an email to fsf-records@gnu.org saying that
> psvn.el should be covered under his existing assignment.
Exactly. psvn.el is not covered. There are way to much contributors to
this package. If somebody is willing to contact them, I am fine with
that. But I don't want to do this.
The code for the color indication was integrated by me. I took the image
definition from somewhere else. The rest of the code was written by me.
Stefan.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-11 7:39 ` Stefan Reichör
@ 2012-04-12 13:39 ` Lars Magne Ingebrigtsen
2012-04-12 14:23 ` Peter Münster
2012-04-12 14:36 ` Stefan Monnier
1 sibling, 1 reply; 20+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-04-12 13:39 UTC (permalink / raw)
To: Stefan Reichör; +Cc: 9205, Peter Münster, Chong Yidong
Stefan Reichör <stefan@xsteve.at> writes:
> The code for the color indication was integrated by me. I took the image
> definition from somewhere else. The rest of the code was written by me.
Right. I guess we'd have to make a new image, which should be easy
enough, since it's just a circle.
And the rest of the code can't really be used as in the Emacs tree, so I
guess the copyright state of psvn.el isn't really that important.
But the main question is: Do we want to report the VC state in the mode
line? And if so, do we want to do it this graphically (on graphic
systems)? I think that something like this looks nice, and seems
useful.
What do all y'all think?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 13:39 ` Lars Magne Ingebrigtsen
@ 2012-04-12 14:23 ` Peter Münster
2012-04-12 16:07 ` Stefan Monnier
0 siblings, 1 reply; 20+ messages in thread
From: Peter Münster @ 2012-04-12 14:23 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen
Cc: Stefan Reichör, 9205, Peter Münster, Chong Yidong
On Thu, Apr 12 2012, Lars Magne Ingebrigtsen wrote:
> But the main question is: Do we want to report the VC state in the mode
> line?
For me it's "yes" (naturally... ;)
> And if so, do we want to do it this graphically (on graphic systems)?
Also yes. For those, who don't want it, there could be a configuration
variable.
--
Peter
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-11 7:39 ` Stefan Reichör
2012-04-12 13:39 ` Lars Magne Ingebrigtsen
@ 2012-04-12 14:36 ` Stefan Monnier
1 sibling, 0 replies; 20+ messages in thread
From: Stefan Monnier @ 2012-04-12 14:36 UTC (permalink / raw)
To: Stefan Reichör
Cc: Lars Magne Ingebrigtsen, Peter Münster, 9205, Chong Yidong
>> Yes. But I don't know think psvn.el is currently covered under his
>> copyright assignment. If he wants it to be covered, the procedure is
>> simple: he just has to send an email to fsf-records@gnu.org saying that
>> psvn.el should be covered under his existing assignment.
> Exactly. psvn.el is not covered. There are way to much contributors to
> this package. If somebody is willing to contact them, I am fine with
> that. But I don't want to do this.
That's just a misunderstanding: the email to fsf-records@gnu.org is not
about "all of psvn.el" but only about the part of psvn.el that you wrote
(and it couldn't be any other way, since you have no authority over the
copyright of other contributors).
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 14:23 ` Peter Münster
@ 2012-04-12 16:07 ` Stefan Monnier
2012-04-12 16:09 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Stefan Monnier @ 2012-04-12 16:07 UTC (permalink / raw)
To: Peter Münster
Cc: Lars Magne Ingebrigtsen, Stefan Reichör, 9205, Chong Yidong
>> But the main question is: Do we want to report the VC state in the mode
>> line?
> For me it's "yes" (naturally... ;)
Maybe I misunderstood the question, but we've been reporting the VC
state in the mode-line for as long as I can remember (except for pre-VC
times, obviously). And people don't seem annoyed by it very much, so we
can assume that it's a "yes".
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 16:07 ` Stefan Monnier
@ 2012-04-12 16:09 ` Lars Magne Ingebrigtsen
2012-04-12 18:22 ` Stefan Monnier
0 siblings, 1 reply; 20+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-04-12 16:09 UTC (permalink / raw)
To: Stefan Monnier
Cc: Peter Münster, 9205, Stefan Reichör, Chong Yidong
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> Maybe I misunderstood the question, but we've been reporting the VC
> state in the mode-line for as long as I can remember (except for pre-VC
> times, obviously). And people don't seem annoyed by it very much, so we
> can assume that it's a "yes".
You mean if you let the mouse hover over the thing that says
"Bzr-<foo>"? I don't see anything that changes visually, though, when a
file changes `vc-state'...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 16:09 ` Lars Magne Ingebrigtsen
@ 2012-04-12 18:22 ` Stefan Monnier
2012-04-12 18:24 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Stefan Monnier @ 2012-04-12 18:22 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen
Cc: Peter Münster, 9205, Stefan Reichör, Chong Yidong
>> Maybe I misunderstood the question, but we've been reporting the VC
>> state in the mode-line for as long as I can remember (except for pre-VC
>> times, obviously). And people don't seem annoyed by it very much, so we
>> can assume that it's a "yes".
> You mean if you let the mouse hover over the thing that says
> "Bzr-<foo>"? I don't see anything that changes visually, though, when a
> file changes `vc-state'...
The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
(locally modified), Bzr@nn (locally added), ... see
vc-default-mode-line-string.
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 18:22 ` Stefan Monnier
@ 2012-04-12 18:24 ` Lars Magne Ingebrigtsen
2012-04-12 18:51 ` Peter Münster
0 siblings, 1 reply; 20+ messages in thread
From: Lars Magne Ingebrigtsen @ 2012-04-12 18:24 UTC (permalink / raw)
To: Stefan Monnier
Cc: Peter Münster, 9205, Stefan Reichör, Chong Yidong
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
> (locally modified), Bzr@nn (locally added), ... see
> vc-default-mode-line-string.
Oh. That's really subtle. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 18:24 ` Lars Magne Ingebrigtsen
@ 2012-04-12 18:51 ` Peter Münster
2016-03-01 1:41 ` Lars Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Peter Münster @ 2012-04-12 18:51 UTC (permalink / raw)
To: Lars Magne Ingebrigtsen
Cc: Peter Münster, 9205, Stefan Reichör, Chong Yidong
On Thu, Apr 12 2012, Lars Magne Ingebrigtsen wrote:
> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
>> The text is supposed to change between Bzr-nn (unmodified), Bzr:nn
>> (locally modified), Bzr@nn (locally added), ... see
>> vc-default-mode-line-string.
>
> Oh. That's really subtle. :-)
Indeed. Even too subtle.
My eyes need something more glaring (e.g. a colored mark ... ;)
--
Peter
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2012-04-12 18:51 ` Peter Münster
@ 2016-03-01 1:41 ` Lars Ingebrigtsen
2016-03-01 1:47 ` Lars Ingebrigtsen
2016-03-01 2:05 ` Óscar Fuentes
0 siblings, 2 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2016-03-01 1:41 UTC (permalink / raw)
To: Peter Münster
Cc: 9205, Stefan Reichör, Stefan Monnier, Chong Yidong
I started to work on this now, but I thought I'd do it with SVGs, since
the size of the mode line can vary, and SVGs can be made on the fly.
However, I'm having trouble creating an SVG with transparent
backgrounds, and it needs to be that, because the mode line changes
background colour when the window is selected or not.
Doesn't Emacs support SVGs with transparent backgrounds?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 1:41 ` Lars Ingebrigtsen
@ 2016-03-01 1:47 ` Lars Ingebrigtsen
2016-03-01 2:05 ` Óscar Fuentes
1 sibling, 0 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2016-03-01 1:47 UTC (permalink / raw)
To: Peter Münster
Cc: 9205, Stefan Reichör, Stefan Monnier, Chong Yidong
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I started to work on this now, but I thought I'd do it with SVGs, since
> the size of the mode line can vary, and SVGs can be made on the fly.
>
> However, I'm having trouble creating an SVG with transparent
> backgrounds, and it needs to be that, because the mode line changes
> background colour when the window is selected or not.
>
> Doesn't Emacs support SVGs with transparent backgrounds?
Apparently not...
Anyway, here's as far as I got before I discovered the problem. We
could go with an XPM instead, but it would only approximately match the
height of the mode line, so I'm not sure it's worth it...
diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el
index 0c1718e..4a7acb8 100644
--- a/lisp/vc/vc-hooks.el
+++ b/lisp/vc/vc-hooks.el
@@ -717,6 +717,32 @@ vc-mode-line
(force-mode-line-update)
backend)
+(defun vc--face-color (color)
+ (concat
+ "#"
+ (mapconcat
+ (lambda (elem)
+ (format "%02x" (round (* elem 256))))
+ (color-name-to-rgb color)
+ "")))
+
+(defun vc--color-status (string color)
+ (if (not (image-type-available-p 'svg))
+ string
+ (propertize string
+ 'display
+ (let* ((height (- (window-font-height nil 'mode-line) 6))
+ (svg (svg-create height height)))
+ (svg-rectangle svg 0 0 height height
+ :fill-color (vc--face-color
+ (face-background 'mode-line)))
+ (svg-circle svg (/ height 2) (/ height 2) (/ height 2)
+ :fill-color color)
+ (let ((image (svg-image svg)))
+ (setf (image-property image :ascent) 80)
+ (setf (image-property image :scale) 1)
+ image)))))
+
(defun vc-default-mode-line-string (backend file)
"Return a string for `vc-mode-line' to put in the mode line for FILE.
Format:
@@ -739,11 +765,11 @@ vc-default-mode-line-string
(eq state 'needs-update))
(setq state-echo "Up to date file")
(setq face 'vc-up-to-date-state)
- (concat backend-name "-" rev))
+ (concat backend-name (vc--color-status "-" "green") rev))
((stringp state)
(setq state-echo (concat "File locked by" state))
(setq face 'vc-locked-state)
- (concat backend-name ":" state ":" rev))
+ (concat backend-name (vc--color-status ":" "orange") state ":" rev))
((eq state 'added)
(setq state-echo "Locally added file")
(setq face 'vc-locally-added-state)
@@ -751,22 +777,22 @@ vc-default-mode-line-string
((eq state 'conflict)
(setq state-echo "File contains conflicts after the last merge")
(setq face 'vc-conflict-state)
- (concat backend-name "!" rev))
+ (concat backend-name (vc--color-status "!" "red") rev))
((eq state 'removed)
(setq state-echo "File removed from the VC system")
(setq face 'vc-removed-state)
- (concat backend-name "!" rev))
+ (concat backend-name (vc--color-status "!" "red") rev))
((eq state 'missing)
(setq state-echo "File tracked by the VC system, but missing from the file system")
(setq face 'vc-missing-state)
- (concat backend-name "?" rev))
+ (concat backend-name (vc--color-status "?" "purple") rev))
(t
;; Not just for the 'edited state, but also a fallback
;; for all other states. Think about different symbols
;; for 'needs-update and 'needs-merge.
(setq state-echo "Locally modified file")
(setq face 'vc-edited-state)
- (concat backend-name ":" rev)))
+ (concat backend-name (vc--color-status ":" "blue") rev)))
'face face
'help-echo (concat state-echo " under the " backend-name
" version control system"))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply related [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 1:41 ` Lars Ingebrigtsen
2016-03-01 1:47 ` Lars Ingebrigtsen
@ 2016-03-01 2:05 ` Óscar Fuentes
2016-03-01 2:14 ` Lars Ingebrigtsen
1 sibling, 1 reply; 20+ messages in thread
From: Óscar Fuentes @ 2016-03-01 2:05 UTC (permalink / raw)
To: Lars Ingebrigtsen
Cc: Peter Münster, 9205, Stefan Reichör, Stefan Monnier,
Chong Yidong
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I started to work on this now, but I thought I'd do it with SVGs, since
> the size of the mode line can vary, and SVGs can be made on the fly.
I've not read the thread, sorry if I'm off-track. We now have specific
faces for the VC states on the modeline. Not as nifty as images, but you
can know the VC state at a glance.
From the NEWS entry:
*** The VC state indicator in the mode line now has different faces
corresponding to each of the possible states. See the `vc-faces'
customization group.
[snip]
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 2:05 ` Óscar Fuentes
@ 2016-03-01 2:14 ` Lars Ingebrigtsen
2016-03-01 2:24 ` Óscar Fuentes
0 siblings, 1 reply; 20+ messages in thread
From: Lars Ingebrigtsen @ 2016-03-01 2:14 UTC (permalink / raw)
To: Óscar Fuentes
Cc: Peter Münster, 9205, Stefan Reichör, Stefan Monnier,
Chong Yidong
Óscar Fuentes <ofv@wanadoo.es> writes:
>>From the NEWS entry:
>
> *** The VC state indicator in the mode line now has different faces
> corresponding to each of the possible states. See the `vc-faces'
> customization group.
These all default to the default face? That's not very handy. The
faces should, in my opinion, be nice without having to do any
customisation.
(defface vc-state-base-face
'((default))
"Base face for VC state indicator."
:group 'vc-faces
:group 'mode-line
:version "25.1")
(defface vc-up-to-date-state
'((default :inherit vc-state-base-face))
"Face for VC modeline state when the file is up to date."
:version "25.1"
:group 'vc-faces)
(etc)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 2:14 ` Lars Ingebrigtsen
@ 2016-03-01 2:24 ` Óscar Fuentes
2016-03-01 3:05 ` Lars Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Óscar Fuentes @ 2016-03-01 2:24 UTC (permalink / raw)
To: Lars Ingebrigtsen
Cc: Peter Münster, 9205, Stefan Reichör, Stefan Monnier,
Chong Yidong
Lars Ingebrigtsen <larsi@gnus.org> writes:
> These all default to the default face? That's not very handy. The
> faces should, in my opinion, be nice without having to do any
> customisation.
We discussed this on bug#19043. Feel free to assign nice defaults to
those faces :-)
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 2:24 ` Óscar Fuentes
@ 2016-03-01 3:05 ` Lars Ingebrigtsen
2016-03-09 23:49 ` Juri Linkov
2019-06-27 16:27 ` Lars Ingebrigtsen
0 siblings, 2 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2016-03-01 3:05 UTC (permalink / raw)
To: Óscar Fuentes
Cc: Peter Münster, 9205, Stefan Reichör, Stefan Monnier,
Chong Yidong
Óscar Fuentes <ofv@wanadoo.es> writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> These all default to the default face? That's not very handy. The
>> faces should, in my opinion, be nice without having to do any
>> customisation.
>
> We discussed this on bug#19043. Feel free to assign nice defaults to
> those faces :-)
Oh, it's all coming back to me now...
Ok, I'll assign some suitably "fruit salad with a nervous breakdown"
colours. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 3:05 ` Lars Ingebrigtsen
@ 2016-03-09 23:49 ` Juri Linkov
2019-06-27 16:27 ` Lars Ingebrigtsen
1 sibling, 0 replies; 20+ messages in thread
From: Juri Linkov @ 2016-03-09 23:49 UTC (permalink / raw)
To: 9205
More discussion at
https://lists.gnu.org/archive/html/emacs-devel/2016-03/msg00084.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#9205: 24.0.50; colored mark in vc mode-line
2016-03-01 3:05 ` Lars Ingebrigtsen
2016-03-09 23:49 ` Juri Linkov
@ 2019-06-27 16:27 ` Lars Ingebrigtsen
1 sibling, 0 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2019-06-27 16:27 UTC (permalink / raw)
To: Óscar Fuentes
Cc: Stefan Reichör, 9205, Peter Münster, Stefan Monnier,
Chong Yidong
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Óscar Fuentes <ofv@wanadoo.es> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> These all default to the default face? That's not very handy. The
>>> faces should, in my opinion, be nice without having to do any
>>> customisation.
>>
>> We discussed this on bug#19043. Feel free to assign nice defaults to
>> those faces :-)
>
> Oh, it's all coming back to me now...
>
> Ok, I'll assign some suitably "fruit salad with a nervous breakdown"
> colours. :-)
The change wasn't well received at the time (didn't John just revert it
or something?), so I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-06-27 16:27 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-29 11:13 bug#9205: 24.0.50; colored mark in vc mode-line Peter Münster
2012-04-10 23:56 ` Lars Magne Ingebrigtsen
2012-04-11 6:43 ` Chong Yidong
2012-04-11 7:39 ` Stefan Reichör
2012-04-12 13:39 ` Lars Magne Ingebrigtsen
2012-04-12 14:23 ` Peter Münster
2012-04-12 16:07 ` Stefan Monnier
2012-04-12 16:09 ` Lars Magne Ingebrigtsen
2012-04-12 18:22 ` Stefan Monnier
2012-04-12 18:24 ` Lars Magne Ingebrigtsen
2012-04-12 18:51 ` Peter Münster
2016-03-01 1:41 ` Lars Ingebrigtsen
2016-03-01 1:47 ` Lars Ingebrigtsen
2016-03-01 2:05 ` Óscar Fuentes
2016-03-01 2:14 ` Lars Ingebrigtsen
2016-03-01 2:24 ` Óscar Fuentes
2016-03-01 3:05 ` Lars Ingebrigtsen
2016-03-09 23:49 ` Juri Linkov
2019-06-27 16:27 ` Lars Ingebrigtsen
2012-04-12 14:36 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).