* bug#14823: file-notify-tests should be expected to fail when no file notificatio package
@ 2013-07-08 17:05 Glenn Morris
2013-07-09 7:57 ` Michael Albinus
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2013-07-08 17:05 UTC (permalink / raw)
To: 14823
Package: emacs
Version: 24.3.50
Current trunk for me on GNU/Linux:
cd test/automated
../../src/emacs -Q -batch -l ./file-notify-tests.el \
-f ert-run-tests-batch-and-exit
3 unexpected results:
FAILED file-notify-test00-availability
FAILED file-notify-test01-add-watch
FAILED file-notify-test02-events
Test file-notify-test02-events condition:
(file-notify-error "No file notification package available")
These tests should have ":expected-result :failed" when no file
notification package is available. (Ideally, they would be skipped, but
ert does not have that feature so :expected-result is the best we can do
at present.)
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#14823: file-notify-tests should be expected to fail when no file notificatio package
2013-07-08 17:05 bug#14823: file-notify-tests should be expected to fail when no file notificatio package Glenn Morris
@ 2013-07-09 7:57 ` Michael Albinus
2013-07-09 16:23 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2013-07-09 7:57 UTC (permalink / raw)
To: Glenn Morris; +Cc: 14823
Glenn Morris <rgm@gnu.org> writes:
> These tests should have ":expected-result :failed" when no file
> notification package is available. (Ideally, they would be skipped, but
> ert does not have that feature so :expected-result is the best we can do
> at present.)
Should be fixed now, could you please check?
When ert has a real skip feature, we could handle also the case to run
the tests for remote file systems, even when no file notification
package has been linked with Emacs. For now, we don't run them in this
case.
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#14823: file-notify-tests should be expected to fail when no file notificatio package
2013-07-09 7:57 ` Michael Albinus
@ 2013-07-09 16:23 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2013-07-09 16:23 UTC (permalink / raw)
To: Michael Albinus; +Cc: 14823
Michael Albinus wrote:
> Should be fixed now, could you please check?
Yes thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-09 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 17:05 bug#14823: file-notify-tests should be expected to fail when no file notificatio package Glenn Morris
2013-07-09 7:57 ` Michael Albinus
2013-07-09 16:23 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).