From: Glenn Morris <rgm@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43353@debbugs.gnu.org
Subject: bug#43353: 28.0.50; "make check" fails if there are non-ASCII characters in the Emacs path
Date: Sat, 12 Sep 2020 15:28:33 -0400 [thread overview]
Message-ID: <l9lfhekd5q.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87r1r72pul.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:31:46 +0200")
Lars Ingebrigtsen wrote:
> This is because test/Makefile puts a LC_ALL=C thing into the command
> line.
The LC_ALL=C should be removed, as it was from the main lisp Makefile in:
git show d0065ff1244 lisp/Makefile.in
(Ref https://debbugs.gnu.org/15260#82)
> (Which can be overridden by TEST_LOCALE
(Presumably just an attempt to generalize a feature that should never
have been there.)
> but then a bunch of tests will fail anyway, because a bunch of tests
> assume that we're in the C locale, apparently.)
Most failures were due to text-quoting-style.
For me there are now just two failures left:
1) lisp/vc/diff-mode-tests.log
This failure is due a deficiency of GNU diff, as described in
https://unix.stackexchange.com/questions/603249/how-to-make-diff-print-non-ascii-characters-in-file-names
It means that the file names returned by diff-hunk-file-names cannot be
found, so diff-syntax-fontify-hunk does nothing.
Perhaps diff-hunk-file-names should decode the diff header to work
around the GNU diff issue.
2) tramp-archive-test02-file-name-dissect
due to some extra "%25" in host as compared to url-hexify-string.
Perhaps there are more failures in check-expensive, but life's too short.
next prev parent reply other threads:[~2020-09-12 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 11:31 bug#43353: 28.0.50; "make check" fails if there are non-ASCII characters in the Emacs path Lars Ingebrigtsen
2020-09-12 19:28 ` Glenn Morris [this message]
2020-09-13 3:17 ` Glenn Morris
2020-09-13 11:31 ` Michael Albinus
2020-09-13 12:08 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=l9lfhekd5q.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=43353@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).