From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#43353: 28.0.50; "make check" fails if there are non-ASCII characters in the Emacs path Date: Sat, 12 Sep 2020 15:28:33 -0400 Message-ID: References: <87r1r72pul.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35709"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 43353@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 12 21:29:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHBCv-00099Z-53 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 21:29:09 +0200 Original-Received: from localhost ([::1]:38534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHBCu-0003bO-8S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Sep 2020 15:29:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHBCo-0003b9-4n for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 15:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHBCn-0007kQ-Re for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 15:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHBCn-0003AX-Nk for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2020 15:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Sep 2020 19:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43353 X-GNU-PR-Package: emacs Original-Received: via spool by 43353-submit@debbugs.gnu.org id=B43353.159993892612160 (code B ref 43353); Sat, 12 Sep 2020 19:29:01 +0000 Original-Received: (at 43353) by debbugs.gnu.org; 12 Sep 2020 19:28:46 +0000 Original-Received: from localhost ([127.0.0.1]:49067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHBCY-0003A4-FQ for submit@debbugs.gnu.org; Sat, 12 Sep 2020 15:28:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHBCU-00039p-1D for 43353@debbugs.gnu.org; Sat, 12 Sep 2020 15:28:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42284) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHBCO-0007iJ-Nh; Sat, 12 Sep 2020 15:28:36 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1kHBCL-00013T-SA; Sat, 12 Sep 2020 15:28:34 -0400 X-Spook: asset LABLINK Collapse Rule Psix BLU-114/B Biological X-Ran: yc)?i3;j;8%v=,xjLfN@V_XY8NLri(IHv{f)::Ft*~f;"mYvSg^LJDbOy@@J{K0+WoV2H[ X-Hue: yellow X-Attribution: GM In-Reply-To: <87r1r72pul.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Sep 2020 13:31:46 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187911 Archived-At: Lars Ingebrigtsen wrote: > This is because test/Makefile puts a LC_ALL=C thing into the command > line. The LC_ALL=C should be removed, as it was from the main lisp Makefile in: git show d0065ff1244 lisp/Makefile.in (Ref https://debbugs.gnu.org/15260#82) > (Which can be overridden by TEST_LOCALE (Presumably just an attempt to generalize a feature that should never have been there.) > but then a bunch of tests will fail anyway, because a bunch of tests > assume that we're in the C locale, apparently.) Most failures were due to text-quoting-style. For me there are now just two failures left: 1) lisp/vc/diff-mode-tests.log This failure is due a deficiency of GNU diff, as described in https://unix.stackexchange.com/questions/603249/how-to-make-diff-print-non-ascii-characters-in-file-names It means that the file names returned by diff-hunk-file-names cannot be found, so diff-syntax-fontify-hunk does nothing. Perhaps diff-hunk-file-names should decode the diff header to work around the GNU diff issue. 2) tramp-archive-test02-file-name-dissect due to some extra "%25" in host as compared to url-hexify-string. Perhaps there are more failures in check-expensive, but life's too short.