unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: "Jörg Bornemann" <foss@jbornemann.de>
Cc: 69186@debbugs.gnu.org
Subject: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode
Date: Wed, 21 Feb 2024 03:34:05 +0000	[thread overview]
Message-ID: <kSR9dx3jlfSK1fyS-98qB6SYtXwxRv55gPysIzNjhu2nn9w5TbQKlfVp_dC5cQLrvikGUz9itMcGoE-ElAmt8uhDZIab15QtCfggbWdsKb0=@rjt.dev> (raw)
In-Reply-To: <8734tq4z1p.fsf@jbornemann.de>

On Saturday, February 17th, 2024 at 15:26, Jörg Bornemann <foss@jbornemann.de> wrote:
> 
> 
> Tags: patch
> 
> 
> This might exceed the lines of code for the Copyright-paperwork-exempt
> marker. From my side, FSF paperwork is done and my "assignment awaits a
> countersignature from the deputy directory" since a while. In the
> meantime, let's have this change reviewed.

Thanks for working on this, it looks good to me.

I have a few small nits:
+(defun cmake-ts-mode--defun-name (node)
+  "Return the defun name of NODE.
+Return nil if there is no name or if NODE is not a defun node.  We
+consider CMake functions and macros as defuns."

I would drop the last sentence.

In the commit message:
(cmake-ts-mode): Set up treesit-defun-type-regexp and
treesit-defun-name-function. Change the imenu setup to recognize macros

One more space needed before "Change".





  parent reply	other threads:[~2024-02-21  3:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-17 20:26 bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Jörg Bornemann
2024-02-20 16:07 ` Randy Taylor
2024-02-21  3:34 ` Randy Taylor [this message]
2024-02-21 20:05   ` Jörg Bornemann
2024-02-21 20:53     ` Randy Taylor
2024-02-22 13:03     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='kSR9dx3jlfSK1fyS-98qB6SYtXwxRv55gPysIzNjhu2nn9w5TbQKlfVp_dC5cQLrvikGUz9itMcGoE-ElAmt8uhDZIab15QtCfggbWdsKb0=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=69186@debbugs.gnu.org \
    --cc=foss@jbornemann.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).