From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Date: Wed, 21 Feb 2024 03:34:05 +0000 Message-ID: References: <8734tq4z1p.fsf@jbornemann.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69186@debbugs.gnu.org To: =?UTF-8?Q?J=C3=B6rg?= Bornemann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 21 04:35:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcdNs-0001nb-5x for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Feb 2024 04:35:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcdNf-0003B8-8C; Tue, 20 Feb 2024 22:34:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcdNY-00037A-JU for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 22:34:40 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcdNY-0004qJ-AY for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 22:34:40 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcdNu-0006Y0-6z for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 22:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2024 03:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69186-submit@debbugs.gnu.org id=B69186.170848649425152 (code B ref 69186); Wed, 21 Feb 2024 03:35:02 +0000 Original-Received: (at 69186) by debbugs.gnu.org; 21 Feb 2024 03:34:54 +0000 Original-Received: from localhost ([127.0.0.1]:47534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcdNm-0006Xc-7e for submit@debbugs.gnu.org; Tue, 20 Feb 2024 22:34:54 -0500 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:53645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcdNj-0006XP-9Y for 69186@debbugs.gnu.org; Tue, 20 Feb 2024 22:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1708486462; x=1708745662; bh=jsj3UjREkgBhM5MSd6BMGVHN/a7FyKBm174ghTnnBLE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=CojF9ktNqXXYkVDNw49xeaYmnU3SDPW/VH0cN0R0fO2nWo8P1DwUopgVTBjua6sjx tPrSW85sEWigVZuhW/lMbOJUlexy99IF8V1os1MBYSoY6rBdXIuwiFsCDS0+5JrOiT j2puIf0lV2uMvLhi46NvNTdLnLenX5Sv0etKZmVpnfR5IkZbTD8E5XvBBJV0aQdKN8 LP6ZhmaMgcg5KVlSgzyZWW3MmwWnx0eoNyDqdYfWtuV+w546U9FZsAUtcoIESynga9 77fFlqDv0ZyQGHpdjeQFQ7NklIrG+4aXEroZIgL5jqZjPXt/KLyhIONaSQzoqOpZRd +ckK3d3WpOMtA== In-Reply-To: <8734tq4z1p.fsf@jbornemann.de> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280372 Archived-At: On Saturday, February 17th, 2024 at 15:26, J=C3=B6rg Bornemann wrote: >=20 >=20 > Tags: patch >=20 >=20 > This might exceed the lines of code for the Copyright-paperwork-exempt > marker. From my side, FSF paperwork is done and my "assignment awaits a > countersignature from the deputy directory" since a while. In the > meantime, let's have this change reviewed. Thanks for working on this, it looks good to me. I have a few small nits: +(defun cmake-ts-mode--defun-name (node) + "Return the defun name of NODE. +Return nil if there is no name or if NODE is not a defun node. We +consider CMake functions and macros as defuns." I would drop the last sentence. In the commit message: (cmake-ts-mode): Set up treesit-defun-type-regexp and treesit-defun-name-function. Change the imenu setup to recognize macros One more space needed before "Change".