From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: 13164@debbugs.gnu.org, Elias Pipping <pipping@lavabit.com>,
Tassilo Horn <tsdh@gnu.org>
Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode
Date: Wed, 23 Jan 2013 08:18:37 -0500 [thread overview]
Message-ID: <jwvzk00xd5n.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87r4lc1bhy.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Wed, 23 Jan 2013 10:42:33 +0100")
>>> Could someone bisect to find the commit that introduced this problem?
>> Yes, I can do that. I'll report back when I'm done.
> Ok, I'm done.
Thank you very much.
> --8<---------------cut here---------------start------------->8---
> 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d is the first bad commit
> commit 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d
> Author: Dmitry Antipov <dmantipov@yandex.ru>
> Date: Tue Dec 11 13:51:12 2012 +0400
> * buffer.c (Fset_buffer_multibyte): Do not force redisplay
> if changed buffer is not shown in a window.
> * insdel.c (prepare_to_modify_buffer): Likewise.
> * window.c (replace_buffer_in_windows_safely): Do nothing
> if buffer is not shown in a window.
> (Fforce_window_update): Likewise if string or buffer argument
> is passed.
Dmitry, could you take a look at this? It looks like the new code's
more aggressive avoidance of redisplay ends up leaving some mode-lines
out-of-date after running timers.
I don't see any immediate connection between the above commit message
and doc-view's timer behavior, so maybe the problem is a problem in
your commit.
OTOH maybe doc-view was simply lucky that the redisplay was not
optimized enough and we should really use something like the patch below,
> Are there any instructions on doing bisection on emacs bzr?
My impression that "bzr bisect" is in the same boat as "bzr switch" and
"bzr rebase": kinda works sometimes, but not nearly robust enough.
Stefan
=== modified file 'lisp/doc-view.el'
--- lisp/doc-view.el 2013-01-10 15:50:04 +0000
+++ lisp/doc-view.el 2013-01-23 13:14:23 +0000
@@ -1265,6 +1265,8 @@
"[0-9]+")
t)
'doc-view-sort))
+ (unless (eq (length prev-pages) (length doc-view-current-files))
+ (force-mode-line-update))
(dolist (win (or (get-buffer-window-list buffer nil t)
(list t)))
(let* ((page (doc-view-current-page win))
next prev parent reply other threads:[~2013-01-23 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <lltxrqdgs8.fsf@fencepost.gnu.org>
2013-01-09 20:28 ` bug#13164: [PATCH] View DjVu documents through doc-view-mode Stefan Monnier
2013-01-10 0:15 ` Elias Pipping
2013-01-10 15:50 ` Stefan Monnier
2013-01-11 15:02 ` Tassilo Horn
2013-01-21 23:10 ` Elias Pipping
2013-01-22 15:02 ` Stefan Monnier
2013-01-22 15:24 ` Tassilo Horn
2013-01-23 9:42 ` Tassilo Horn
2013-01-23 13:18 ` Stefan Monnier [this message]
2013-01-23 14:54 ` Dmitry Antipov
2013-01-24 7:39 ` Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzk00xd5n.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13164@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=pipping@lavabit.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).