From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13164: [PATCH] View DjVu documents through doc-view-mode Date: Wed, 23 Jan 2013 08:18:37 -0500 Message-ID: References: <8738y999lr.fsf@lavabit.com> <87wqvj3gpz.fsf@thinkpad.tsdh.de> <87fw1u2kuv.fsf@lavabit.com> <87d2wxqlz6.fsf@thinkpad.tsdh.de> <87r4lc1bhy.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1358947134 31663 80.91.229.3 (23 Jan 2013 13:18:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jan 2013 13:18:54 +0000 (UTC) Cc: 13164@debbugs.gnu.org, Elias Pipping , Tassilo Horn To: Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 23 14:19:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ty0EQ-0003Uu-62 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jan 2013 14:19:10 +0100 Original-Received: from localhost ([::1]:51608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ty0E8-0003cn-P2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jan 2013 08:18:52 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ty0E4-0003Ur-RS for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2013 08:18:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ty0E3-000141-Ac for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2013 08:18:48 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ty0E3-00013q-8R for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2013 08:18:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Ty0FF-0000TH-RP for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2013 08:20:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2013 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13164 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13164-submit@debbugs.gnu.org id=B13164.13589472001796 (code B ref 13164); Wed, 23 Jan 2013 13:20:01 +0000 Original-Received: (at 13164) by debbugs.gnu.org; 23 Jan 2013 13:20:00 +0000 Original-Received: from localhost ([127.0.0.1]:45887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty0FD-0000Ss-Cu for submit@debbugs.gnu.org; Wed, 23 Jan 2013 08:20:00 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47032) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty0FA-0000Sc-6R for 13164@debbugs.gnu.org; Wed, 23 Jan 2013 08:19:57 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r0NDIcAR005865; Wed, 23 Jan 2013 08:18:39 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 4658DAE194; Wed, 23 Jan 2013 08:18:37 -0500 (EST) In-Reply-To: <87r4lc1bhy.fsf@thinkpad.tsdh.de> (Tassilo Horn's message of "Wed, 23 Jan 2013 10:42:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1 X-NAI-Spam-Rules: 2 Rules triggered AFF_LOTTO_1=1, RV4470=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4470> : streams <893456> : uri <1325815> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70207 Archived-At: >>> Could someone bisect to find the commit that introduced this problem? >> Yes, I can do that. I'll report back when I'm done. > Ok, I'm done. Thank you very much. > --8<---------------cut here---------------start------------->8--- > 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d is the first bad commit > commit 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d > Author: Dmitry Antipov > Date: Tue Dec 11 13:51:12 2012 +0400 > * buffer.c (Fset_buffer_multibyte): Do not force redisplay > if changed buffer is not shown in a window. > * insdel.c (prepare_to_modify_buffer): Likewise. > * window.c (replace_buffer_in_windows_safely): Do nothing > if buffer is not shown in a window. > (Fforce_window_update): Likewise if string or buffer argument > is passed. Dmitry, could you take a look at this? It looks like the new code's more aggressive avoidance of redisplay ends up leaving some mode-lines out-of-date after running timers. I don't see any immediate connection between the above commit message and doc-view's timer behavior, so maybe the problem is a problem in your commit. OTOH maybe doc-view was simply lucky that the redisplay was not optimized enough and we should really use something like the patch below, > Are there any instructions on doing bisection on emacs bzr? My impression that "bzr bisect" is in the same boat as "bzr switch" and "bzr rebase": kinda works sometimes, but not nearly robust enough. Stefan === modified file 'lisp/doc-view.el' --- lisp/doc-view.el 2013-01-10 15:50:04 +0000 +++ lisp/doc-view.el 2013-01-23 13:14:23 +0000 @@ -1265,6 +1265,8 @@ "[0-9]+") t) 'doc-view-sort)) + (unless (eq (length prev-pages) (length doc-view-current-files)) + (force-mode-line-update)) (dolist (win (or (get-buffer-window-list buffer nil t) (list t))) (let* ((page (doc-view-current-page win))