From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 51130@debbugs.gnu.org, Carlos Pita <carlosjosepita2@gmail.com>
Subject: bug#51130: 29.0.50; shell completion fails to complete filenames
Date: Mon, 12 Sep 2022 10:33:35 -0400 [thread overview]
Message-ID: <jwvzgf464zk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a67496rq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Sep 2022 13:22:33 +0200")
> commit e17d9003618cef75852a0b88334cea66a5c4b016
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> AuthorDate: Sat Jun 4 09:31:34 2011 -0300
>
> * lisp/shell.el: Require and use pcomplete.
> (shell-dynamic-complete-functions): Add pcomplete-completions-at-point.
> (shell-completion-vars): Set pcomplete-default-completion-function.
>
> Just leaving pcomplete-default-completion-function alone seems to give
> better results in shell-mode (after testing very briefly), so I'm not
> sure why that was added.
It was added because leaving `pcomplete-default-completion-function`
alone means that the functions after `pcomplete-completions-at-point` in
`shell-dynamic-complete-functions` are not used any more.
Maybe that's indeed what we want.
I don't use `shell` enough to make such a decision.
[ And I don't understand why there's both `shell-filename-completion`
and `comint-filename-completion` in there either, which makes it even
more clear to me that I don't know what such changes imply. ]
Stefan
next prev parent reply other threads:[~2022-09-12 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 3:08 bug#51130: 29.0.50; shell completion fails to complete filenames Carlos Pita
2022-09-12 11:22 ` Lars Ingebrigtsen
2022-09-12 14:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-13 11:19 ` Lars Ingebrigtsen
2022-09-13 13:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-14 12:28 ` Lars Ingebrigtsen
2022-09-14 14:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-14 15:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvzgf464zk.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=51130@debbugs.gnu.org \
--cc=carlosjosepita2@gmail.com \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).