From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51130: 29.0.50; shell completion fails to complete filenames Date: Mon, 12 Sep 2022 10:33:35 -0400 Message-ID: References: <87a67496rq.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6996"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51130@debbugs.gnu.org, Carlos Pita To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 12 16:34:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXkWP-0001ag-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 16:34:49 +0200 Original-Received: from localhost ([::1]:56098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXkWO-0003nH-1d for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Sep 2022 10:34:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXkVe-0003n9-E7 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 10:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXkVe-00022H-66 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 10:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXkVd-0000nI-MO for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 10:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 14:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51130-submit@debbugs.gnu.org id=B51130.16629932373039 (code B ref 51130); Mon, 12 Sep 2022 14:34:01 +0000 Original-Received: (at 51130) by debbugs.gnu.org; 12 Sep 2022 14:33:57 +0000 Original-Received: from localhost ([127.0.0.1]:47554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXkVZ-0000mx-Hh for submit@debbugs.gnu.org; Mon, 12 Sep 2022 10:33:57 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXkVV-0000mi-0U for 51130@debbugs.gnu.org; Mon, 12 Sep 2022 10:33:56 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 71471803DC; Mon, 12 Sep 2022 10:33:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7F839803C3; Mon, 12 Sep 2022 10:33:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1662993220; bh=kugkl6ify+gDU9wXj15uoXzpV4o+TMa19TqPUcjCpIw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Q9mEg4XGl/14BZ6ZxuVIo9hZiiVxctsW+TmT0enplU45lmYE/Cf9xsPi+b2i6CGmw HNhy3B0vWfg5ZEj9DxyNCUsBE/FiXQO2BKUDFSPmGte5leOWWvugaS28EO2eGK1n/Q h/EfU78e1JU8T/HC+gE78FNeQX7uErFQZJj46oREnSW2ayF4SZVLiwRczc+ACbyM30 N1PRE2rC5J1oWLdf1kOEmoQBqgep8wWkRNVE8EqdIKUcoeN4U9gKmSWveb6Y/XxFWb f/Ug95siWxzTQEyIQkW54thuWjijF2wNjnEAy9AGZfK+/N1jAsI9iMxzq/7oKFgUBV yKc9HfqslzzVQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 761371201B4; Mon, 12 Sep 2022 10:33:40 -0400 (EDT) In-Reply-To: <87a67496rq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 12 Sep 2022 13:22:33 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242279 Archived-At: > commit e17d9003618cef75852a0b88334cea66a5c4b016 > Author: Stefan Monnier > AuthorDate: Sat Jun 4 09:31:34 2011 -0300 > > * lisp/shell.el: Require and use pcomplete. > (shell-dynamic-complete-functions): Add pcomplete-completions-at-point. > (shell-completion-vars): Set pcomplete-default-completion-function. > > Just leaving pcomplete-default-completion-function alone seems to give > better results in shell-mode (after testing very briefly), so I'm not > sure why that was added. It was added because leaving `pcomplete-default-completion-function` alone means that the functions after `pcomplete-completions-at-point` in `shell-dynamic-complete-functions` are not used any more. Maybe that's indeed what we want. I don't use `shell` enough to make such a decision. [ And I don't understand why there's both `shell-filename-completion` and `comint-filename-completion` in there either, which makes it even more clear to me that I don't know what such changes imply. ] Stefan