unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 17633@debbugs.gnu.org
Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p
Date: Sat, 31 May 2014 08:34:28 -0400	[thread overview]
Message-ID: <jwvy4xib02f.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87sins71nx@ristopher.com> (Christopher Schmidt's message of "Thu, 29 May 2014 16:47:05 -0400 (EDT)")

> AFAICS both issues are manifestations of the same bug because both of
> them only come up if point is on a character with a dedicated keymap.

Indeed, I installed the patch below which seems to fix them.
Can you confirm it fixes the problems you've seen?


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2014-05-31 01:01:19 +0000
+++ lisp/ChangeLog	2014-05-31 12:32:03 +0000
@@ -1,5 +1,8 @@
 2014-05-31  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+	* mouse.el (mouse-posn-property): Ignore posn-point for mode-line
+	clicks (bug#17633).
+
 	* leim/quail/latin-pre.el ("latin-2-prefix"): Use ",," rather than ", "
 	for the single comma, since ", " is *very* common in normal French text
 	(bug#17643).

=== modified file 'lisp/mouse.el'
--- lisp/mouse.el	2014-05-18 22:53:27 +0000
+++ lisp/mouse.el	2014-05-31 12:30:47 +0000
@@ -658,7 +658,10 @@
 	    (str (posn-string pos)))
 	(or (and str
 		 (get-text-property (cdr str) property (car str)))
-	    (and pt
+            ;; FIXME: mouse clicks on the mode-line come with a position in
+            ;; (nth 5).  Maybe we should change the C code instead so that
+            ;; mouse-clicks don't include a position there!
+	    (and pt (not (memq (posn-area pos) '(mode-line header-line)))
 		 (get-char-property pt property w))))
     (get-char-property pos property)))
 






  reply	other threads:[~2014-05-31 12:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29 17:45 bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Christopher Schmidt
2014-05-29 18:48 ` Stefan Monnier
2014-05-29 19:06   ` Christopher Schmidt
2014-05-29 20:32     ` Stefan Monnier
2014-05-29 20:47       ` Christopher Schmidt
2014-05-31 12:34         ` Stefan Monnier [this message]
2014-05-31 12:55           ` Christopher Schmidt
2014-05-31 13:00           ` Eli Zaretskii
2014-05-31 14:55             ` Stefan Monnier
2014-05-31 16:44               ` Eli Zaretskii
2014-05-31 20:11                 ` Stefan Monnier
2014-06-01  2:41                   ` Eli Zaretskii
2014-06-01 14:18                     ` Stefan Monnier
2014-06-01 14:57                       ` Eli Zaretskii
2014-06-01 21:13                         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy4xib02f.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17633@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).