From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 17633@debbugs.gnu.org
Subject: bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p
Date: Sat, 31 May 2014 10:55:54 -0400 [thread overview]
Message-ID: <jwvioom9ey8.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <831tvaf6go.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 31 May 2014 16:00:55 +0300")
> Can you explain the problem in more detail? I'm afraid I don't
> understand the problem with mouse clicks on mode line.
I think the real fix (which I intend to install into trunk) is the
one below: including `point' in a mouse-click is simply incorrect since
the current position of point has nothing to do with the mouse event.
Stefan
=== modified file 'src/keyboard.c'
--- src/keyboard.c 2014-05-30 04:12:08 +0000
+++ src/keyboard.c 2014-05-31 13:42:02 +0000
@@ -5266,9 +5266,7 @@
&object, &dx, &dy, &width, &height);
if (STRINGP (string))
string_info = Fcons (string, make_number (charpos));
- textpos = (w == XWINDOW (selected_window)
- && current_buffer == XBUFFER (w->contents))
- ? PT : marker_position (w->pointm);
+ textpos = Qnil;
xret = wx;
yret = wy;
next prev parent reply other threads:[~2014-05-31 14:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 17:45 bug#17633: 24.3.91; mouse-drag-line: Symbol's function definition is void: mouse--remap-link-click-p Christopher Schmidt
2014-05-29 18:48 ` Stefan Monnier
2014-05-29 19:06 ` Christopher Schmidt
2014-05-29 20:32 ` Stefan Monnier
2014-05-29 20:47 ` Christopher Schmidt
2014-05-31 12:34 ` Stefan Monnier
2014-05-31 12:55 ` Christopher Schmidt
2014-05-31 13:00 ` Eli Zaretskii
2014-05-31 14:55 ` Stefan Monnier [this message]
2014-05-31 16:44 ` Eli Zaretskii
2014-05-31 20:11 ` Stefan Monnier
2014-06-01 2:41 ` Eli Zaretskii
2014-06-01 14:18 ` Stefan Monnier
2014-06-01 14:57 ` Eli Zaretskii
2014-06-01 21:13 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvioom9ey8.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=17633@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).